From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 136A9C433DB for ; Thu, 24 Dec 2020 08:52:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4EC7223E4 for ; Thu, 24 Dec 2020 08:52:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727624AbgLXIwc (ORCPT ); Thu, 24 Dec 2020 03:52:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726591AbgLXIwb (ORCPT ); Thu, 24 Dec 2020 03:52:31 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4896CC0617A6 for ; Thu, 24 Dec 2020 00:51:51 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id r7so1543637wrc.5 for ; Thu, 24 Dec 2020 00:51:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=qP2XO0ngR1ghr+fNEQtPmScgoXBcnPP/lIItDhCDK2M=; b=Iryp6kYWS3NXejOjSaJPJiIIH/0NoO/EHvJzVCFh0J8O+x0zDFnTSiuQnH/zFl7aP/ xYQyvKNouvqduGnBh1KNTvINHBT5gH8fo/ieCBq1tAORoDt+64+ZQJS3sXRQ7L3YaW+E m0JA3O8kFRi4Q7gbDiakahTEejtUdVxrl3LTetORs8b4pQHaEQ740DUG3V8stdAFtw5f JXTOHKYTA0AupqarG3Ju47KQrtW3gC5H5KaKvXPVU+Bzdr0/ZfzXtmv5NCuAQcNeSgWf aRNYOxDnOFvu1x9nbZRFeOKSZIN0XWUJO3orCcHTnU+i6ywFuKki+XgVGfddShssVsLg gRPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=qP2XO0ngR1ghr+fNEQtPmScgoXBcnPP/lIItDhCDK2M=; b=b03DQWa+yasL8xAIgBY/v4Zq46+qp8qK/NlOjh/mIfxg5ykwhuhvsp1rVCSWWUTWYm 57KCBZkjxb4QoPyoC04579PsIfLw6ghf4FbHd5UdtslV/kJhrUcjkMp6opkdw6IdYwZw KqfsWwGMBYqBLFx2nkoKLY0rOItR1WlRcXSgDFnsEl4YfJvvcWcm+xAGX3WP+u6O2lgo 3yb9afCz/M3QIULIiKgeZt6C0cfcExJ4b3NG+tnYVa2PmahRjXYjTN1CG4WI2vk3cdwD HAyQif7FqxOAgAzn3EVGEZIFtdSZIsJAbZtTxkVEGDLSiiyEfJPkxiqZfgjYTLrfbbxB sHcA== X-Gm-Message-State: AOAM532ykyqTt1FVTRCcPTimQScGVRce5UdQqKAPTX6LaMyVecD8MmGw 9DMkFkqye+m1vjW0f0G78Buw0w== X-Google-Smtp-Source: ABdhPJwMWyYathVI8voQEL5w+ZGTezLUadtdsVtsEAYFpKlLaXykiPJDAwHZ0o6p8CQ/DkLr/RTVPg== X-Received: by 2002:a5d:4491:: with SMTP id j17mr32512895wrq.78.1608799909968; Thu, 24 Dec 2020 00:51:49 -0800 (PST) Received: from dell ([91.110.221.181]) by smtp.gmail.com with ESMTPSA id w13sm37720655wrt.52.2020.12.24.00.51.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Dec 2020 00:51:49 -0800 (PST) Date: Thu, 24 Dec 2020 08:51:47 +0000 From: Lee Jones To: Yoshihiro Shimoda Cc: marek.vasut+renesas@gmail.com, matti.vaittinen@fi.rohmeurope.com, lgirdwood@gmail.com, broonie@kernel.org, linus.walleij@linaro.org, bgolaszewski@baylibre.com, khiem.nguyen.xt@renesas.com, linux-power@fi.rohmeurope.com, linux-gpio@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 11/12] mfd: bd9571mwv: Make the driver more generic Message-ID: <20201224085147.GH681741@dell> References: <1608793457-11997-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1608793457-11997-12-git-send-email-yoshihiro.shimoda.uh@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1608793457-11997-12-git-send-email-yoshihiro.shimoda.uh@renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Dec 2020, Yoshihiro Shimoda wrote: > From: Khiem Nguyen > > Since the driver supports BD9571MWV PMIC only, this patch makes > the functions and data structure become more generic so that > it can support other PMIC variants as well. Also remove printing > part name which Lee Jones suggested. > > Signed-off-by: Khiem Nguyen > Co-developed-by: Yoshihiro Shimoda > Signed-off-by: Yoshihiro Shimoda > Reviewed-by: Matti Vaittinen > --- > drivers/mfd/bd9571mwv.c | 77 +++++++++++++++++++++++-------------------- > include/linux/mfd/bd9571mwv.h | 18 ++-------- > 2 files changed, 43 insertions(+), 52 deletions(-) For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog