From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95A98C433E6 for ; Mon, 28 Dec 2020 22:57:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56C51223C8 for ; Mon, 28 Dec 2020 22:57:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732309AbgL1W4e (ORCPT ); Mon, 28 Dec 2020 17:56:34 -0500 Received: from mga17.intel.com ([192.55.52.151]:18631 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727795AbgL1Wzc (ORCPT ); Mon, 28 Dec 2020 17:55:32 -0500 IronPort-SDR: +UegUQW+HNgdpnQbckhf3QEZKFkdFD2Z8FGfSoh+Z3lXVcpUoRwqznQY8AAC5XhfZqDC19X1W9 aIc75MvaiWnA== X-IronPort-AV: E=McAfee;i="6000,8403,9848"; a="156219592" X-IronPort-AV: E=Sophos;i="5.78,456,1599548400"; d="scan'208";a="156219592" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2020 14:54:50 -0800 IronPort-SDR: P8pRkp4r4hleaTdW98lANxtwRf91Y1VewUXny3A6f5SumEy48JGwSfyQyqMDBPQcqmziskMV8e WeEiLzDvAsLQ== X-IronPort-AV: E=Sophos;i="5.78,456,1599548400"; d="scan'208";a="400097145" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2020 14:54:44 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1ku1QX-000IqD-09; Tue, 29 Dec 2020 00:55:45 +0200 Date: Tue, 29 Dec 2020 00:55:44 +0200 From: Andy Shevchenko To: Daniel Scally Cc: Sakari Ailus , Linux Kernel Mailing List , ACPI Devel Maling List , Linux Media Mailing List , devel@acpica.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Yong Zhi , Bingbu Cao , Tian Shu Qiu , Mauro Carvalho Chehab , Robert Moore , Erik Kaneda , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes , Laurent Pinchart , Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, Hans Verkuil , Marco Felsch , niklas.soderlund+renesas@ragnatech.se, Steve Longerbeam , "Krogerus, Heikki" , Linus Walleij , Jordan Hand , Laurent Pinchart Subject: Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver Message-ID: <20201228225544.GH4077@smile.fi.intel.com> References: <20201224010907.263125-1-djrscally@gmail.com> <20201224010907.263125-15-djrscally@gmail.com> <20201228170521.GZ26370@paasikivi.fi.intel.com> <2d37df3d-f04c-6679-6e27-6c7f82e9b158@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d37df3d-f04c-6679-6e27-6c7f82e9b158@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 28, 2020 at 10:37:38PM +0000, Daniel Scally wrote: > On 28/12/2020 17:05, Sakari Ailus wrote: > > On Thu, Dec 24, 2020 at 02:54:44PM +0200, Andy Shevchenko wrote: ... > >>> +#include > >>> + > >>> +#define CIO2_HID "INT343E" > >>> +#define CIO2_NUM_PORTS 4 > > > > This is already defined in ipu3-cio2.h. Could you include that instead? > > Yes; but I'd need to also include media/v4l2-device.h and > media/videobuf2-dma-sg.h (they're included in ipu3-cio2-main.c at the > moment). It didn't seem worth it; but I can move those two includes from > the .c to the .h and then include ipu3-cio2.h in cio2-bridge.h > > Which do you prefer? Actually ipu3-cio2.h misses a lot of inclusions (like mutex.h which I immediately noticed when scrolled over data types). I think here should be a compromise variant, split out something like ipu3-cio2-defs.h which can be included in both ipu3-cio2.h and cio2-bridge.h. And cio2-bridge.h needs more inclusions like types.h. -- With Best Regards, Andy Shevchenko