From: Alex Elder <elder@linaro.org>
To: davem@davemloft.net, kuba@kernel.org
Cc: evgreen@chromium.org, bjorn.andersson@linaro.org,
cpratapa@codeaurora.org, subashab@codeaurora.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next 3/7] net: ipa: introduce an IPA interconnect structure
Date: Fri, 15 Jan 2021 06:50:46 -0600 [thread overview]
Message-ID: <20210115125050.20555-4-elder@linaro.org> (raw)
In-Reply-To: <20210115125050.20555-1-elder@linaro.org>
Rather than having separate pointers for the memory, imem, and
config interconnect paths, maintain an array of ipa_interconnect
structures each of which contains a pointer to a path.
Signed-off-by: Alex Elder <elder@linaro.org>
---
drivers/net/ipa/ipa_clock.c | 59 +++++++++++++++++++++----------------
1 file changed, 34 insertions(+), 25 deletions(-)
diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c
index baedb481fe824..2bf5af6823d8c 100644
--- a/drivers/net/ipa/ipa_clock.c
+++ b/drivers/net/ipa/ipa_clock.c
@@ -30,23 +30,27 @@
* An IPA clock reference must be held for any access to IPA hardware.
*/
+/**
+ * struct ipa_interconnect - IPA interconnect information
+ * @path: Interconnect path
+ */
+struct ipa_interconnect {
+ struct icc_path *path;
+};
+
/**
* struct ipa_clock - IPA clocking information
* @count: Clocking reference count
* @mutex: Protects clock enable/disable
* @core: IPA core clock
- * @memory_path: Memory interconnect
- * @imem_path: Internal memory interconnect
- * @config_path: Configuration space interconnect
+ * @interconnect: Interconnect array
* @interconnect_data: Interconnect configuration data
*/
struct ipa_clock {
refcount_t count;
struct mutex mutex; /* protects clock enable/disable */
struct clk *core;
- struct icc_path *memory_path;
- struct icc_path *imem_path;
- struct icc_path *config_path;
+ struct ipa_interconnect *interconnect[IPA_INTERCONNECT_COUNT];
const struct ipa_interconnect_data *interconnect_data;
};
@@ -71,24 +75,24 @@ static int ipa_interconnect_init(struct ipa_clock *clock, struct device *dev)
path = ipa_interconnect_init_one(dev, "memory");
if (IS_ERR(path))
goto err_return;
- clock->memory_path = path;
+ clock->interconnect[IPA_INTERCONNECT_MEMORY]->path = path;
path = ipa_interconnect_init_one(dev, "imem");
if (IS_ERR(path))
goto err_memory_path_put;
- clock->imem_path = path;
+ clock->interconnect[IPA_INTERCONNECT_IMEM]->path = path;
path = ipa_interconnect_init_one(dev, "config");
if (IS_ERR(path))
goto err_imem_path_put;
- clock->config_path = path;
+ clock->interconnect[IPA_INTERCONNECT_CONFIG]->path = path;
return 0;
err_imem_path_put:
- icc_put(clock->imem_path);
+ icc_put(clock->interconnect[IPA_INTERCONNECT_IMEM]->path);
err_memory_path_put:
- icc_put(clock->memory_path);
+ icc_put(clock->interconnect[IPA_INTERCONNECT_MEMORY]->path);
err_return:
return PTR_ERR(path);
}
@@ -96,9 +100,9 @@ static int ipa_interconnect_init(struct ipa_clock *clock, struct device *dev)
/* Inverse of ipa_interconnect_init() */
static void ipa_interconnect_exit(struct ipa_clock *clock)
{
- icc_put(clock->config_path);
- icc_put(clock->imem_path);
- icc_put(clock->memory_path);
+ icc_put(clock->interconnect[IPA_INTERCONNECT_CONFIG]->path);
+ icc_put(clock->interconnect[IPA_INTERCONNECT_IMEM]->path);
+ icc_put(clock->interconnect[IPA_INTERCONNECT_MEMORY]->path);
}
/* Currently we only use one bandwidth level, so just "enable" interconnects */
@@ -109,29 +113,31 @@ static int ipa_interconnect_enable(struct ipa *ipa)
int ret;
data = &clock->interconnect_data[IPA_INTERCONNECT_MEMORY];
- ret = icc_set_bw(clock->memory_path, data->average_bandwidth,
- data->peak_bandwidth);
+ ret = icc_set_bw(clock->interconnect[IPA_INTERCONNECT_MEMORY]->path,
+ data->average_bandwidth, data->peak_bandwidth);
if (ret)
return ret;
data = &clock->interconnect_data[IPA_INTERCONNECT_IMEM];
- ret = icc_set_bw(clock->imem_path, data->average_bandwidth,
- data->peak_bandwidth);
+ ret = icc_set_bw(clock->interconnect[IPA_INTERCONNECT_IMEM]->path,
+ data->average_bandwidth, data->peak_bandwidth);
if (ret)
goto err_memory_path_disable;
data = &clock->interconnect_data[IPA_INTERCONNECT_CONFIG];
- ret = icc_set_bw(clock->config_path, data->average_bandwidth,
- data->peak_bandwidth);
+ ret = icc_set_bw(clock->interconnect[IPA_INTERCONNECT_CONFIG]->path,
+ data->average_bandwidth, data->peak_bandwidth);
if (ret)
goto err_imem_path_disable;
return 0;
err_imem_path_disable:
- (void)icc_set_bw(clock->imem_path, 0, 0);
+ (void)icc_set_bw(clock->interconnect[IPA_INTERCONNECT_IMEM]->path,
+ 0, 0);
err_memory_path_disable:
- (void)icc_set_bw(clock->memory_path, 0, 0);
+ (void)icc_set_bw(clock->interconnect[IPA_INTERCONNECT_MEMORY]->path,
+ 0, 0);
return ret;
}
@@ -143,15 +149,18 @@ static void ipa_interconnect_disable(struct ipa *ipa)
int result = 0;
int ret;
- ret = icc_set_bw(clock->memory_path, 0, 0);
+ ret = icc_set_bw(clock->interconnect[IPA_INTERCONNECT_MEMORY]->path,
+ 0, 0);
if (ret)
result = ret;
- ret = icc_set_bw(clock->imem_path, 0, 0);
+ ret = icc_set_bw(clock->interconnect[IPA_INTERCONNECT_IMEM]->path,
+ 0, 0);
if (ret && !result)
result = ret;
- ret = icc_set_bw(clock->config_path, 0, 0);
+ ret = icc_set_bw(clock->interconnect[IPA_INTERCONNECT_CONFIG]->path,
+ 0, 0);
if (ret && !result)
result = ret;
--
2.20.1
next prev parent reply other threads:[~2021-01-15 12:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 12:50 [PATCH net-next 0/7] net: ipa: interconnect improvements Alex Elder
2021-01-15 12:50 ` [PATCH net-next 1/7] net: ipa: rename interconnect settings Alex Elder
2021-01-15 12:50 ` [PATCH net-next 2/7] net: ipa: don't return an error from ipa_interconnect_disable() Alex Elder
2021-01-15 12:50 ` Alex Elder [this message]
2021-01-15 12:50 ` [PATCH net-next 4/7] net: ipa: store average and peak interconnect bandwidth Alex Elder
2021-01-15 12:50 ` [PATCH net-next 5/7] net: ipa: add interconnect name to configuration data Alex Elder
2021-01-15 12:50 ` [PATCH net-next 6/7] net: ipa: clean up interconnect initialization Alex Elder
2021-01-15 12:50 ` [PATCH net-next 7/7] net: ipa: allow arbitrary number of interconnects Alex Elder
2021-01-17 3:12 ` Jakub Kicinski
2021-01-17 16:03 ` Alex Elder
2021-01-18 19:58 ` Jakub Kicinski
2021-01-18 20:27 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115125050.20555-4-elder@linaro.org \
--to=elder@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).