From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,
	INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id EB8CCC433E9
	for <linux-kernel@archiver.kernel.org>; Mon, 18 Jan 2021 15:47:02 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id BBC2A22CF6
	for <linux-kernel@archiver.kernel.org>; Mon, 18 Jan 2021 15:47:02 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2405701AbhARPqw (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 18 Jan 2021 10:46:52 -0500
Received: from ms.lwn.net ([45.79.88.28]:49906 "EHLO ms.lwn.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S2405477AbhARPeZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 18 Jan 2021 10:34:25 -0500
Received: from lwn.net (unknown [IPv6:2601:281:8300:104d::5f6])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ms.lwn.net (Postfix) with ESMTPSA id 19242385;
        Mon, 18 Jan 2021 15:33:08 +0000 (UTC)
DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net 19242385
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203;
        t=1610983988; bh=XC7KRMeUDNxNiOYz2a2HT8kOQVSM5OckAmd87Y8oQvw=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=Hgl09VVwWWUMo6xbZvho6YKf49FldIleZSiRXJB/6yjTJXdm/9mOVi7QLoRNczXSn
         z0rsd77UdJa9mlf2KToHng++tJWfI/Ki75i2X3pwZKrAFu+X1rQ/7RFP2hJvwFtTj9
         1AvD90LFLMz56/2Bv2cFx1DASAooc/lIET6qCLuiMNogN9vpr3FvDet29oEKaakx/a
         O6CgOvtZxNF7QAFCYuzpjBYkymQZxHwrugaW9v1EqXyM3PmNGvtDrOWTM5b/ByD6cf
         mYScIrliAi1Kv0zdwe33Fn6AZuH3Up8MEFNwMWADXzQxQigbIZvRScJgumYVWMA9I5
         4C08pDaZOSylA==
Date:   Mon, 18 Jan 2021 08:33:06 -0700
From:   Jonathan Corbet <corbet@lwn.net>
To:     Brendan Jackman <jackmanb@google.com>
Cc:     bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii.nakryiko@gmail.com>,
        KP Singh <kpsingh@chromium.org>,
        Florent Revest <revest@chromium.org>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH bpf-next] docs: bpf: Fixup atomics documentation
Message-ID: <20210118083306.4c16153d@lwn.net>
In-Reply-To: <20210118113643.232579-1-jackmanb@google.com>
References: <20210118113643.232579-1-jackmanb@google.com>
Organization: LWN.net
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 18 Jan 2021 11:36:43 +0000
Brendan Jackman <jackmanb@google.com> wrote:

> This fixues up the markup to fix a warning, be more consistent with
> use of monospace, and use the correct .rst syntax for <em> (* instead
> of _). It also clarifies the explanation of Clang's -mcpu
> requirements for this feature, Alexei pointed out that use of the
> word "version" was confusing here.

This starts to sound like material for more than one patch...?

> NB this conflicts with Lukas' patch at [1], here where I've added
> `::` to fix the warning, I also kept the original ':' which appears
> in the output text.

And why did you do that?  

> [1] https://lore.kernel.org/bpf/CA+i-1C3cEXqxcXfD4sibQfx+dtmmzvOzruhk8J5pAw3g5v=KgA@mail.gmail.com/T/#t
> 
> Signed-off-by: Brendan Jackman <jackmanb@google.com>
> ---
>  Documentation/networking/filter.rst | 30 +++++++++++++++--------------
>  1 file changed, 16 insertions(+), 14 deletions(-)
> 
> diff --git a/Documentation/networking/filter.rst b/Documentation/networking/filter.rst
> index f6d8f90e9a56..ba03e90a9163 100644
> --- a/Documentation/networking/filter.rst
> +++ b/Documentation/networking/filter.rst
> @@ -1048,12 +1048,12 @@ Unlike classic BPF instruction set, eBPF has generic load/store operations::
>  Where size is one of: BPF_B or BPF_H or BPF_W or BPF_DW.
>  
>  It also includes atomic operations, which use the immediate field for extra
> -encoding.
> +encoding: ::

Things like this read really strangely.  Just say "encoding::" and be done
with it, please.

Thanks,

jon