From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 657F2C433E0 for ; Tue, 19 Jan 2021 22:44:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F17B22D08 for ; Tue, 19 Jan 2021 22:44:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730564AbhASWoA (ORCPT ); Tue, 19 Jan 2021 17:44:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:33326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405128AbhASOc1 (ORCPT ); Tue, 19 Jan 2021 09:32:27 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9255D206E5; Tue, 19 Jan 2021 14:31:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611066706; bh=NfQU7Bh2uGMJeTO1WgOYbXM6ko6/LlpUampJfSpsipY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SrigU5FPI0Ij6S0yCfy3btTTVYmZ21Kog35h7ZfbCA3lL/nF60IGKYii68Qjny6qz fecUUSH/PaMNni3xl4FPTGy5Og3BE9SmovOULwnvYf7z0NUHRFmqNmzY9/52/gHrpm ySJCEzXWay0OfgI4nzrW4Xx4760SRj5f1oO03XDBn7kSNNsn4py8Mx5ndFFi74YRa1 n6bypWLiR/i5S+c2sWJHevMWbb8SM1iLw2nUJFmlx//kVQoUHKHuFCmQu7XtnC+S2s AxHp0QUpsInrqyY1aRGtBvbc3vjYZKHCGpudJIdEsxZg+SNDJ8iZjuhpZMkVp3eBXu Iw9q+Mj7qT0dQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id F3B6F40CE2; Tue, 19 Jan 2021 11:31:43 -0300 (-03) Date: Tue, 19 Jan 2021 11:31:43 -0300 From: Arnaldo Carvalho de Melo To: Song Liu Cc: open list , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Namhyung Kim , Mark Rutland , Jiri Olsa , Kernel Team Subject: Re: [PATCH v7 3/3] perf-stat: enable counting events for BPF programs Message-ID: <20210119143143.GJ12699@kernel.org> References: <20201229214214.3413833-1-songliubraving@fb.com> <20201229214214.3413833-4-songliubraving@fb.com> <20210118193817.GG12699@kernel.org> <379919CC-594F-40C5-A10E-97E048F73AE2@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <379919CC-594F-40C5-A10E-97E048F73AE2@fb.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Jan 19, 2021 at 12:48:19AM +0000, Song Liu escreveu: > > On Jan 18, 2021, at 11:38 AM, Arnaldo Carvalho de Melo wrote: > We are looking at two issues: > 1. Cannot recursively attach; > 2. prog FD 3 doesn't have valid btf. > #1 was caused by the verifier disallowing attaching fentry/fexit program > to program with type BPF_PROG_TYPE_TRACING (in bpf_check_attach_target). > This constraint was added when we only had fentry/fexit in the TRACING > type. We have extended the TRACING type to many other use cases, like > "tp_btf/", "fmod_ret" and "iter/". Therefore, it is good time to revisit > this constraint. I will work on this. > For #2, we require the target program to have BTF. I guess we won't remove > this requirement. > While I work on improving #1, could you please test with some kprobe > programs? For example, we can use fileslower.py from bcc. Sure, and please consider improving the error messages to state what you described above. - Arnaldo