From: Andrew Halaney <ahalaney@redhat.com>
To: Jason Baron <jbaron@akamai.com>, Jonathan Corbet <corbet@lwn.net>,
Jim Cromie <jim.cromie@gmail.com>
Cc: Andrew Halaney <ahalaney@redhat.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/3] Documentation: dyndbg: Improve cli param examples
Date: Mon, 13 Sep 2021 17:24:40 -0500 [thread overview]
Message-ID: <20210913222440.731329-4-ahalaney@redhat.com> (raw)
In-Reply-To: <20210913222440.731329-1-ahalaney@redhat.com>
Jim pointed out that using $module.dyndbg= is always a more flexible
choice for using dynamic debug on the command line. The $module.dyndbg
style is checked at boot and handles if $module is a builtin. If it is
actually a loadable module, it is handled again later when the module is
loaded.
If you just use dyndbg="module $module +p" dynamic debug is only enabled
when $module is a builtin.
It was recommended to illustrate wildcard usage as well.
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
Suggested-by: Jim Cromie <jim.cromie@gmail.com>
---
Documentation/admin-guide/dynamic-debug-howto.rst | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst
index d0911e7cc271..4bfb23ed64ec 100644
--- a/Documentation/admin-guide/dynamic-debug-howto.rst
+++ b/Documentation/admin-guide/dynamic-debug-howto.rst
@@ -357,7 +357,10 @@ Examples
Kernel command line: ...
// see whats going on in dyndbg=value processing
dynamic_debug.verbose=1
- // enable pr_debugs in 2 builtins, #cmt is stripped
- dyndbg="module params +p #cmt ; module sys +p"
+ // Enable pr_debugs in the params builtin
+ params.dyndbg="+p"
+ // enable pr_debugs in all files under init/
+ // and the function pc87360_init_device, #cmt is stripped
+ dyndbg="file init/* +p #cmt ; func pc87360_init_device +p"
// enable pr_debugs in 2 functions in a module loaded later
pc87360.dyndbg="func pc87360_init_device +p; func pc87360_find +p"
--
2.31.1
next prev parent reply other threads:[~2021-09-13 22:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 22:24 [PATCH v2 0/3] Trivial dynamic debug fixups Andrew Halaney
2021-09-13 22:24 ` [PATCH v2 1/3] dyndbg: make dyndbg a known cli param Andrew Halaney
2021-09-13 22:24 ` [PATCH v2 2/3] dyndbg: Remove support for ddebug_query param Andrew Halaney
2021-09-13 22:24 ` Andrew Halaney [this message]
2021-09-17 19:50 ` [PATCH v2 3/3] Documentation: dyndbg: Improve cli param examples Jason Baron
2021-09-17 20:30 ` jim.cromie
2021-09-17 20:53 ` Andrew Halaney
2021-09-17 21:54 ` Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210913222440.731329-4-ahalaney@redhat.com \
--to=ahalaney@redhat.com \
--cc=corbet@lwn.net \
--cc=jbaron@akamai.com \
--cc=jim.cromie@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).