From: Bjorn Helgaas <helgaas@kernel.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org, linux-doc@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Ahmed S. Darwish" <darwi@linutronix.de>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] PCI/MSI: api: Use bullet lists in kernel-doc comments
Date: Mon, 21 Nov 2022 06:34:02 -0600 [thread overview]
Message-ID: <20221121123402.GA100653@bhelgaas> (raw)
In-Reply-To: <20221121101245.23544-1-bagasdotme@gmail.com>
Hi Bagas,
If you have opportunity, please update the subject line to remove
"api: " to match previous history:
PCI/MSI: Correct 'can_mask' test in msi_add_msi_desc()
PCI/MSI: Remove bogus warning in pci_irq_get_affinity()
PCI/MSI: Prevent UAF in error path
PCI/MSI: Unbreak pci_irq_get_affinity()
PCI/MSI: Use msi_on_each_desc()
PCI/MSI: Let core code free MSI descriptors
PCI/MSI: Use msi_add_msi_desc()
PCI/MSI: Protect MSI operations
PCI/MSI: Simplify pci_irq_get_affinity()
...
On Mon, Nov 21, 2022 at 05:12:45PM +0700, Bagas Sanjaya wrote:
> Stephen Rothwell reported htmldocs warnings when merging tip tree:
>
> Documentation/PCI/msi-howto:380: drivers/pci/msi/api.c:148: ERROR: Unexpected indentation.
> Documentation/PCI/msi-howto:380: drivers/pci/msi/api.c:149: WARNING: Block quote ends without a blank line; unexpected unindent.
> Documentation/PCI/msi-howto:380: drivers/pci/msi/api.c:236: ERROR: Unexpected indentation.
> Documentation/PCI/msi-howto:380: drivers/pci/msi/api.c:259: ERROR: Unexpected indentation.
>
> Use bullet lists syntax for pci_disable_msix flags and interrupt mode lists
> to fix these warnings.
>
> Link: https://lore.kernel.org/linux-next/20221121184100.0974cc35@canb.auug.org.au/
> Fixes: 5c0997dc33ac24 ("PCI/MSI: Move pci_alloc_irq_vectors() to api.c")
> Fixes: 017239c8db2093 ("PCI/MSI: Move pci_irq_vector() to api.c")
> Fixes: be37b8428b7b77 ("PCI/MSI: Move pci_irq_get_affinity() to api.c")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
next prev parent reply other threads:[~2022-11-21 12:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 7:41 linux-next: build warnings after merge of the tip tree Stephen Rothwell
2022-11-21 10:12 ` [PATCH] PCI/MSI: api: Use bullet lists in kernel-doc comments Bagas Sanjaya
2022-11-21 12:34 ` Bjorn Helgaas [this message]
2022-11-22 3:44 ` Bagas Sanjaya
2022-11-21 13:27 ` Ahmed S. Darwish
2022-11-22 3:43 ` Bagas Sanjaya
2022-11-22 5:56 ` Ahmed S. Darwish
2022-11-22 8:11 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121123402.GA100653@bhelgaas \
--to=helgaas@kernel.org \
--cc=bagasdotme@gmail.com \
--cc=bhelgaas@google.com \
--cc=darwi@linutronix.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).