From: Greg KH <gregkh@linuxfoundation.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
luiz.dentz@gmail.com, johan@kernel.org, arnd@arndb.de,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
tomi.valkeinen@ideasonboard.com,
"Tony Lindgren" <tony@atomide.com>,
"Péter Ujfalusi" <peter.ujfalusi@gmail.com>,
robh@kernel.org
Subject: Re: [RFC PATCH 3/3] drivers: misc: ti-st: begin to deorbit
Date: Mon, 27 Nov 2023 08:25:46 +0000 [thread overview]
Message-ID: <2023112729-qualify-relearn-6a72@gregkh> (raw)
In-Reply-To: <20231126191840.110564-4-andreas@kemnade.info>
On Sun, Nov 26, 2023 at 08:18:40PM +0100, Andreas Kemnade wrote:
> The TI-ST driver seems not to be used anymore. For bluetooth needs
> there is hci_ll.c which has device tree support and can work without
> this one. Also firmware download support is there, so it is also not needed
> here. GPS can also reuse parts of the framework in hci_ll
>
> Contrary from this driver, device tree support has been removed.
>
> So start deorbiting it by marking it as broken.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> drivers/misc/ti-st/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig
> index 1503a6496f632..6bf9cc845745c 100644
> --- a/drivers/misc/ti-st/Kconfig
> +++ b/drivers/misc/ti-st/Kconfig
> @@ -7,7 +7,7 @@ menu "Texas Instruments shared transport line discipline"
> config TI_ST
> tristate "Shared transport core driver"
> depends on NET && TTY
> - depends on GPIOLIB || COMPILE_TEST
> + depends on GPIOLIB || COMPILE_TEST || BROKEN
Why not just delete it? Why have it stick around any longer?
thanks,
greg k-h
next prev parent reply other threads:[~2023-11-27 8:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 19:18 [RFC PATCH 0/3] bluetooth/gnss: GNSS support for TiWi chips Andreas Kemnade
2023-11-26 19:18 ` [RFC PATCH 1/3] gnss: Add AI2 protocol used by some TI combo chips Andreas Kemnade
2023-11-26 19:18 ` [RFC PATCH 2/3] bluetooth: ti-st: add GNSS support for TI Wilink chips Andreas Kemnade
2023-11-26 19:18 ` [RFC PATCH 3/3] drivers: misc: ti-st: begin to deorbit Andreas Kemnade
2023-11-27 8:25 ` Greg KH [this message]
2023-11-27 13:50 ` Tony Lindgren
2023-12-10 21:50 ` Andreas Kemnade
2023-11-27 13:54 ` [RFC PATCH 0/3] bluetooth/gnss: GNSS support for TiWi chips Tony Lindgren
2023-11-27 20:51 ` Andreas Kemnade
2023-12-08 14:39 ` Adam Ford
2023-12-08 17:47 ` Andreas Kemnade
2023-12-08 16:25 ` Johan Hovold
2023-12-08 22:13 ` Andreas Kemnade
2023-11-27 14:03 ` Adam Ford
2023-11-27 19:51 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023112729-qualify-relearn-6a72@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andreas@kemnade.info \
--cc=arnd@arndb.de \
--cc=johan.hedberg@gmail.com \
--cc=johan@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=peter.ujfalusi@gmail.com \
--cc=robh@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).