From: Daniel Scally <djrscally@gmail.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
devel@acpica.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Yong Zhi <yong.zhi@intel.com>, Bingbu Cao <bingbu.cao@intel.com>,
Tian Shu Qiu <tian.shu.qiu@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Moore <robert.moore@intel.com>,
Erik Kaneda <erik.kaneda@intel.com>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
kieran.bingham+renesas@ideasonboard.com,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Marco Felsch <m.felsch@pengutronix.de>,
niklas.soderlund+renesas@ragnatech.se,
Steve Longerbeam <slongerbeam@gmail.com>,
"Krogerus, Heikki" <heikki.krogerus@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Jordan Hand <jorhand@linux.microsoft.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver
Date: Mon, 28 Dec 2020 22:37:38 +0000 [thread overview]
Message-ID: <2d37df3d-f04c-6679-6e27-6c7f82e9b158@gmail.com> (raw)
In-Reply-To: <20201228170521.GZ26370@paasikivi.fi.intel.com>
Hi Sakari, thanks for comments
On 28/12/2020 17:05, Sakari Ailus wrote:
> Hi Andy, Daniel,
>
> On Thu, Dec 24, 2020 at 02:54:44PM +0200, Andy Shevchenko wrote:
>>> +static void cio2_bridge_init_swnode_names(struct cio2_sensor *sensor)
>>> +{
>>> + snprintf(sensor->node_names.remote_port, sizeof(sensor->node_names.remote_port),
>>> + FWNODE_GRAPH_PORT_NAME_FORMAT, sensor->ssdb.link);
>>> + snprintf(sensor->node_names.port, sizeof(sensor->node_names.port),
>>> + FWNODE_GRAPH_PORT_NAME_FORMAT, 0); /* Always port 0 */
>>> + snprintf(sensor->node_names.endpoint, sizeof(sensor->node_names.endpoint),
>>> + FWNODE_GRAPH_ENDPOINT_NAME_FORMAT, 0); /* And endpoint 0 */
>
> Please wrap before 80, there's no need here to do otherwise. You could
> argue about cio2_bridge_create_fwnode_properties() though. I might just
> wrap that, too.
>
> Applies to the rest of the patch.
I shall wrap such cases then - I thought I read somewhere that the
wrapped line needed to be shorter than the parent which is why I wrapped
after 80...but I can't find the reference now so possibly I imagined that.
>>> +static int cio2_bridge_connect_sensors(struct cio2_bridge *bridge,
>>> + struct pci_dev *cio2)
>>> +{
>>> + struct fwnode_handle *fwnode;
>>> + struct cio2_sensor *sensor;
>>> + struct acpi_device *adev;
>>> + unsigned int i;
>>> + int ret = 0;
>>
>> You may drop this assignment and...
>>
>>> + for (i = 0; i < ARRAY_SIZE(cio2_supported_sensors); i++) {
>>> + const struct cio2_sensor_config *cfg = &cio2_supported_sensors[i];
>
> You could move the inner loop into a new function called e.g.
> cio2_bridge_connect_sensor.
Yeah good idea, I'll do that.
>>> diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.h b/drivers/media/pci/intel/ipu3/cio2-bridge.h
>>> new file mode 100644
>>> index 000000000000..004b608f322f
>>> --- /dev/null
>>> +++ b/drivers/media/pci/intel/ipu3/cio2-bridge.h
>>> @@ -0,0 +1,122 @@
>>> +/* SPDX-License-Identifier: GPL-2.0 */
>>> +/* Author: Dan Scally <djrscally@gmail.com> */
>>> +#ifndef __CIO2_BRIDGE_H
>>> +#define __CIO2_BRIDGE_H
>>> +
>>> +#include <linux/property.h>
>>> +
>>> +#define CIO2_HID "INT343E"
>>> +#define CIO2_NUM_PORTS 4
>
> This is already defined in ipu3-cio2.h. Could you include that instead?
Yes; but I'd need to also include media/v4l2-device.h and
media/videobuf2-dma-sg.h (they're included in ipu3-cio2-main.c at the
moment). It didn't seem worth it; but I can move those two includes from
the .c to the .h and then include ipu3-cio2.h in cio2-bridge.h
Which do you prefer?
>>> +#define MAX_NUM_LINK_FREQS 3
>>> +
>>> +#define CIO2_SENSOR_CONFIG(_HID, _NR, ...) \
>>> + { \
>>> + .hid = _HID, \
>>> + .nr_link_freqs = _NR, \
>>> + .link_freqs = { __VA_ARGS__ } \
>>> + }
>>> +
>>> +#define NODE_SENSOR(_HID, _PROPS) \
>>> + ((const struct software_node) { \
>>> + .name = _HID, \
>>> + .properties = _PROPS, \
>>> + })
>>> +
>>> +#define NODE_PORT(_PORT, _SENSOR_NODE) \
>>> + ((const struct software_node) { \
>>> + _PORT, \
>>> + _SENSOR_NODE, \
>
> Could you use explicit assignments to fields here, please?
>
>>> + })
>>> +
>>> +#define NODE_ENDPOINT(_EP, _PORT, _PROPS) \
>>> + ((const struct software_node) { \
>>> + _EP, \
>>> + _PORT, \
>>> + _PROPS, \
>
> Ditto.
>
Will do
next prev parent reply other threads:[~2020-12-28 22:58 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 1:08 [PATCH v3 00/14] Add functionality to ipu3-cio2 driver allowing software_node connections to sensors on platforms designed for Windows Daniel Scally
2020-12-24 1:08 ` [PATCH v3 01/14] software_node: Fix refcounts in software_node_get_next_child() Daniel Scally
2020-12-24 1:08 ` [PATCH v3 02/14] property: Return true in fwnode_device_is_available for NULL ops Daniel Scally
2020-12-24 1:08 ` [PATCH v3 03/14] property: Call fwnode_graph_get_endpoint_by_id() for fwnode->secondary Daniel Scally
2020-12-24 1:08 ` [PATCH v3 04/14] software_node: Enforce parent before child ordering of nodes arrays Daniel Scally
2020-12-24 1:08 ` [PATCH v3 05/14] software_node: unregister software_nodes in reverse order Daniel Scally
2020-12-24 12:13 ` Andy Shevchenko
2020-12-24 14:00 ` Daniel Scally
2020-12-24 14:12 ` Andy Shevchenko
2020-12-24 14:14 ` Daniel Scally
2020-12-24 18:36 ` David Laight
2020-12-28 10:15 ` Andy Shevchenko
2020-12-28 21:17 ` Daniel Scally
2020-12-28 16:34 ` Sakari Ailus
2020-12-28 17:47 ` Andy Shevchenko
2020-12-24 1:08 ` [PATCH v3 06/14] include: fwnode.h: Define format macros for ports and endpoints Daniel Scally
2020-12-24 12:17 ` Andy Shevchenko
2020-12-24 12:41 ` Laurent Pinchart
2020-12-28 16:30 ` Sakari Ailus
2020-12-28 17:11 ` Sakari Ailus
2020-12-28 21:36 ` Daniel Scally
2020-12-24 1:09 ` [PATCH v3 07/14] software_node: Add support for fwnode_graph*() family of functions Daniel Scally
2020-12-24 12:24 ` Andy Shevchenko
2020-12-24 12:55 ` Laurent Pinchart
2020-12-24 13:03 ` Andy Shevchenko
2020-12-24 14:21 ` Daniel Scally
2020-12-28 16:41 ` Sakari Ailus
2020-12-28 21:37 ` Daniel Scally
2020-12-26 23:47 ` Daniel Scally
2020-12-24 12:53 ` Laurent Pinchart
2020-12-24 14:24 ` Daniel Scally
2020-12-24 1:09 ` [PATCH v3 08/14] lib/test_printf.c: Use helper function to unwind array of software_nodes Daniel Scally
2020-12-24 1:09 ` [PATCH v3 09/14] ipu3-cio2: Add T: entry to MAINTAINERS Daniel Scally
2020-12-24 1:09 ` [PATCH v3 10/14] ipu3-cio2: Rename ipu3-cio2.c Daniel Scally
2020-12-24 1:09 ` [PATCH v3 11/14] media: v4l2-core: v4l2-async: Check sd->fwnode->secondary in match_fwnode() Daniel Scally
2020-12-24 1:09 ` [PATCH v3 12/14] acpi: Add acpi_dev_get_next_match_dev() and helper macro Daniel Scally
2020-12-24 1:09 ` [PATCH v3 13/14] include: media: v4l2-fwnode: Include v4l2_fwnode_bus_type Daniel Scally
2020-12-24 12:32 ` Andy Shevchenko
2020-12-26 23:14 ` Daniel Scally
2020-12-24 12:58 ` Laurent Pinchart
2020-12-24 1:09 ` [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver Daniel Scally
2020-12-24 12:54 ` Andy Shevchenko
2020-12-26 23:23 ` Daniel Scally
2020-12-28 17:05 ` Sakari Ailus
2020-12-28 22:37 ` Daniel Scally [this message]
2020-12-28 22:55 ` Andy Shevchenko
2020-12-28 22:56 ` Andy Shevchenko
2020-12-28 23:07 ` Laurent Pinchart
2020-12-28 23:54 ` Andy Shevchenko
2020-12-29 0:07 ` Laurent Pinchart
2020-12-30 20:47 ` Andy Shevchenko
2020-12-28 23:30 ` Daniel Scally
2020-12-28 23:47 ` Andy Shevchenko
2021-01-02 17:07 ` Sakari Ailus
2021-01-02 17:12 ` Daniel Scally
2021-01-02 17:21 ` Sakari Ailus
2021-01-02 17:24 ` Sakari Ailus
2021-01-02 21:23 ` Daniel Scally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d37df3d-f04c-6679-6e27-6c7f82e9b158@gmail.com \
--to=djrscally@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bingbu.cao@intel.com \
--cc=devel@acpica.org \
--cc=erik.kaneda@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo+renesas@jmondi.org \
--cc=jorhand@linux.microsoft.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=m.felsch@pengutronix.de \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pmladek@suse.com \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=rostedt@goodmis.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=slongerbeam@gmail.com \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).