From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Jeff Garzik <jeff@garzik.org>,
jesse.brandeburg@intel.com, john.ronciak@intel.com,
e1000-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [RFC: 2.6 patch] #if 0 e1000e_read_nvm_spi()
Date: Mon, 03 Mar 2008 09:24:35 -0800 [thread overview]
Message-ID: <47CC3453.9010108@intel.com> (raw)
In-Reply-To: <20080301162302.GX25835@cs181133002.pp.htv.fi>
Adrian Bunk wrote:
> This patch #if 0's the no longer used e1000e_read_nvm_spi().
OK, thanks Adrian
I'll send a patch to remove the function alltogether.
Auke
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> drivers/net/e1000e/e1000.h | 1 -
> drivers/net/e1000e/lib.c | 2 ++
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> 9bab4dc421a7e5a947739e2fa1363b4efffbcbe2 foobar
> diff --git a/drivers/net/e1000e/e1000.h b/drivers/net/e1000e/e1000.h
> index 327c062..6e0c6ed 100644
> --- a/drivers/net/e1000e/e1000.h
> +++ b/drivers/net/e1000e/e1000.h
> @@ -462,7 +462,6 @@ extern s32 e1000e_acquire_nvm(struct e1000_hw *hw);
> extern s32 e1000e_write_nvm_spi(struct e1000_hw *hw, u16 offset, u16 words, u16 *data);
> extern s32 e1000e_update_nvm_checksum_generic(struct e1000_hw *hw);
> extern s32 e1000e_poll_eerd_eewr_done(struct e1000_hw *hw, int ee_reg);
> -extern s32 e1000e_read_nvm_spi(struct e1000_hw *hw, u16 offset, u16 words, u16 *data);
> extern s32 e1000e_read_nvm_eerd(struct e1000_hw *hw, u16 offset, u16 words, u16 *data);
> extern s32 e1000e_validate_nvm_checksum_generic(struct e1000_hw *hw);
> extern void e1000e_release_nvm(struct e1000_hw *hw);
> diff --git a/drivers/net/e1000e/lib.c b/drivers/net/e1000e/lib.c
> index 95f75a4..cb2dac8 100644
> --- a/drivers/net/e1000e/lib.c
> +++ b/drivers/net/e1000e/lib.c
> @@ -1851,6 +1851,7 @@ static s32 e1000_ready_nvm_eeprom(struct e1000_hw *hw)
> return 0;
> }
>
> +#if 0
> /**
> * e1000e_read_nvm_spi - Reads EEPROM using SPI
> * @hw: pointer to the HW structure
> @@ -1906,6 +1907,7 @@ s32 e1000e_read_nvm_spi(struct e1000_hw *hw, u16 offset, u16 words, u16 *data)
> nvm->ops.release_nvm(hw);
> return 0;
> }
> +#endif /* 0 */
>
> /**
> * e1000e_read_nvm_eerd - Reads EEPROM using EERD register
>
prev parent reply other threads:[~2008-03-03 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-01 16:23 [RFC: 2.6 patch] #if 0 e1000e_read_nvm_spi() Adrian Bunk
2008-03-03 17:24 ` Kok, Auke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47CC3453.9010108@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=bunk@kernel.org \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).