From: Matthias Brugger <matthias.bgg@gmail.com>
To: Frank Wunderlich <linux@fw-web.de>, linux-mediatek@lists.infradead.org
Cc: Frank Wunderlich <frank-w@public-files.de>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel@ffwll.ch>,
linux-arm-kernel@lists.infradead.org,
Jitao Shi <jitao.shi@mediatek.com>
Subject: Re: [PATCH v5 5/7] drm/mediatek: dpi/dsi: change the getting possible_crtc way
Date: Wed, 19 Aug 2020 19:14:20 +0200 [thread overview]
Message-ID: <4812f750-5f85-61bb-fb68-4eec99285e77@gmail.com> (raw)
In-Reply-To: <20200819081752.4805-6-linux@fw-web.de>
On 19/08/2020 10:17, Frank Wunderlich wrote:
> From: Jitao Shi <jitao.shi@mediatek.com>
>
> For current mediatek dsi encoder, its possible crtc is fixed in crtc
> 0, and mediatek dpi encoder's possible crtc is fixed in crtc 1. In
> some SoC the possible crtc is not fixed in this case, so call
> mtk_drm_find_possible_crtc_by_comp() to find out the correct possible
> crtc.
>
Hm, shouldn't we stash this int 4/7, otherwise we will have not used functions
in 4/7.
Regards,
Matthias
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 3 ++-
> drivers/gpu/drm/mediatek/mtk_dsi.c | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index d4f0fb7ad312..e43977015843 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -608,7 +608,8 @@ static int mtk_dpi_bind(struct device *dev, struct device *master, void *data)
> drm_encoder_helper_add(&dpi->encoder, &mtk_dpi_encoder_helper_funcs);
>
> /* Currently DPI0 is fixed to be driven by OVL1 */
> - dpi->encoder.possible_crtcs = BIT(1);
> + dpi->encoder.possible_crtcs =
> + mtk_drm_find_possible_crtc_by_comp(drm_dev, dpi->ddp_comp);
>
> ret = drm_bridge_attach(&dpi->encoder, dpi->bridge, NULL, 0);
> if (ret) {
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 16fd99dcdacf..c9f4ad029cb1 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -974,7 +974,8 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi)
> * Currently display data paths are statically assigned to a crtc each.
> * crtc 0 is OVL0 -> COLOR0 -> AAL -> OD -> RDMA0 -> UFOE -> DSI0
> */
> - dsi->encoder.possible_crtcs = 1;
> + dsi->encoder.possible_crtcs =
> + mtk_drm_find_possible_crtc_by_comp(drm, dsi->ddp_comp);
>
> ret = drm_bridge_attach(&dsi->encoder, &dsi->bridge, NULL,
> DRM_BRIDGE_ATTACH_NO_CONNECTOR);
>
next prev parent reply other threads:[~2020-08-19 17:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 8:17 [PATCH v5 0/7] make hdmi work on bananapi-r2 Frank Wunderlich
2020-08-19 8:17 ` [PATCH v5 1/7] dt-bindings: mediatek: add mt7623 display-nodes Frank Wunderlich
2020-08-27 23:31 ` Chun-Kuang Hu
2020-08-19 8:17 ` [PATCH v5 2/7] drm/mediatek: add ddp routing for mt7623 Frank Wunderlich
2020-08-27 23:32 ` Chun-Kuang Hu
2020-08-19 8:17 ` [PATCH v5 3/7] drm/mediatek: disable tmds on mt2701 Frank Wunderlich
2020-08-19 17:12 ` Matthias Brugger
2020-08-19 19:04 ` Frank Wunderlich
2020-08-21 11:13 ` Aw: " Frank Wunderlich
2020-08-21 7:17 ` Aw: " Frank Wunderlich
2020-08-27 8:15 ` Matthias Brugger
2020-08-27 13:41 ` Aw: " Frank Wunderlich
2020-08-27 14:28 ` Matthias Brugger
2020-08-27 23:46 ` Chun-Kuang Hu
2020-08-28 5:21 ` Frank Wunderlich
2020-08-28 17:45 ` Matthias Brugger
2020-08-19 8:17 ` [PATCH v5 4/7] drm/mediatek: Add get_possible_crtc API for dpi, dsi Frank Wunderlich
2020-08-19 8:17 ` [PATCH v5 5/7] drm/mediatek: dpi/dsi: change the getting possible_crtc way Frank Wunderlich
2020-08-19 17:14 ` Matthias Brugger [this message]
2020-08-27 23:34 ` Chun-Kuang Hu
2020-08-19 8:17 ` [PATCH v5 6/7] arm: dts: mt7623: move display nodes to separate mt7623n.dtsi Frank Wunderlich
2020-09-09 9:29 ` Matthias Brugger
2020-09-09 9:35 ` Matthias Brugger
2020-08-19 8:17 ` [PATCH v5 7/7] arm: dts: mt7623: add display subsystem related device nodes Frank Wunderlich
2020-09-09 9:29 ` Matthias Brugger
2020-08-26 15:52 ` [PATCH v5 0/7] make hdmi work on bananapi-r2 Frank Wunderlich
2020-09-03 15:07 ` Frank Wunderlich
2020-09-03 22:54 ` Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4812f750-5f85-61bb-fb68-4eec99285e77@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank-w@public-files.de \
--cc=jitao.shi@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).