From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF5FCC433EF for ; Tue, 28 Sep 2021 12:42:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B704B60F35 for ; Tue, 28 Sep 2021 12:42:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240694AbhI1Mn6 (ORCPT ); Tue, 28 Sep 2021 08:43:58 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:57145 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240637AbhI1Mn4 (ORCPT ); Tue, 28 Sep 2021 08:43:56 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632832936; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=bfvExRyMFxw1e6AjAzU9jgJ8KWmezb7Nm5djdW68m8w=; b=InuM9IgItyRu7SUc3pOQURipWguInyyKsCMsOnMHYhASXsALjdEUDSEyH6aSxi6UU22mO6py nC6IXMpdyzi+ICgJpy28/SpszH1GAEDuRFUq2DZZecDbBCeTZiS421P3GHcfXzgCSdbngryQ 9PXTulM7QAP3ykeheL8jsnYq8zE= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 61530da61abbf21d34cb3acf (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 28 Sep 2021 12:42:14 GMT Sender: skakit=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 13BE9C4360D; Tue, 28 Sep 2021 12:42:14 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: skakit) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6EF74C4338F; Tue, 28 Sep 2021 12:42:13 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 28 Sep 2021 18:12:13 +0530 From: skakit@codeaurora.org To: Stephen Boyd Cc: Andy Gross , Bjorn Andersson , Rob Herring , Lee Jones , Liam Girdwood , Mark Brown , mka@chromium.org, Das Srinagesh , David Collins , kgunda@codeaurora.org, Subbaraman Narayanamurthy , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] arm64: dts: qcom: sc7280: Add pm8008 regulators support for sc7280-idp In-Reply-To: References: <1631875538-22473-1-git-send-email-skakit@codeaurora.org> <1631875538-22473-5-git-send-email-skakit@codeaurora.org> Message-ID: <61eabd793256583c930c487b9a21c60b@codeaurora.org> X-Sender: skakit@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-09-21 01:07, Stephen Boyd wrote: > Quoting Satya Priya (2021-09-17 03:45:38) >> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi >> b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi >> index 52638e2..3b3af49 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi >> @@ -207,6 +207,97 @@ >> }; >> }; >> >> +&i2c1 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + status = "okay"; >> + >> + pm8008_chip: pm8008@8 { >> + compatible = "qcom,pm8008"; >> + reg = <0x8>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pm8008_active>; >> + }; >> + >> + pm8008_ldo: pm8008@9 { > [...] >> + >> + pm8008_l7: regulator@4600 { >> + reg = <0x4600>; >> + regulator-name = "pm8008_l7"; >> + regulator-min-microvolt = <3000000>; >> + regulator-max-microvolt = <3544000>; >> + qcom,min-dropout-voltage = <96000>; > > Is this headroom? Is it actually configurable or is it merely a > property > of the hardware? If it's the latter then it should be in the driver and > not in the DTS. > Yes this is a headroom and its configurable. >> + }; >> + }; >> + }; >> +}; >> + >> &qfprom { >> vcc-supply = <&vreg_l1c_1p8>; >> }; >> @@ -313,6 +404,18 @@ >> >> /* PINCTRL - additions to nodes defined in sc7280.dtsi */ >> >> +&pm8350c_gpios { >> + pm8008_reset { > > Is this a pinctrl node? > No. >> + pm8008_active: pm8008_active { > > Please use dashes in node names wherever an underscore goes. > Okay. >> + pins = "gpio4"; >> + function = "normal"; >> + bias-disable; >> + output-high; >> + power-source = <0>; >> + }; >> + }; >> +};