From: Jens Axboe <firstname.lastname@example.org>
To: "Ahmed S. Darwish" <email@example.com>
Cc: Keith Busch <firstname.lastname@example.org>,
email@example.com, Sagi Grimberg <firstname.lastname@example.org>,
Chaitanya Kulkarni <email@example.com>,
Subject: Re: v5.9-rc1 commit reliably breaks pci nvme detection
Date: Thu, 20 Aug 2020 11:10:58 -0600 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
On 8/20/20 11:07 AM, Ahmed S. Darwish wrote:
> On Thu, Aug 20, 2020 at 09:35:38AM -0600, Jens Axboe wrote:
>> On 8/17/20 9:58 AM, Jens Axboe wrote:
>>> On 8/17/20 8:56 AM, Keith Busch wrote:
>>>> On Mon, Aug 17, 2020 at 03:50:11PM +0200, Ahmed S. Darwish wrote:
>>>>> Below v5.9-rc1 commit reliably breaks my boot on a Thinkpad e480
>>>>> laptop. PCI nvme detection fails, and the kernel becomes not able
>>>>> anymore to find the rootfs / parse "root=".
>>>>> Bisecting v5.8=>v5.9-rc1 blames that commit. Reverting it *reliably*
>>>>> fixes the problem and makes me able to boot v5.9-rc1.
>>>> The fix is staged in the nvme tree here:
>>> That would have been nice to have in -rc1...
>> And now we're getting very close to shipping items for -rc2, and it's still
>> not in. Can we please get the nvme pull request out for -rc2?
> I keep wondering that myself. Completely breaking the boot like this is
> really not nice -- and for x86-64 laptops no less :-(
To be fair, I've only heard this one complaint about it, so hopefully it's
not too widespread. I'm on an x86-64 laptop myself with nvme, and it works
just fine :-)
> The fix is really small and isolated. "Urgent pull requests", containing
> only a fix or two, were created *exactly* for this reson...
Totally agree on that, it should have gone in for -rc1. This will be going
upstream tomorrow, so the end is near...
next prev parent reply other threads:[~2020-08-20 17:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 13:50 v5.9-rc1 commit reliably breaks pci nvme detection Ahmed S. Darwish
2020-08-17 15:56 ` Keith Busch
2020-08-17 15:58 ` Jens Axboe
2020-08-20 15:35 ` Jens Axboe
2020-08-20 17:07 ` Ahmed S. Darwish
2020-08-20 17:10 ` Jens Axboe [this message]
2020-08-20 17:12 ` Christoph Hellwig
2020-08-20 17:14 ` Jens Axboe
2020-08-21 7:28 ` John Garry
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).