From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FF51C433F5 for ; Tue, 21 Sep 2021 01:41:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C3FB61175 for ; Tue, 21 Sep 2021 01:41:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229640AbhIUBmz (ORCPT ); Mon, 20 Sep 2021 21:42:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232374AbhIUBja (ORCPT ); Mon, 20 Sep 2021 21:39:30 -0400 Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD678C0430D3 for ; Mon, 20 Sep 2021 12:53:42 -0700 (PDT) Received: by mail-oi1-x235.google.com with SMTP id 24so5262902oix.0 for ; Mon, 20 Sep 2021 12:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=1DxHtYBh4DzHUQ01KgUFLlooV5ZfuLGGb9gtdlSK5T8=; b=oVUzKPQf3Dx+Ish9YbiDA6rmx4JK8gznqZ15XRqd1dK66S42rpOkuLnHCip24bG6tN Kb6ll0czgwMocjwN/yauCrFg3hlkqytUJdDVSc2+K7mFNXl4WjdfUAW4gKt9ZqFbvQRO YfV+Ey0wR+Ut7axwjG/USkB+P5lf6NBtOqqEA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=1DxHtYBh4DzHUQ01KgUFLlooV5ZfuLGGb9gtdlSK5T8=; b=ol1Su+8lF/vkq3owxGuo7KsL6QRvQODm57ohIax9KB/N6ejQAzCspa24Pl2eAB++cI yA4M0RsW0OlI9tCPQr3aih7cnjgDimM/fyZjk249n563sbM3k1YFdh6DkL7QFEnqZXA1 Rj8PwBMbfp1hK7oTcx7a/nCWU7pNJXU+4OCnSxh1iITyQlUvFMUAlRgzuE5CzP7U+ipH B2lvhgL2MDHRkVNixMc+3AoBzhF61vzZTmTdi1jkSsEYCH9GhVSblCV+bWXqwt6DUnnP eAbNsOWzdm9ElI9hprCqFJtsk/x2/xhzNXjcFIaR43acXrs8KJJ9JQtCWxOj7FVrqNwz VqhA== X-Gm-Message-State: AOAM5313URE/lYQ/iy5wCN/6U72MmpQdISXyh9Q0uxkVS6Vn/yRVJMDi 2jNM2GP6u7hRPZnzIQ8ibzCWQQZYC0vg1lLMydttmw== X-Google-Smtp-Source: ABdhPJzJSN3Q2nCHPr+PzZnQ71Bc+cOTt8uQg6u8yZOdsf4zxwJFblSLVn5oUvAQ1oeCgPIlgC/6LUu0BqWU3Rk4sjI= X-Received: by 2002:aca:1a11:: with SMTP id a17mr639799oia.164.1632167622190; Mon, 20 Sep 2021 12:53:42 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 20 Sep 2021 12:53:41 -0700 MIME-Version: 1.0 In-Reply-To: <1631898947-27433-5-git-send-email-pmaliset@codeaurora.org> References: <1631898947-27433-1-git-send-email-pmaliset@codeaurora.org> <1631898947-27433-5-git-send-email-pmaliset@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Mon, 20 Sep 2021 12:53:41 -0700 Message-ID: Subject: Re: [PATCH v8 4/4] PCI: qcom: Switch pcie_1_pipe_clk_src after PHY init in SC7280 To: Prasad Malisetty , agross@kernel.org, bhelgaas@google.com, bjorn.andersson@linaro.org, lorenzo.pieralisi@arm.com, robh+dt@kernel.org, svarbanov@mm-sol.com Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, mka@chromium.org, vbadigan@codeaurora.org, sallenki@codeaurora.org, manivannan.sadhasivam@linaro.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Prasad Malisetty (2021-09-17 10:15:47) > On the SC7280, the clock source for gcc_pcie_1_pipe_clk_src > must be the TCXO while gdsc is enabled. After PHY init successful > clock source should switch to pipe clock for gcc_pcie_1_pipe_clk_src. > > Signed-off-by: Prasad Malisetty > --- One nit below Reviewed-by: Stephen Boyd > @@ -1488,7 +1553,9 @@ static int qcom_pcie_probe(struct platform_device *pdev) > > pcie->pci = pci; > > - pcie->ops = of_device_get_match_data(dev); > + pcie_cfg = of_device_get_match_data(dev); > + pcie->ops = pcie_cfg->ops; Maybe worth failing probe with if (!pcie->ops) just to be a little nicer here. > + pcie->pipe_clk_need_muxing = pcie_cfg->pipe_clk_need_muxing; > > pcie->reset = devm_gpiod_get_optional(dev, "perst", GPIOD_OUT_HIGH); > if (IS_ERR(pcie->reset)) {