From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69096C433EF for ; Fri, 6 May 2022 11:04:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391099AbiEFLIE (ORCPT ); Fri, 6 May 2022 07:08:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233719AbiEFLIA (ORCPT ); Fri, 6 May 2022 07:08:00 -0400 Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AECB366F9C for ; Fri, 6 May 2022 04:04:17 -0700 (PDT) Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-2ef5380669cso77053147b3.9 for ; Fri, 06 May 2022 04:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=4tHVHA8aVbeVaFoDlPql88Q/9NJ6rAQwn4GhNFwxTwM=; b=Y9CFhcWaUhjrECjyuSeOchnKMM/ukpyTQez4VqVCH4TtE9eAnEld+/aUwLzu6PDSaT ITUMkpj0Pq0svMYhThzFdRj8XblDNogk1iUv15ZpiS6X4YsqXQb101vDE7JxA4TT7Rdi 3cQH5mDUrSBM6buak1ZnZKR89mpRc9JsOJAeY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4tHVHA8aVbeVaFoDlPql88Q/9NJ6rAQwn4GhNFwxTwM=; b=0X/bnlXSkfRnc4Ahkmv4MMNnvMI8f+3ZJQiMmUAbDxteGnxfMc4yfbDs7TZoIPP0ka 8K+0kPjpXQDC1DtcOGl9D9jQV7Q1MlY0SH6XkEyqXIDtYHaeWmRfC1FlpUTdvBAyHXOT IyWVPTPDB8TDu0sR7pnseci6qcGJI9xVUq6aBYMokdvH/dvU/bDqT6ZbETwQ60uLNJw3 61rRIW4afKsEe2KkP/cgvuGU50dHCcpYxc5Hp6BYhTcTickD3JtvUp/MB3U6s22JT6Ro EdsFAbV3T/ravLRtB2SkRMNSfdzWH3ReSZPl02Lq+gr8cx6dTgB5eUUxvEdXRgTzCA7l jWjg== X-Gm-Message-State: AOAM532o1H0bpQZZ0aBGoh72ylb/qpjM95JOY/+SNj8gyuYma8plWVLM 7HJa4gYZZFFvf+pXyqHgXxakpXpHXFVeH/w89Ws8Ew== X-Google-Smtp-Source: ABdhPJzrxlYT0o+pbPyAyvmWw1o6bUmiDPRnLGsburai31NprtPoykzH2hgAePXKTKi3HgMgQsIV/TZZ2+XmP9IUnSc= X-Received: by 2002:a81:998a:0:b0:2f9:5d24:e362 with SMTP id q132-20020a81998a000000b002f95d24e362mr2181373ywg.161.1651835056969; Fri, 06 May 2022 04:04:16 -0700 (PDT) MIME-Version: 1.0 References: <20220505194550.3094656-1-nfraprado@collabora.com> <20220505194550.3094656-9-nfraprado@collabora.com> In-Reply-To: <20220505194550.3094656-9-nfraprado@collabora.com> From: Chen-Yu Tsai Date: Fri, 6 May 2022 19:04:06 +0800 Message-ID: Subject: Re: [PATCH v2 08/16] arm64: dts: mediatek: asurada: Add keyboard mapping for the top row To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Cc: Matthias Brugger , AngeloGioacchino Del Regno , kernel@collabora.com, Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, May 6, 2022 at 3:46 AM N=C3=ADcolas F. R. A. Prado wrote: > > Chromebooks' embedded keyboards differ from standard layouts for the > top row in that they have shortcuts in place of the standard function > keys. Map these keys to achieve the functionality that is pictured on > the printouts. > > Signed-off-by: N=C3=ADcolas F. R. A. Prado > Reviewed-by: AngeloGioacchino Del Regno > --- > > (no changes since v1) > > .../boot/dts/mediatek/mt8192-asurada.dtsi | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi b/arch/arm6= 4/boot/dts/mediatek/mt8192-asurada.dtsi > index 662207d0eb75..a1cbf7a375b6 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > @@ -525,3 +525,32 @@ &uart0 { > > #include > #include > + > +&keyboard_controller { > + function-row-physmap =3D < > + MATRIX_KEY(0x00, 0x02, 0) /* T1 */ > + MATRIX_KEY(0x03, 0x02, 0) /* T2 */ > + MATRIX_KEY(0x02, 0x02, 0) /* T3 */ > + MATRIX_KEY(0x01, 0x02, 0) /* T4 */ > + MATRIX_KEY(0x03, 0x04, 0) /* T5 */ > + MATRIX_KEY(0x02, 0x04, 0) /* T6 */ > + MATRIX_KEY(0x01, 0x04, 0) /* T7 */ > + MATRIX_KEY(0x02, 0x09, 0) /* T8 */ > + MATRIX_KEY(0x01, 0x09, 0) /* T9 */ > + MATRIX_KEY(0x00, 0x04, 0) /* T10 */ > + >; > + linux,keymap =3D < > + MATRIX_KEY(0x00, 0x02, KEY_BACK) > + MATRIX_KEY(0x03, 0x02, KEY_REFRESH) > + MATRIX_KEY(0x02, 0x02, KEY_ZOOM) > + MATRIX_KEY(0x01, 0x02, KEY_SCALE) > + MATRIX_KEY(0x03, 0x04, KEY_SYSRQ) > + MATRIX_KEY(0x02, 0x04, KEY_BRIGHTNESSDOWN) > + MATRIX_KEY(0x01, 0x04, KEY_BRIGHTNESSUP) > + MATRIX_KEY(0x02, 0x09, KEY_MUTE) > + MATRIX_KEY(0x01, 0x09, KEY_VOLUMEDOWN) > + MATRIX_KEY(0x00, 0x04, KEY_VOLUMEUP) There's a slight nuance here, the keyboards for Hayato and Spherion are not the same one. Hayato follows the keyboard design of older Chromebooks, such as Kevin: back, forward, refresh, zoom, scale, brightness up ... (the right side part is the same) Spherion's keyboard layout matches what you have above. Also, "zoom" should probably be full-screen, even though the two map to the same keycode. Regards ChenYu > + > + CROS_STD_MAIN_KEYMAP > + >; > +}; > -- > 2.36.0 >