From: Adam Ford <aford173@gmail.com>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: linux-clk <linux-clk@vger.kernel.org>,
Adam Ford-BE <aford@beaconembedded.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 1/2] dt-bindings: clk: versaclock5: Add load capacitance properties
Date: Fri, 8 Jan 2021 20:48:42 -0600 [thread overview]
Message-ID: <CAHCN7x+57x4WLbq0+7OCPhJs-1=7SJidVHD2jYjdbqn_F+d3dA@mail.gmail.com> (raw)
In-Reply-To: <833e228f-6fb5-ae98-a367-9566cf5fcf69@lucaceresoli.net>
On Fri, Jan 8, 2021 at 4:49 PM Luca Ceresoli <luca@lucaceresoli.net> wrote:
>
> Hi Adam,
>
> On 06/01/21 18:38, Adam Ford wrote:
> > There are two registers which can set the load capacitance for
> > XTAL1 and XTAL2. These are optional registers when using an
> > external crystal. Update the bindings to support them.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> > ---
> > .../devicetree/bindings/clock/idt,versaclock5.yaml | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> > index 2ac1131fd922..e5e55ffb266e 100644
> > --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> > +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> > @@ -59,6 +59,18 @@ properties:
> > minItems: 1
> > maxItems: 2
> >
> > + idt,xtal1-load-femtofarads:
>
> I wonder whether we should have a common, vendor independent property.
That would be nice.
> In mainline we have xtal-load-pf (ti,cdce925.txt bindings) which has no
> vendor prefix. However I don't know how much common it is to need
rtc-pcf85063.c uses quartz-load-femtofarads, so there is already some
discrepancy.
Since the unit of measure here is femtofarads, using pF in the name seems wrong.
We need to read the data as a u32, so femtofarads works better than
pF, which would require a decimal point.
> different loads for x1 and x2. Any hardware engineer around?
I talked to a hardware engineer where I work, and he said it makes
sense to keep them the same. I only separated them because there are
two registers, and I assumed there might be a reason to have X1 and X2
be different, but I'm ok with reading one value and writing it to two
different registers.
adam
>
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 9000
> > + maximum: 25000
> > + description: Optional loading capacitor for XTAL1
>
> Nit: I think the common wording is "load capacitor", not "loading
> capacitor".
>
> --
> Luca
next prev parent reply other threads:[~2021-01-09 2:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 17:38 [RFC 1/2] dt-bindings: clk: versaclock5: Add load capacitance properties Adam Ford
2021-01-06 17:39 ` [RFC 2/2] clk: vc5: Add support for optional load capacitance Adam Ford
2021-01-08 22:49 ` Luca Ceresoli
2021-01-09 3:00 ` Adam Ford
2021-01-09 18:02 ` Luca Ceresoli
2021-01-11 16:40 ` Adam Ford
2021-01-12 16:45 ` Luca Ceresoli
2021-01-12 17:00 ` Adam Ford
2021-01-13 14:12 ` Luca Ceresoli
2021-01-13 7:23 ` Stephen Boyd
2021-01-08 22:49 ` [RFC 1/2] dt-bindings: clk: versaclock5: Add load capacitance properties Luca Ceresoli
2021-01-09 2:48 ` Adam Ford [this message]
2021-01-13 14:39 ` Luca Ceresoli
2021-01-13 3:16 ` Rob Herring
2021-01-13 12:31 ` Adam Ford
2021-01-13 14:36 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHCN7x+57x4WLbq0+7OCPhJs-1=7SJidVHD2jYjdbqn_F+d3dA@mail.gmail.com' \
--to=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).