From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07B24C43381 for ; Tue, 12 Jan 2021 15:55:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1D082070E for ; Tue, 12 Jan 2021 15:55:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404572AbhALPzq (ORCPT ); Tue, 12 Jan 2021 10:55:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392072AbhALPzp (ORCPT ); Tue, 12 Jan 2021 10:55:45 -0500 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD09CC061575; Tue, 12 Jan 2021 07:55:05 -0800 (PST) Received: by mail-pg1-x529.google.com with SMTP id q7so1712115pgm.5; Tue, 12 Jan 2021 07:55:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cAG/VZYg1tbBVWV56Yza/FNpS4EtYQ911pPNLEyfbHs=; b=Ys1KzpZ+2UTQ9MULoo45Xeb2yGMin33tUSG8zraaH36nWyUwv4nhZfAbh3dQ9pBXSz rJa79m6ncPB8kZaHaNws7medrUAqpVMgX1IV2V8qkCTtzxs+geeHlrMf0wcY3QD6gkUt KD7u47jhGWw9uPdsJ8w/n/yz0ZZGV/1vXFmvwokvDTSgmTLo410s57X/3Qe2Z5jx1i3m lKkHq9HMd46wAQYciF72BEUH4tW6R0U2G6oYOg5dAVd/AESkKb0h71yZ3/34vynd6UxX JR15TiJOCkRp0ZXNJNqM78O/0GwSymOOSay/aZwTM1dmreGn1IaDvnEmo1t1LRgDacuZ ciXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cAG/VZYg1tbBVWV56Yza/FNpS4EtYQ911pPNLEyfbHs=; b=G/+3hp7H+aVDRyfdhQxHyt1vP+PMZrUWRi3q1Hc4uc36h20AEkNY4CDo2pP/aqH+r7 FotAyLdTFu0pbAqhBozCJQVwn6wN1iMO+ePxE4oH2AK7ADOQBq7afm0/YT2ky3KwyQ9f c4tAIRcZSszo+fUxhVg1cfLAyjrHSUhmep0chW1J2TTC32CTNHOZktHgTw/tUQ4PVuHW 0jHKRV3ygOrUDSOBwatDF6BCclNovnQcHVAM//rFs4ZMR9p+cSyUZ5bvyhNPHlFp4SJn u5pjKgYcFtvAHovItoxFvauoY1UlgE2pH9S+x6EXdSnSP2XkhaGUuV4GSm06KNGD9hYU uXtQ== X-Gm-Message-State: AOAM530Ch3TQPVVUWq+UxscbGJP74ZMSgZCkcsRq9vOZ4B0ZsNgiW/pI OVq//b57D4dhVADIjLsoOGRpciX8+0ayd9ExpA8y7qzYvSY= X-Google-Smtp-Source: ABdhPJylnNJb6p4QzUYV3be4VtwabqmTCYGcKZSPdOV//Zdu55bPMDH5jJjFhHWb1hGfAsS5f44HwiOdLy2oHUC3ZvY= X-Received: by 2002:a63:74b:: with SMTP id 72mr5405532pgh.4.1610466905294; Tue, 12 Jan 2021 07:55:05 -0800 (PST) MIME-Version: 1.0 References: <20210112134054.342-1-calvin.johnson@oss.nxp.com> <20210112134054.342-14-calvin.johnson@oss.nxp.com> In-Reply-To: <20210112134054.342-14-calvin.johnson@oss.nxp.com> From: Andy Shevchenko Date: Tue, 12 Jan 2021 17:55:54 +0200 Message-ID: Subject: Re: [net-next PATCH v3 13/15] phylink: introduce phylink_fwnode_phy_connect() To: Calvin Johnson Cc: Grant Likely , "Rafael J . Wysocki" , Jeremy Linton , Andrew Lunn , Florian Fainelli , Russell King - ARM Linux admin , Cristi Sovaiala , Florin Laurentiu Chiculita , Ioana Ciornei , Madalin Bucur , Heikki Krogerus , Marcin Wojtas , Pieter Jansen Van Vuuren , Jon , Diana Madalina Craciun , Linux Kernel Mailing List , netdev , Laurentiu Tudor , ACPI Devel Maling List , "linux.cj" , linux-arm Mailing List , "David S. Miller" , Heiner Kallweit , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 12, 2021 at 3:43 PM Calvin Johnson wrote: > > Define phylink_fwnode_phy_connect() to connect phy specified by > a fwnode to a phylink instance. ... > + phy_dev = fwnode_phy_find_device(phy_fwnode); > + /* We're done with the phy_node handle */ > + fwnode_handle_put(phy_fwnode); > + if (!phy_dev) > + return -ENODEV; > + > + ret = phy_attach_direct(pl->netdev, phy_dev, flags, > + pl->link_interface); > + if (ret) Hmm... Shouldn't you put phy_dev here? > + return ret; -- With Best Regards, Andy Shevchenko