From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 941AFC433E0 for ; Thu, 24 Dec 2020 12:14:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61568224B0 for ; Thu, 24 Dec 2020 12:14:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728235AbgLXMOL (ORCPT ); Thu, 24 Dec 2020 07:14:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727759AbgLXMOK (ORCPT ); Thu, 24 Dec 2020 07:14:10 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D64CAC061794; Thu, 24 Dec 2020 04:13:29 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id l23so1101023pjg.1; Thu, 24 Dec 2020 04:13:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UALr9ym4hsAZyiPOgyH1YaE+cu2KjtwJLBwTVvlB5/k=; b=Mg+X4meLskIl4Y4m1FU2Bpwk0/eLPjYsQ1bc2nFbH5sa/Fymch56YfhLwLr2zHgu6+ cHXDlkz0qPSrqikN8Kqss93Mb9vkwRYAKrpeV4/VhA5jIXmnM+r+mKthrMlJia4csbNU GRDdpX/FxssQBT5uUJNC0sqPiujRKyronrpH5ErzdcNk3jPAHK54x+IRg0kaYgGnaNVy qTTbaS8J8yo0mFvCaCaf05Nm5opZPixYbnD4EmO26MGunXN7ttnNV+X4MkiC9+PJ7RdU EKMl7kCTVAMhsNNJhptfAavOs4Thf1sP50uNALVbuHt6x76qWZvvSKKA3Ltv+UiORG2x 9whw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UALr9ym4hsAZyiPOgyH1YaE+cu2KjtwJLBwTVvlB5/k=; b=DOewvRm9Y/J2OsO6wMhI56oBcWF2vLVpNt7+0kuTstgUPBYz+YZ3QzQgsicipL8liY St7NGRW/f8qIeL+fDsmsxUdjMrXKjobTd1nLrPiU58Xxxwg+EnCJps3aMxfTAT20MI0I klXwo1CiPLCYCC7K55NIr9EuIYebJzZeKVseZTEg8gEJZqBRhICvCVW0KLz988t845yg amVNkBvhAU9QtXwS8iyn+V/3KDuIpeOsTb3VGCdYbnX3LQ75yWEC7s/UHhhUBWNYWrj/ fkFuw19ljJ9i44KqWEgiiAYi13psnharc8dVS1X4RAQQg79xq/kNaYdju2jLR5QKxkg9 Y8yw== X-Gm-Message-State: AOAM533+OMPivAPNV2jZ0Cg64UkOi3NfNn13xgpUbWs80hSNdm0i5WeG it+HthvmytjSND5afaOsNmJjh3KhVb7n+Uiz0Dg= X-Google-Smtp-Source: ABdhPJzFIC1SAIBCVWCBrnBnewdPpuCRgYW7JPpjkgyIwp7BAN66+GZ8WvhceftHJu5SPnS3x8pknFhFVqKS3VtWvWc= X-Received: by 2002:a17:902:e98c:b029:da:cb88:f11d with SMTP id f12-20020a170902e98cb02900dacb88f11dmr8616930plb.17.1608812009413; Thu, 24 Dec 2020 04:13:29 -0800 (PST) MIME-Version: 1.0 References: <20201224010907.263125-1-djrscally@gmail.com> <20201224010907.263125-6-djrscally@gmail.com> In-Reply-To: <20201224010907.263125-6-djrscally@gmail.com> From: Andy Shevchenko Date: Thu, 24 Dec 2020 14:13:13 +0200 Message-ID: Subject: Re: [PATCH v3 05/14] software_node: unregister software_nodes in reverse order To: Daniel Scally Cc: Linux Kernel Mailing List , ACPI Devel Maling List , Linux Media Mailing List , devel@acpica.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Yong Zhi , Sakari Ailus , Bingbu Cao , Tian Shu Qiu , Mauro Carvalho Chehab , Robert Moore , Erik Kaneda , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Laurent Pinchart , Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, Hans Verkuil , Marco Felsch , niklas.soderlund+renesas@ragnatech.se, Steve Longerbeam , "Krogerus, Heikki" , Linus Walleij , kernel test robot , Dan Carpenter , Laurent Pinchart Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 24, 2020 at 3:12 AM Daniel Scally wrote: > > To maintain consistency with software_node_unregister_nodes(), reverse > the order in which the software_node_unregister_node_group() function > unregisters nodes. ... > - * Unregister multiple software nodes at once. > + * Unregister multiple software nodes at once. The array will be unwound in > + * reverse order (i.e. last entry first) and thus if any member of the array > + * has its .parent member set then they should appear later in the array such > + * that they are unregistered first. I'm, as being not a native speaker, a bit confused by this comment. The idea is that children are unregistered first. Can you try to make it more clear maybe? > */ -- With Best Regards, Andy Shevchenko