From: Jinpu Wang <jinpu.wang@cloud.ionos.com>
To: "Ahmed S. Darwish" <a.darwish@linutronix.de>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
John Garry <john.garry@huawei.com>,
Jason Yan <yanaijie@huawei.com>, Daniel Wagner <dwagner@suse.de>,
Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Sebastian A. Siewior" <bigeasy@linutronix.de>
Subject: Re: [PATCH v3 09/19] scsi: pm80xx: Pass gfp_t flags to libsas event notifiers
Date: Mon, 18 Jan 2021 11:26:37 +0100 [thread overview]
Message-ID: <CAMGffEnTdWj86O6qa9i3XyVLCuneEpuSRBbf_zkCNmZUOwOo3w@mail.gmail.com> (raw)
In-Reply-To: <20210118100955.1761652-10-a.darwish@linutronix.de>
On Mon, Jan 18, 2021 at 11:10 AM Ahmed S. Darwish
<a.darwish@linutronix.de> wrote:
>
> Use the new libsas event notifiers API, which requires callers to
> explicitly pass the gfp_t memory allocation flags.
>
> Call chain analysis, pm8001_hwi.c:
>
> pm8001_interrupt_handler_msix() || pm8001_interrupt_handler_intx() || pm8001_tasklet()
> -> PM8001_CHIP_DISP->isr() = pm80xx_chip_isr()
> -> process_oq [spin_lock_irqsave(&pm8001_ha->lock, ...)]
> -> process_one_iomb()
> -> mpi_hw_event()
> -> hw_event_sas_phy_up()
> -> pm8001_bytes_dmaed()
> -> hw_event_sata_phy_up
> -> pm8001_bytes_dmaed()
>
> All functions are invoked by process_one_iomb(), which is invoked by the
> interrupt service routine and the tasklet handler. A similar call chain
> is also found at pm80xx_hwi.c. Pass GFP_ATOMIC.
>
> For pm8001_sas.c, pm8001_phy_control() runs in task context as it calls
> wait_for_completion() and msleep(). Pass GFP_KERNEL.
>
> Signed-off-by: Ahmed S. Darwish <a.darwish@linutronix.de>
> Reviewed-by: John Garry <john.garry@huawei.com>
> Cc: Jack Wang <jinpu.wang@cloud.ionos.com>
Reviewed-by: Jack Wang <jinpu.wang@cloud.ionos.com>
> ---
> drivers/scsi/pm8001/pm8001_hwi.c | 54 +++++++++++++++++++++-----------
> drivers/scsi/pm8001/pm8001_sas.c | 8 ++---
> drivers/scsi/pm8001/pm80xx_hwi.c | 41 +++++++++++++++---------
> 3 files changed, 65 insertions(+), 38 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c
> index dd15246d5b03..c8bfa8e6f211 100644
> --- a/drivers/scsi/pm8001/pm8001_hwi.c
> +++ b/drivers/scsi/pm8001/pm8001_hwi.c
> @@ -3179,7 +3179,7 @@ void pm8001_bytes_dmaed(struct pm8001_hba_info *pm8001_ha, int i)
> pm8001_dbg(pm8001_ha, MSG, "phy %d byte dmaded.\n", i);
>
> sas_phy->frame_rcvd_size = phy->frame_rcvd_size;
> - sas_notify_port_event(sas_phy, PORTE_BYTES_DMAED);
> + sas_notify_port_event_gfp(sas_phy, PORTE_BYTES_DMAED, GFP_ATOMIC);
> }
>
> /* Get the link rate speed */
> @@ -3336,7 +3336,7 @@ hw_event_sas_phy_up(struct pm8001_hba_info *pm8001_ha, void *piomb)
> else if (phy->identify.device_type != SAS_PHY_UNUSED)
> phy->identify.target_port_protocols = SAS_PROTOCOL_SMP;
> phy->sas_phy.oob_mode = SAS_OOB_MODE;
> - sas_notify_phy_event(&phy->sas_phy, PHYE_OOB_DONE);
> + sas_notify_phy_event_gfp(&phy->sas_phy, PHYE_OOB_DONE, GFP_ATOMIC);
> spin_lock_irqsave(&phy->sas_phy.frame_rcvd_lock, flags);
> memcpy(phy->frame_rcvd, &pPayload->sas_identify,
> sizeof(struct sas_identify_frame)-4);
> @@ -3379,7 +3379,7 @@ hw_event_sata_phy_up(struct pm8001_hba_info *pm8001_ha, void *piomb)
> phy->phy_type |= PORT_TYPE_SATA;
> phy->phy_attached = 1;
> phy->sas_phy.oob_mode = SATA_OOB_MODE;
> - sas_notify_phy_event(&phy->sas_phy, PHYE_OOB_DONE);
> + sas_notify_phy_event_gfp(&phy->sas_phy, PHYE_OOB_DONE, GFP_ATOMIC);
> spin_lock_irqsave(&phy->sas_phy.frame_rcvd_lock, flags);
> memcpy(phy->frame_rcvd, ((u8 *)&pPayload->sata_fis - 4),
> sizeof(struct dev_to_host_fis));
> @@ -3726,11 +3726,13 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void* piomb)
> break;
> case HW_EVENT_SATA_SPINUP_HOLD:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_SATA_SPINUP_HOLD\n");
> - sas_notify_phy_event(&phy->sas_phy, PHYE_SPINUP_HOLD);
> + sas_notify_phy_event_gfp(&phy->sas_phy, PHYE_SPINUP_HOLD,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_PHY_DOWN:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_PHY_DOWN\n");
> - sas_notify_phy_event(&phy->sas_phy, PHYE_LOSS_OF_SIGNAL);
> + sas_notify_phy_event_gfp(&phy->sas_phy, PHYE_LOSS_OF_SIGNAL,
> + GFP_ATOMIC);
> phy->phy_attached = 0;
> phy->phy_state = 0;
> hw_event_phy_down(pm8001_ha, piomb);
> @@ -3739,7 +3741,8 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void* piomb)
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_PORT_INVALID\n");
> sas_phy_disconnected(sas_phy);
> phy->phy_attached = 0;
> - sas_notify_port_event(sas_phy, PORTE_LINK_RESET_ERR);
> + sas_notify_port_event_gfp(sas_phy, PORTE_LINK_RESET_ERR,
> + GFP_ATOMIC);
> break;
> /* the broadcast change primitive received, tell the LIBSAS this event
> to revalidate the sas domain*/
> @@ -3750,20 +3753,23 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void* piomb)
> spin_lock_irqsave(&sas_phy->sas_prim_lock, flags);
> sas_phy->sas_prim = HW_EVENT_BROADCAST_CHANGE;
> spin_unlock_irqrestore(&sas_phy->sas_prim_lock, flags);
> - sas_notify_port_event(sas_phy, PORTE_BROADCAST_RCVD);
> + sas_notify_port_event_gfp(sas_phy, PORTE_BROADCAST_RCVD,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_PHY_ERROR:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_PHY_ERROR\n");
> sas_phy_disconnected(&phy->sas_phy);
> phy->phy_attached = 0;
> - sas_notify_phy_event(&phy->sas_phy, PHYE_OOB_ERROR);
> + sas_notify_phy_event_gfp(&phy->sas_phy, PHYE_OOB_ERROR,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_BROADCAST_EXP:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_BROADCAST_EXP\n");
> spin_lock_irqsave(&sas_phy->sas_prim_lock, flags);
> sas_phy->sas_prim = HW_EVENT_BROADCAST_EXP;
> spin_unlock_irqrestore(&sas_phy->sas_prim_lock, flags);
> - sas_notify_port_event(sas_phy, PORTE_BROADCAST_RCVD);
> + sas_notify_port_event_gfp(sas_phy, PORTE_BROADCAST_RCVD,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_LINK_ERR_INVALID_DWORD:
> pm8001_dbg(pm8001_ha, MSG,
> @@ -3772,7 +3778,8 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void* piomb)
> HW_EVENT_LINK_ERR_INVALID_DWORD, port_id, phy_id, 0, 0);
> sas_phy_disconnected(sas_phy);
> phy->phy_attached = 0;
> - sas_notify_port_event(sas_phy, PORTE_LINK_RESET_ERR);
> + sas_notify_port_event_gfp(sas_phy, PORTE_LINK_RESET_ERR,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_LINK_ERR_DISPARITY_ERROR:
> pm8001_dbg(pm8001_ha, MSG,
> @@ -3782,7 +3789,8 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void* piomb)
> port_id, phy_id, 0, 0);
> sas_phy_disconnected(sas_phy);
> phy->phy_attached = 0;
> - sas_notify_port_event(sas_phy, PORTE_LINK_RESET_ERR);
> + sas_notify_port_event_gfp(sas_phy, PORTE_LINK_RESET_ERR,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_LINK_ERR_CODE_VIOLATION:
> pm8001_dbg(pm8001_ha, MSG,
> @@ -3792,7 +3800,8 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void* piomb)
> port_id, phy_id, 0, 0);
> sas_phy_disconnected(sas_phy);
> phy->phy_attached = 0;
> - sas_notify_port_event(sas_phy, PORTE_LINK_RESET_ERR);
> + sas_notify_port_event_gfp(sas_phy, PORTE_LINK_RESET_ERR,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_LINK_ERR_LOSS_OF_DWORD_SYNCH:
> pm8001_dbg(pm8001_ha, MSG,
> @@ -3802,7 +3811,8 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void* piomb)
> port_id, phy_id, 0, 0);
> sas_phy_disconnected(sas_phy);
> phy->phy_attached = 0;
> - sas_notify_port_event(sas_phy, PORTE_LINK_RESET_ERR);
> + sas_notify_port_event_gfp(sas_phy, PORTE_LINK_RESET_ERR,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_MALFUNCTION:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_MALFUNCTION\n");
> @@ -3812,7 +3822,8 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void* piomb)
> spin_lock_irqsave(&sas_phy->sas_prim_lock, flags);
> sas_phy->sas_prim = HW_EVENT_BROADCAST_SES;
> spin_unlock_irqrestore(&sas_phy->sas_prim_lock, flags);
> - sas_notify_port_event(sas_phy, PORTE_BROADCAST_RCVD);
> + sas_notify_port_event_gfp(sas_phy, PORTE_BROADCAST_RCVD,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_INBOUND_CRC_ERROR:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_INBOUND_CRC_ERROR\n");
> @@ -3822,13 +3833,15 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void* piomb)
> break;
> case HW_EVENT_HARD_RESET_RECEIVED:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_HARD_RESET_RECEIVED\n");
> - sas_notify_port_event(sas_phy, PORTE_HARD_RESET);
> + sas_notify_port_event_gfp(sas_phy, PORTE_HARD_RESET,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_ID_FRAME_TIMEOUT:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_ID_FRAME_TIMEOUT\n");
> sas_phy_disconnected(sas_phy);
> phy->phy_attached = 0;
> - sas_notify_port_event(sas_phy, PORTE_LINK_RESET_ERR);
> + sas_notify_port_event_gfp(sas_phy, PORTE_LINK_RESET_ERR,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_LINK_ERR_PHY_RESET_FAILED:
> pm8001_dbg(pm8001_ha, MSG,
> @@ -3838,20 +3851,23 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void* piomb)
> port_id, phy_id, 0, 0);
> sas_phy_disconnected(sas_phy);
> phy->phy_attached = 0;
> - sas_notify_port_event(sas_phy, PORTE_LINK_RESET_ERR);
> + sas_notify_port_event_gfp(sas_phy, PORTE_LINK_RESET_ERR,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_PORT_RESET_TIMER_TMO:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_PORT_RESET_TIMER_TMO\n");
> sas_phy_disconnected(sas_phy);
> phy->phy_attached = 0;
> - sas_notify_port_event(sas_phy, PORTE_LINK_RESET_ERR);
> + sas_notify_port_event_gfp(sas_phy, PORTE_LINK_RESET_ERR,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_PORT_RECOVERY_TIMER_TMO:
> pm8001_dbg(pm8001_ha, MSG,
> "HW_EVENT_PORT_RECOVERY_TIMER_TMO\n");
> sas_phy_disconnected(sas_phy);
> phy->phy_attached = 0;
> - sas_notify_port_event(sas_phy, PORTE_LINK_RESET_ERR);
> + sas_notify_port_event_gfp(sas_phy, PORTE_LINK_RESET_ERR,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_PORT_RECOVER:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_PORT_RECOVER\n");
> diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c
> index e21c6cfff4cb..da444facd52e 100644
> --- a/drivers/scsi/pm8001/pm8001_sas.c
> +++ b/drivers/scsi/pm8001/pm8001_sas.c
> @@ -207,16 +207,16 @@ int pm8001_phy_control(struct asd_sas_phy *sas_phy, enum phy_func func,
> if (pm8001_ha->phy[phy_id].phy_state ==
> PHY_STATE_LINK_UP_SPCV) {
> sas_phy_disconnected(&phy->sas_phy);
> - sas_notify_phy_event(&phy->sas_phy,
> - PHYE_LOSS_OF_SIGNAL);
> + sas_notify_phy_event_gfp(&phy->sas_phy,
> + PHYE_LOSS_OF_SIGNAL, GFP_KERNEL);
> phy->phy_attached = 0;
> }
> } else {
> if (pm8001_ha->phy[phy_id].phy_state ==
> PHY_STATE_LINK_UP_SPC) {
> sas_phy_disconnected(&phy->sas_phy);
> - sas_notify_phy_event(&phy->sas_phy,
> - PHYE_LOSS_OF_SIGNAL);
> + sas_notify_phy_event_gfp(&phy->sas_phy,
> + PHYE_LOSS_OF_SIGNAL, GFP_KERNEL);
> phy->phy_attached = 0;
> }
> }
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
> index f617177b7bb3..a43a4e5db043 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -3287,7 +3287,7 @@ hw_event_sas_phy_up(struct pm8001_hba_info *pm8001_ha, void *piomb)
> else if (phy->identify.device_type != SAS_PHY_UNUSED)
> phy->identify.target_port_protocols = SAS_PROTOCOL_SMP;
> phy->sas_phy.oob_mode = SAS_OOB_MODE;
> - sas_notify_phy_event(&phy->sas_phy, PHYE_OOB_DONE);
> + sas_notify_phy_event_gfp(&phy->sas_phy, PHYE_OOB_DONE, GFP_ATOMIC);
> spin_lock_irqsave(&phy->sas_phy.frame_rcvd_lock, flags);
> memcpy(phy->frame_rcvd, &pPayload->sas_identify,
> sizeof(struct sas_identify_frame)-4);
> @@ -3334,7 +3334,7 @@ hw_event_sata_phy_up(struct pm8001_hba_info *pm8001_ha, void *piomb)
> phy->phy_type |= PORT_TYPE_SATA;
> phy->phy_attached = 1;
> phy->sas_phy.oob_mode = SATA_OOB_MODE;
> - sas_notify_phy_event(&phy->sas_phy, PHYE_OOB_DONE);
> + sas_notify_phy_event_gfp(&phy->sas_phy, PHYE_OOB_DONE, GFP_ATOMIC);
> spin_lock_irqsave(&phy->sas_phy.frame_rcvd_lock, flags);
> memcpy(phy->frame_rcvd, ((u8 *)&pPayload->sata_fis - 4),
> sizeof(struct dev_to_host_fis));
> @@ -3417,7 +3417,8 @@ hw_event_phy_down(struct pm8001_hba_info *pm8001_ha, void *piomb)
>
> }
> if (port_sata && (portstate != PORT_IN_RESET))
> - sas_notify_phy_event(&phy->sas_phy, PHYE_LOSS_OF_SIGNAL);
> + sas_notify_phy_event_gfp(&phy->sas_phy, PHYE_LOSS_OF_SIGNAL,
> + GFP_ATOMIC);
> }
>
> static int mpi_phy_start_resp(struct pm8001_hba_info *pm8001_ha, void *piomb)
> @@ -3515,7 +3516,8 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void *piomb)
> break;
> case HW_EVENT_SATA_SPINUP_HOLD:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_SATA_SPINUP_HOLD\n");
> - sas_notify_phy_event(&phy->sas_phy, PHYE_SPINUP_HOLD);
> + sas_notify_phy_event_gfp(&phy->sas_phy, PHYE_SPINUP_HOLD,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_PHY_DOWN:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_PHY_DOWN\n");
> @@ -3531,7 +3533,8 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void *piomb)
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_PORT_INVALID\n");
> sas_phy_disconnected(sas_phy);
> phy->phy_attached = 0;
> - sas_notify_port_event(sas_phy, PORTE_LINK_RESET_ERR);
> + sas_notify_port_event_gfp(sas_phy, PORTE_LINK_RESET_ERR,
> + GFP_ATOMIC);
> break;
> /* the broadcast change primitive received, tell the LIBSAS this event
> to revalidate the sas domain*/
> @@ -3542,20 +3545,23 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void *piomb)
> spin_lock_irqsave(&sas_phy->sas_prim_lock, flags);
> sas_phy->sas_prim = HW_EVENT_BROADCAST_CHANGE;
> spin_unlock_irqrestore(&sas_phy->sas_prim_lock, flags);
> - sas_notify_port_event(sas_phy, PORTE_BROADCAST_RCVD);
> + sas_notify_port_event_gfp(sas_phy, PORTE_BROADCAST_RCVD,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_PHY_ERROR:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_PHY_ERROR\n");
> sas_phy_disconnected(&phy->sas_phy);
> phy->phy_attached = 0;
> - sas_notify_phy_event(&phy->sas_phy, PHYE_OOB_ERROR);
> + sas_notify_phy_event_gfp(&phy->sas_phy, PHYE_OOB_ERROR,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_BROADCAST_EXP:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_BROADCAST_EXP\n");
> spin_lock_irqsave(&sas_phy->sas_prim_lock, flags);
> sas_phy->sas_prim = HW_EVENT_BROADCAST_EXP;
> spin_unlock_irqrestore(&sas_phy->sas_prim_lock, flags);
> - sas_notify_port_event(sas_phy, PORTE_BROADCAST_RCVD);
> + sas_notify_port_event_gfp(sas_phy, PORTE_BROADCAST_RCVD,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_LINK_ERR_INVALID_DWORD:
> pm8001_dbg(pm8001_ha, MSG,
> @@ -3592,7 +3598,8 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void *piomb)
> spin_lock_irqsave(&sas_phy->sas_prim_lock, flags);
> sas_phy->sas_prim = HW_EVENT_BROADCAST_SES;
> spin_unlock_irqrestore(&sas_phy->sas_prim_lock, flags);
> - sas_notify_port_event(sas_phy, PORTE_BROADCAST_RCVD);
> + sas_notify_port_event_gfp(sas_phy, PORTE_BROADCAST_RCVD,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_INBOUND_CRC_ERROR:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_INBOUND_CRC_ERROR\n");
> @@ -3602,13 +3609,15 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void *piomb)
> break;
> case HW_EVENT_HARD_RESET_RECEIVED:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_HARD_RESET_RECEIVED\n");
> - sas_notify_port_event(sas_phy, PORTE_HARD_RESET);
> + sas_notify_port_event_gfp(sas_phy, PORTE_HARD_RESET,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_ID_FRAME_TIMEOUT:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_ID_FRAME_TIMEOUT\n");
> sas_phy_disconnected(sas_phy);
> phy->phy_attached = 0;
> - sas_notify_port_event(sas_phy, PORTE_LINK_RESET_ERR);
> + sas_notify_port_event_gfp(sas_phy, PORTE_LINK_RESET_ERR,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_LINK_ERR_PHY_RESET_FAILED:
> pm8001_dbg(pm8001_ha, MSG,
> @@ -3618,7 +3627,8 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void *piomb)
> port_id, phy_id, 0, 0);
> sas_phy_disconnected(sas_phy);
> phy->phy_attached = 0;
> - sas_notify_port_event(sas_phy, PORTE_LINK_RESET_ERR);
> + sas_notify_port_event_gfp(sas_phy, PORTE_LINK_RESET_ERR,
> + GFP_ATOMIC);
> break;
> case HW_EVENT_PORT_RESET_TIMER_TMO:
> pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_PORT_RESET_TIMER_TMO\n");
> @@ -3626,7 +3636,8 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void *piomb)
> port_id, phy_id, 0, 0);
> sas_phy_disconnected(sas_phy);
> phy->phy_attached = 0;
> - sas_notify_port_event(sas_phy, PORTE_LINK_RESET_ERR);
> + sas_notify_port_event_gfp(sas_phy, PORTE_LINK_RESET_ERR,
> + GFP_ATOMIC);
> if (pm8001_ha->phy[phy_id].reset_completion) {
> pm8001_ha->phy[phy_id].port_reset_status =
> PORT_RESET_TMO;
> @@ -3643,8 +3654,8 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void *piomb)
> for (i = 0; i < pm8001_ha->chip->n_phy; i++) {
> if (port->wide_port_phymap & (1 << i)) {
> phy = &pm8001_ha->phy[i];
> - sas_notify_phy_event(&phy->sas_phy,
> - PHYE_LOSS_OF_SIGNAL);
> + sas_notify_phy_event_gfp(&phy->sas_phy,
> + PHYE_LOSS_OF_SIGNAL, GFP_ATOMIC);
> port->wide_port_phymap &= ~(1 << i);
> }
> }
> --
> 2.30.0
>
next prev parent reply other threads:[~2021-01-18 20:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 10:09 [PATCH v3 00/19] scsi: libsas: Remove in_interrupt() check Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 01/19] Documentation: scsi: libsas: Remove notify_ha_event() Ahmed S. Darwish
2021-01-18 10:22 ` Jinpu Wang
2021-01-18 10:09 ` [PATCH v3 02/19] scsi: libsas and users: Remove notifier indirection Ahmed S. Darwish
2021-01-18 10:26 ` Jinpu Wang
2021-01-18 10:09 ` [PATCH v3 03/19] scsi: libsas: Introduce a _gfp() variant of event notifiers Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 04/19] scsi: mvsas: Pass gfp_t flags to libsas " Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 05/19] scsi: isci: port: link down: Pass gfp_t flags Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 06/19] scsi: isci: port: link up: " Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 07/19] scsi: isci: port: broadcast change: " Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 08/19] scsi: libsas: Pass gfp_t flags to event notifiers Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 09/19] scsi: pm80xx: Pass gfp_t flags to libsas " Ahmed S. Darwish
2021-01-18 10:26 ` Jinpu Wang [this message]
2021-01-18 10:09 ` [PATCH v3 10/19] scsi: aic94xx: " Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 11/19] scsi: hisi_sas: " Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 12/19] scsi: libsas: event notifiers API: Add gfp_t flags parameter Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 13/19] scsi: hisi_sas: Switch back to original libsas event notifiers Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 14/19] scsi: aic94xx: " Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 15/19] scsi: pm80xx: " Ahmed S. Darwish
2021-01-18 10:27 ` Jinpu Wang
2021-01-18 10:09 ` [PATCH v3 16/19] scsi: libsas: Switch back to original event notifiers API Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 17/19] scsi: isci: Switch back to original libsas event notifiers Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 18/19] scsi: mvsas: " Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 19/19] scsi: libsas: Remove temporarily-added _gfp() API variants Ahmed S. Darwish
2021-01-23 2:32 ` [PATCH v3 00/19] scsi: libsas: Remove in_interrupt() check Martin K. Petersen
2021-01-27 4:54 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMGffEnTdWj86O6qa9i3XyVLCuneEpuSRBbf_zkCNmZUOwOo3w@mail.gmail.com \
--to=jinpu.wang@cloud.ionos.com \
--cc=a.darwish@linutronix.de \
--cc=artur.paszkiewicz@intel.com \
--cc=bigeasy@linutronix.de \
--cc=dwagner@suse.de \
--cc=hch@infradead.org \
--cc=jejb@linux.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tglx@linutronix.de \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).