From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7812FC433E0 for ; Mon, 28 Dec 2020 08:45:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42D60208BA for ; Mon, 28 Dec 2020 08:45:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726558AbgL1Ipc (ORCPT ); Mon, 28 Dec 2020 03:45:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726452AbgL1Ipc (ORCPT ); Mon, 28 Dec 2020 03:45:32 -0500 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20355C061795 for ; Mon, 28 Dec 2020 00:44:49 -0800 (PST) Received: by mail-ej1-x62d.google.com with SMTP id ga15so13300266ejb.4 for ; Mon, 28 Dec 2020 00:44:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ppXu0qV4C54uI/fuy6D+G5bxDztbKunvaXhWrsDm5jA=; b=MVNsb34DoioU+GZLKWnbbTanHXUVLEp2UFgx+Y9LtRUauDXqjv55yzRxdLQ0HiY0au AHEB1Qv6P7i5Ph/Tg93PD7hvxNV8K9iVtofT5P4yiM06O5xA6PbyDmUYg1RP5ynGwDwb WDhWG2ZL0DiMbJgpqetw8N9hf9+rxZXWYz570= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ppXu0qV4C54uI/fuy6D+G5bxDztbKunvaXhWrsDm5jA=; b=Zs3FycIC9LkaCfy0MXyFXAD2VKgE2yWk/HT+6u1f+SXl8bJReHPxUX0cLdmEEW5lpC w6JLIQ+rMq4br+MMkGB7iPwLIM2kaptQOX16thRxt0FMkyi1H/+JXuWPZ0JYAVhR3Ozp heELSA7oOFPy7mFB/CQCOmlrS12EI6txIGd0nHOZpEqaAKXYrW4vA8yogkcKfFAomcFI JgJ3j2U7DjrT+SQChmpz+T8XJFVAwrdJCaM2CM2V2bh92wOHjC2dJsPiBi3nru/DO7md GPyWgc0ALQMa4e3JiAg/wSp4Nyv1jCdc0L9eg0x10MwgCSn4XtesCc02qn/SYkauu/rf w5NQ== X-Gm-Message-State: AOAM53079eOUqr97C/MYwIETjEMAB5CexwCXV27MVRUBc/clOsnyXzLa Y66tccyrmkcoUdI0bA57DI3EbHss8DUjo7YtYADSTfDY5a15pw== X-Google-Smtp-Source: ABdhPJyCHehA/zup+bEMF6neYLPp/jzGVF3ynfCMew8B2Ml1R0wH0iBvAuLZd9dxxXiAF+oI5mnC4Uw08Xbc4fkNso4= X-Received: by 2002:a17:906:c310:: with SMTP id s16mr40964548ejz.186.1609145087787; Mon, 28 Dec 2020 00:44:47 -0800 (PST) MIME-Version: 1.0 References: <20201223110343.126638-1-jagan@amarulasolutions.com> <20201223110343.126638-5-jagan@amarulasolutions.com> <20201223115933.GC21091@kozik-lap> In-Reply-To: From: Jagan Teki Date: Mon, 28 Dec 2020 14:14:36 +0530 Message-ID: Subject: Re: [PATCH v3 4/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0 To: Krzysztof Kozlowski Cc: Rob Herring , Shawn Guo , Li Yang , Fabio Estevam , devicetree , linux-kernel , linux-arm-kernel , NXP Linux Team , linux-amarula , Catalin Marinas , Will Deacon , Matteo Lisi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 28, 2020 at 2:04 PM Krzysztof Kozlowski wrote: > > On Mon, 28 Dec 2020 at 09:21, Jagan Teki wrote: > > > > #include "imx8mm.dtsi" > > > > #include "imx8mm-beacon-som.dtsi" > > > > #include "imx8mm-beacon-baseboard.dtsi" > > > > > > > > (SoC dtsi, SoM dtsi, Carrier board dtsi) > > > > > > > > > design which makes any sense. We do not create empty DTS files which > > > > > only include one more DTSI. The contents of > > > > > imx8mm-engicam-ctouch2.dtsi should be directly in > > > > > imx8mm-icore-mx8mm-ctouch2.dts. That's the same problem as with v1 - > > > > > you overcomplicate simple stuff. It really looks like you ignored the > > > > > comments from v1 in multiple places. > > > > > > > > As explained above, the design is pretty much the same as the existing SoM's. > > > > > > > > imx8mm-engicam-ctouch2.dtsi is not just a dtsi file where nodes are > > > > enabled. It has nodes enabled for Carrier board, so keeping nodes > > > > separately will > > > > > > The files represent real devices or their components. So you have a > > > SOM - a DTSI file. You have a carrier board - a DTS file. That's > > > simple design which is mostly followed, unless something over > > > complicated passes the review. > > > > > > > 1. More verbose for which IP's are available in the carrier board > > > > > > No difference when carrier DTSI is the DTS. Exactly the same. > > > > > > > 2. Easy to extend if someone can create another SoM with a similar Carrier. > > > > > > Not really, if they include carrier DTSI they need to override a lot. > > > So usually (including practice - I did it) they *copy* the carrier to > > > create their own design. > > > > But what if the new board has slite change to use exiting carrier like > > what ctouch2 10" OF. Can we add ctouch2 dtsi as a separate file for > > this case? > > If you submit another DTS using the imx8mm-engicam-ctouch2.dtsi - with > its own differences of course (not copying other DTS...) - then having > a DTSI makes sense. In current form, still NAK for all the reasons I > explained more than once. Okay, thanks for the review. Jagan.