From: "Wu, Wentong" <wentong.wu@intel.com>
To: Mark Brown <broonie@kernel.org>, "Ye, Xiang" <xiang.ye@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Matthias Kaehlcke <mka@chromium.org>, Lee Jones <lee@kernel.org>,
Wolfram Sang <wsa@kernel.org>, Tyrone Ting <kfting@nuvoton.com>,
Linus Walleij <linus.walleij@linaro.org>,
Marc Zyngier <maz@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
"Wang, Zhifeng" <zhifeng.wang@intel.com>,
"Zhang, Lixu" <lixu.zhang@intel.com>
Subject: RE: [PATCH v8 6/6] spi: Add support for Intel LJCA USB SPI driver
Date: Tue, 20 Jun 2023 06:47:11 +0000 [thread overview]
Message-ID: <DM6PR11MB4316E9530309ACCEF55AD0D18D5CA@DM6PR11MB4316.namprd11.prod.outlook.com> (raw)
In-Reply-To: <ZF2+C0CqaBff2hl+@finisterre.sirena.org.uk>
Hi Brown,
Thanks for your review
> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Friday, May 12, 2023 12:18 PM
>
> On Fri, May 12, 2023 at 01:58:44AM +0800, Ye Xiang wrote:
>
> > +++ b/drivers/spi/spi-ljca.c
> > @@ -0,0 +1,290 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Intel La Jolla Cove Adapter USB-SPI driver
>
> Please make the entire comment a C++ one so things look more intentional.
>
I see lots of drivers are commenting like current one.
But sorry, you mean the entire comment start with /* and end with */ ? Thanks
BR,
Wentong
> > +struct spi_init_packet {
> > + u8 index;
> > + u8 speed;
> > + u8 mode;
> > +} __packed;
> > +
> > +struct spi_xfer_packet {
>
> These should be namespaced, especially since they look likely to collide with
> other things. Otherwise this looks fine.
Ack, these two structs will be like below in next version, thanks
struct ljca_spi_init_packet {
u8 index;
u8 index;
u8 mode;
} __packed;
struct ljca_spi_xfer_packet {
u8 indicator;
s8 len;
u8 data[];
} __packed;
next prev parent reply other threads:[~2023-06-20 6:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 17:58 [PATCH v8 0/6] Add Intel LJCA device driver Ye Xiang
2023-05-11 17:58 ` [PATCH v8 1/6] usb: Add support for Intel LJCA device Ye Xiang
2023-05-22 9:21 ` Oliver Neukum
2023-06-20 7:39 ` Wu, Wentong
2023-06-20 12:11 ` Oliver Neukum
2023-05-11 17:58 ` [PATCH v8 2/6] usb: ljca: Add transport interfaces for sub-module drivers Ye Xiang
2023-05-22 9:36 ` Oliver Neukum
2023-05-11 17:58 ` [PATCH v8 3/6] Documentation: Add ABI doc for attributes of LJCA device Ye Xiang
2023-05-11 17:58 ` [PATCH v8 4/6] gpio: Add support for Intel LJCA USB GPIO driver Ye Xiang
2023-05-11 21:07 ` Linus Walleij
2023-06-20 7:00 ` Wu, Wentong
2023-05-15 15:49 ` Bartosz Golaszewski
2023-07-03 1:11 ` Wu, Wentong
2023-05-11 17:58 ` [PATCH v8 5/6] i2c: Add support for Intel LJCA USB I2C driver Ye Xiang
2023-05-22 9:50 ` Oliver Neukum
2023-06-20 6:57 ` Wu, Wentong
2023-05-11 17:58 ` [PATCH v8 6/6] spi: Add support for Intel LJCA USB SPI driver Ye Xiang
2023-05-12 4:18 ` Mark Brown
2023-06-20 6:47 ` Wu, Wentong [this message]
2023-06-20 11:39 ` Mark Brown
2023-05-13 8:50 ` [PATCH v8 0/6] Add Intel LJCA device driver Greg Kroah-Hartman
2023-06-20 8:10 ` Wu, Wentong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB4316E9530309ACCEF55AD0D18D5CA@DM6PR11MB4316.namprd11.prod.outlook.com \
--to=wentong.wu@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kfting@nuvoton.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=maz@kernel.org \
--cc=mka@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=srinivas.pandruvada@intel.com \
--cc=wsa@kernel.org \
--cc=xiang.ye@intel.com \
--cc=zhifeng.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).