From: James Morris <jmorris@namei.org>
To: "Ahmed S. Darwish" <darwish.07@gmail.com>
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
Casey Schaufler <casey@schaufler-ca.com>,
Adrian Bunk <bunk@kernel.org>, Chris Wright <chrisw@sous-sol.org>,
Eric Paris <eparis@parisplace.org>,
Alexey Dobriyan <adobriyan@sw.ru>,
LKML <linux-kernel@vger.kernel.org>,
LSM-ML <linux-security-module@vger.kernel.org>,
Anrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -v4 -mm] LSM: Add security= boot parameter
Date: Tue, 4 Mar 2008 09:16:19 +1100 (EST) [thread overview]
Message-ID: <Xine.LNX.4.64.0803040906380.21610@us.intercode.com.au> (raw)
In-Reply-To: <20080303212433.GA12998@ubuntu>
On Mon, 3 Mar 2008, Ahmed S. Darwish wrote:
> static inline int verify(struct security_operations *ops)
> {
> /* verify the security_operations structure exists */
> - if (!ops)
> + if (!ops || !ops->name)
> return -EINVAL;
verify() will now be called after ops->name has been referenced, so these
checks won't be necessary now.
> +int security_module_enable(struct security_operations *ops)
> +{
> + if (!ops || !ops->name) {
> + BUG();
> + return 0;
> + }
It's not going to return after BUG(), and actually, you can probably just
rely on the subsequent oops (i.e. no check needed).
> +
> + if (!*chosen_lsm && atomic_inc_and_test(&security_ops_enabled))
> + return 1;
> +
> + if (!strncmp(ops->name, chosen_lsm, SECURITY_NAME_MAX))
> + return 1;
I still think you should use a spinlock here to make the semantics
simpler. Dispense with the confusingly named security_ops_enabled, and
fill chosen_lsm in with the first lsm to regsiter if none chosen at boot.
> + printk(KERN_INFO "SELinux: Another security module was chosen.\n");
> + printk(KERN_INFO "SELinux: Use security=%s to force loading "
> + "SELinux on boot.\n", selinux_ops.name);
These messages are not going to scale, e.g. what if there are 20 LSMs
compiled in, and they all print this on boot? Just print the chosen LSM
in security_module_enabled().
- James
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2008-03-03 22:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-01 19:07 [RFC PATCH -mm] LSM: Add lsm= boot parameter Ahmed S. Darwish
2008-03-01 20:28 ` Casey Schaufler
2008-03-01 21:11 ` Adrian Bunk
2008-03-01 21:29 ` Casey Schaufler
2008-03-01 23:27 ` [PATCH -v2 -mm] LSM: Add security= " Ahmed S. Darwish
2008-03-02 3:41 ` Casey Schaufler
2008-03-02 7:55 ` Ahmed S. Darwish
2008-03-02 7:49 ` Ahmed S. Darwish
2008-03-02 10:59 ` [PATCH -v3 " Ahmed S. Darwish
2008-03-02 18:37 ` Casey Schaufler
2008-03-03 8:29 ` James Morris
2008-03-03 15:35 ` Ahmed S. Darwish
2008-03-03 15:54 ` Stephen Smalley
2008-03-03 21:24 ` [PATCH -v4 " Ahmed S. Darwish
2008-03-03 22:16 ` James Morris [this message]
2008-03-04 3:04 ` [PATCH -v5 " Ahmed S. Darwish
2008-03-04 4:07 ` James Morris
2008-03-05 22:29 ` Andrew Morton
2008-03-05 22:56 ` Ahmed S. Darwish
2008-03-05 23:06 ` Ahmed S. Darwish
2008-03-05 22:56 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Xine.LNX.4.64.0803040906380.21610@us.intercode.com.au \
--to=jmorris@namei.org \
--cc=adobriyan@sw.ru \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=casey@schaufler-ca.com \
--cc=chrisw@sous-sol.org \
--cc=darwish.07@gmail.com \
--cc=eparis@parisplace.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).