From: Mark Brown <broonie@kernel.org>
To: Herve Codina <herve.codina@bootlin.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 2/3] ASoC: codecs: Add support for the Renesas X9250 potentiometers
Date: Fri, 3 Feb 2023 12:28:32 +0000 [thread overview]
Message-ID: <Y9z98CXXyI7UkrkZ@sirena.org.uk> (raw)
In-Reply-To: <20230203111422.142479-3-herve.codina@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 820 bytes --]
On Fri, Feb 03, 2023 at 12:14:21PM +0100, Herve Codina wrote:
> +static const struct snd_kcontrol_new x9250_controls_std[] = {
> + SOC_SINGLE_EXT("CMD0", 0, 0, 255, 0, x8250_kctrl_cmd_get, x8250_kctrl_cmd_put),
> + SOC_SINGLE_EXT("CMD1", 1, 0, 255, 0, x8250_kctrl_cmd_get, x8250_kctrl_cmd_put),
> + SOC_SINGLE_EXT("CMD2", 2, 0, 255, 0, x8250_kctrl_cmd_get, x8250_kctrl_cmd_put),
> + SOC_SINGLE_EXT("CMD3", 3, 0, 255, 0, x8250_kctrl_cmd_get, x8250_kctrl_cmd_put),
> +};
These control names feel a bit icky but given that they have board
specific functions I don't see a way to sensibly rewrite them. However
I do wonder if we might be better off having this as an IIO driver and
having a binding that lets us import IIO outputs into sound cards - I'm
guessing there are other non-audio applications for this hardware?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-02-03 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 11:14 [PATCH 0/3] Add the Renesas X9250 potentiometers ASoC support Herve Codina
2023-02-03 11:14 ` [PATCH 1/3] dt-bindings: sound: Add the Renesas X9250 potentiometers Herve Codina
2023-02-03 22:08 ` Rob Herring
2023-02-03 11:14 ` [PATCH 2/3] ASoC: codecs: Add support for " Herve Codina
2023-02-03 12:28 ` Mark Brown [this message]
2023-02-03 11:14 ` [PATCH 3/3] MAINTAINERS: add the Renesas X9250 ASoC entry Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9z98CXXyI7UkrkZ@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=christophe.leroy@csgroup.eu \
--cc=devicetree@vger.kernel.org \
--cc=herve.codina@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).