From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82C72C433DB for ; Mon, 18 Jan 2021 20:52:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 564D522472 for ; Mon, 18 Jan 2021 20:52:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390632AbhARUwU (ORCPT ); Mon, 18 Jan 2021 15:52:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394483AbhARUux (ORCPT ); Mon, 18 Jan 2021 15:50:53 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88F55C061574 for ; Mon, 18 Jan 2021 12:50:12 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id o10so25922851lfl.13 for ; Mon, 18 Jan 2021 12:50:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=PBJOvjAiOhmMWsZCYIdfqOTw6TCWRMDqPYu2m3TOPyA=; b=ean573HMotYRkhpmfuWcuDU9xxWJXixSAnZTqXu+lzblvz5PPhlHX2pG1XMiWf9gj3 mBUGsa4kUt2npW6Z4XPzvnHSMZYHpQgb5wcgp4Yg5JjOAGZxHpTEvLJvpDeIOS8NqdeR eFpMC0k5M26afcDq8GRIAe8bupmbEu4A6QEPJqqkwiOLCODzkh/kqjujK9wX6RWhiZX2 01i+p7pl5juQwhpyh6JHgz79hTRQnB3AjfprNPJWjMUKpp/1tU1GwPHpVKlzdFZ7Xvau pRCXkkkz8c43spsSvOmaiTJ3IWDb6rZJFbJgDX9JihQviOn/TSY31zD9X+vS2gY53h6x dC6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=PBJOvjAiOhmMWsZCYIdfqOTw6TCWRMDqPYu2m3TOPyA=; b=R/Cu+86kK5aQRaLQpCMwbEGBfzqh+AGiZupP82uI6sMjiHWf78diXDUJ3a8InwkJ00 5r+X0iRm1wzuw5PSElAkHTBUaZZg7I9vx0H/cVMsVIzHFI5JWdbM/EM4YIhL1K/6yjq+ gQeHHwC4+DpnfO85aiS8zeNAQ2HCfK3GuIC6iuGpuZpJF5f0tlC1x0Xk7Ci4ukTpOCnn 5X05Dz5S36LRf7zspL5EI6guKxtLLAg0NmhiF68iMjsf/4H3+GeqHfa0E52SxU1QGSWk nBITY5krL92NGtUuEPlW+GsKyGr+d9MMTUKPQ4ZMQBRhz9/aR8zh+ANE2fDFoa5XNSu9 RgFQ== X-Gm-Message-State: AOAM530Em080gPZBOqGwqTsrWohX5aK6tP+KQF5oNvclWAmpRy2ubx2M nMaeFXEhhX/blwcGaA8jeyqUHw== X-Google-Smtp-Source: ABdhPJyRdBzbTcJLLjUIbNdqXAdPYYwTNEavwmm4K5yZC4JkSGTHPIGL1GSU4vGZxVQVmLM95ztrBQ== X-Received: by 2002:a05:6512:3493:: with SMTP id v19mr374356lfr.569.1611003011132; Mon, 18 Jan 2021 12:50:11 -0800 (PST) Received: from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203]) by smtp.gmail.com with ESMTPSA id k18sm1788227ljb.80.2021.01.18.12.50.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jan 2021 12:50:10 -0800 (PST) Date: Mon, 18 Jan 2021 21:50:09 +0100 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Geert Uytterhoeven Cc: Sergei Shtylyov , "David S . Miller" , Jakub Kicinski , Simon Horman , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sh_eth: Fix power down vs. is_opened flag ordering Message-ID: References: <20210118150812.796791-1-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210118150812.796791-1-geert+renesas@glider.be> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Thanks for your work. On 2021-01-18 16:08:12 +0100, Geert Uytterhoeven wrote: > sh_eth_close() does a synchronous power down of the device before > marking it closed. Revert the order, to make sure the device is never > marked opened while suspended. > > While at it, use pm_runtime_put() instead of pm_runtime_put_sync(), as > there is no reason to do a synchronous power down. > > Fixes: 7fa2955ff70ce453 ("sh_eth: Fix sleeping function called from invalid context") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Niklas Söderlund > --- > drivers/net/ethernet/renesas/sh_eth.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c > index 9b52d350e21a9f2b..590b088bc4c7f3e2 100644 > --- a/drivers/net/ethernet/renesas/sh_eth.c > +++ b/drivers/net/ethernet/renesas/sh_eth.c > @@ -2606,10 +2606,10 @@ static int sh_eth_close(struct net_device *ndev) > /* Free all the skbuffs in the Rx queue and the DMA buffer. */ > sh_eth_ring_free(ndev); > > - pm_runtime_put_sync(&mdp->pdev->dev); > - > mdp->is_opened = 0; > > + pm_runtime_put(&mdp->pdev->dev); > + > return 0; > } > > -- > 2.25.1 > -- Regards, Niklas Söderlund