From: Rob Herring <robh@kernel.org>
To: David Brazdil <dbrazdil@google.com>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Frank Rowand <frowand.list@gmail.com>,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: restricted dma: Fix condition for rmem init
Date: Fri, 17 Sep 2021 15:58:11 -0500 [thread overview]
Message-ID: <YUUBYx7qiwYjxhIG@robh.at.kernel.org> (raw)
In-Reply-To: <20210917131423.2760155-1-dbrazdil@google.com>
On Fri, 17 Sep 2021 14:14:23 +0100, David Brazdil wrote:
> of_dma_set_restricted_buffer fails to handle negative return values from
> of_property_count_elems_of_size, e.g. when the property does not exist.
> This results in an attempt to assign a non-existent reserved memory
> region to the device and a warning being printed. Fix the condition to
> take negative values into account.
>
> Fixes: f3cfd136aef0 ("of: restricted dma: Don't fail device probe on
> rmem init failure")
> Cc: Will Deacon <will@kernel.org>
> Signed-off-by: David Brazdil <dbrazdil@google.com>
> ---
> drivers/of/device.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Applied, thanks!
prev parent reply other threads:[~2021-09-17 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 13:14 [PATCH] of: restricted dma: Fix condition for rmem init David Brazdil
2021-09-17 14:51 ` Will Deacon
2021-09-17 20:58 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUUBYx7qiwYjxhIG@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=dbrazdil@google.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).