From: Javier Martinez Canillas <javierm@redhat.com>
To: "Maíra Canal" <maira.canal@usp.br>,
"Isabella Basso" <isabbasso@riseup.net>,
magalilemes00@gmail.com, tales.aparecida@gmail.com,
mwen@igalia.com, andrealmeid@riseup.net,
siqueirajordao@riseup.net, "Trevor Woerner" <twoerner@gmail.com>,
leandro.ribeiro@collabora.com, n@nfraprado.net,
"Daniel Vetter" <daniel@ffwll.ch>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"David Airlie" <airlied@linux.ie>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
michal.winiarski@intel.com,
"José Expósito" <jose.exposito89@gmail.com>,
"David Gow" <davidgow@google.com>,
"Daniel Latypov" <dlatypov@google.com>,
brendanhiggins@google.com
Cc: kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Arthur Grillo <arthur.grillo@usp.br>
Subject: Re: [PATCH v3 1/9] drm: selftest: convert drm_damage_helper selftest to KUnit
Date: Sat, 2 Jul 2022 13:32:52 +0200 [thread overview]
Message-ID: <ff375c95-96e9-6bcf-66ea-f70a44d0a5d1@redhat.com> (raw)
In-Reply-To: <20220630004611.114441-2-maira.canal@usp.br>
Hello Maíra,
Thanks a lot for your patch.
On 6/30/22 02:46, Maíra Canal wrote:
> Considering the current adoption of the KUnit framework, convert the
> DRM damage helper selftest to the KUnit API.
>
> Acked-by: Daniel Latypov <dlatypov@google.com>
> Tested-by: David Gow <davidgow@google.com>
> Co-developed-by: Arthur Grillo <arthur.grillo@usp.br>
> Signed-off-by: Arthur Grillo <arthur.grillo@usp.br>
> Signed-off-by: Maíra Canal <maira.canal@usp.br>
I believe the order of the tags should be chronological. That is, Daniel and
David tags should be after your Co-developed-by and Signed-off-by tags.
[...]
> +++ b/drivers/gpu/drm/tests/drm_damage_helper_test.c
> @@ -0,0 +1,634 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Test case for drm_damage_helper functions
> + */
> +
> +#include <kunit/test.h>
Please add a blank line here to separate non-DRM headers include from DRM headers.
> +#include <drm/drm_damage_helper.h>
> +#include <drm/drm_framebuffer.h>
> +#include <drm/drm_plane.h>
> +#include <drm/drm_drv.h>
> +
I haven't looked at the KUnits tests in detail since Daniel and David already
reviewed them. But from a quick glance, the tests look good to me as well.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-07-02 11:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 0:46 [PATCH v3 0/9] drm: selftest: Convert to KUnit Maíra Canal
2022-06-30 0:46 ` [PATCH v3 1/9] drm: selftest: convert drm_damage_helper selftest " Maíra Canal
2022-07-02 11:32 ` Javier Martinez Canillas [this message]
2022-06-30 0:46 ` [PATCH v3 2/9] drm: selftest: convert drm_cmdline_parser " Maíra Canal
2022-07-02 11:40 ` Javier Martinez Canillas
2022-06-30 0:46 ` [PATCH v3 3/9] drm: selftest: convert drm_rect " Maíra Canal
2022-07-02 11:41 ` Javier Martinez Canillas
2022-06-30 0:46 ` [PATCH v3 4/9] drm: selftest: convert drm_format " Maíra Canal
2022-07-02 11:43 ` Javier Martinez Canillas
2022-06-30 0:46 ` [PATCH v3 5/9] drm: selftest: convert drm_plane_helper " Maíra Canal
2022-07-02 11:48 ` Javier Martinez Canillas
2022-06-30 0:46 ` [PATCH v3 6/9] drm: selftest: convert drm_dp_mst_helper " Maíra Canal
2022-07-02 11:48 ` Javier Martinez Canillas
2022-06-30 0:46 ` [PATCH v3 7/9] drm: selftest: convert drm_framebuffer " Maíra Canal
2022-07-02 11:49 ` Javier Martinez Canillas
2022-06-30 0:46 ` [PATCH v3 8/9] drm: selftest: convert drm_buddy " Maíra Canal
2022-07-02 11:51 ` Javier Martinez Canillas
2022-06-30 0:46 ` [PATCH v3 9/9] drm: selftest: convert drm_mm " Maíra Canal
2022-07-02 11:51 ` Javier Martinez Canillas
2022-07-02 11:56 ` [PATCH v3 0/9] drm: selftest: Convert " Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff375c95-96e9-6bcf-66ea-f70a44d0a5d1@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=andrealmeid@riseup.net \
--cc=arthur.grillo@usp.br \
--cc=brendanhiggins@google.com \
--cc=daniel@ffwll.ch \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=isabbasso@riseup.net \
--cc=jose.exposito89@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=leandro.ribeiro@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=magalilemes00@gmail.com \
--cc=maira.canal@usp.br \
--cc=michal.winiarski@intel.com \
--cc=mripard@kernel.org \
--cc=mwen@igalia.com \
--cc=n@nfraprado.net \
--cc=siqueirajordao@riseup.net \
--cc=skhan@linuxfoundation.org \
--cc=tales.aparecida@gmail.com \
--cc=twoerner@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).