From: Shuah Khan <skhan@linuxfoundation.org>
To: Yonghong Song <yhs@fb.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: "open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Andrii Nakryiko <andriin@fb.com>,
"skh >> Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: Linux 5.4 - bpf test build fails
Date: Tue, 24 Sep 2019 09:48:35 -0600 [thread overview]
Message-ID: <05b7830c-1fa8-b613-0535-1f5f5a40a25a@linuxfoundation.org> (raw)
In-Reply-To: <0a5bf608-bb15-c116-8e58-7224b6c3b62f@fb.com>
On 9/24/19 9:43 AM, Yonghong Song wrote:
>
>
> On 9/24/19 8:26 AM, Shuah Khan wrote:
>> Hi Alexei and Daniel,
>>
>> bpf test doesn't build on Linux 5.4 mainline. Do you know what's
>> happening here.
>>
>>
>> make -C tools/testing/selftests/bpf/
>>
>> -c progs/test_core_reloc_ptr_as_arr.c -o - || echo "clang failed") | \
>> llc -march=bpf -mcpu=generic -filetype=obj -o
>> /mnt/data/lkml/linux_5.4/tools/testing/selftests/bpf/test_core_reloc_ptr_as_arr.o
>>
>> progs/test_core_reloc_ptr_as_arr.c:25:6: error: use of unknown builtin
>> '__builtin_preserve_access_index' [-Wimplicit-function-declaration]
>> if (BPF_CORE_READ(&out->a, &in[2].a))
>> ^
>> ./bpf_helpers.h:533:10: note: expanded from macro 'BPF_CORE_READ'
>> __builtin_preserve_access_index(src))
>> ^
>> progs/test_core_reloc_ptr_as_arr.c:25:6: warning: incompatible integer to
>> pointer conversion passing 'int' to parameter of type 'const void *'
>> [-Wint-conversion]
>> if (BPF_CORE_READ(&out->a, &in[2].a))
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> ./bpf_helpers.h:533:10: note: expanded from macro 'BPF_CORE_READ'
>> __builtin_preserve_access_index(src))
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> 1 warning and 1 error generated.
>> llc: error: llc: <stdin>:1:1: error: expected top-level entity
>> clang failed
>>
>> Also
>>
>> make TARGETS=bpf kselftest fails as well. Dependency between
>> tools/lib/bpf and the test. How can we avoid this type of
>> dependency or resolve it in a way it doesn't result in build
>> failures?
>
> Thanks, Shuah.
>
> The clang __builtin_preserve_access_index() intrinsic is
> introduced in LLVM9 (which just released last week) and
> the builtin and other CO-RE features are only supported
> in LLVM10 (current development branch) with more bug fixes
> and added features.
>
> I think we should do a feature test for llvm version and only
> enable these tests when llvm version >= 10.
Yes. If new tests depend on a particular llvm revision, the failing
the build is a regression. I would like to see older tests that don't
have dependency build and run.
thanks,
-- Shuah
next prev parent reply other threads:[~2019-09-24 15:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 15:26 Linux 5.4 - bpf test build fails Shuah Khan
2019-09-24 15:43 ` Yonghong Song
2019-09-24 15:48 ` Shuah Khan [this message]
2019-09-24 18:49 ` Daniel Borkmann
2019-09-24 18:56 ` Shuah Khan
2019-09-24 19:19 ` Daniel Borkmann
2019-09-24 19:48 ` Shuah Khan
2019-09-24 15:52 ` Cristian Marussi
2019-09-24 16:03 ` Shuah Khan
2019-09-24 16:39 ` Shuah Khan
2019-09-24 17:29 ` Cristian Marussi
2019-09-24 18:07 ` Tim.Bird
2019-09-24 18:23 ` Shuah Khan
2019-09-25 8:52 ` Cristian Marussi
[not found] <CAJ2QiJKZjc=rjx9CJigp9EuZ2f-2RV=_SBxV7S5g9q2zx-D+UQ@mail.gmail.com>
2019-10-16 10:35 ` Prabhakar Kushwaha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05b7830c-1fa8-b613-0535-1f5f5a40a25a@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andriin@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).