linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Naresh Kamboju <naresh.kamboju@linaro.org>, shuah@kernel.org
Cc: linux-kernel@vger.kernel.org, drjones@redhat.com,
	sean.j.christopherson@intel.com, linux-kselftest@vger.kernel.org,
	kvm@vger.kernel.org
Subject: Re: [PATCH v3 1/2] selftests: kvm: Adding config fragments
Date: Fri, 9 Aug 2019 09:39:26 +0200	[thread overview]
Message-ID: <0a0e0563-aba7-e59c-1fbd-547126d404ed@redhat.com> (raw)
In-Reply-To: <20190809072415.29305-1-naresh.kamboju@linaro.org>

On 09/08/19 09:24, Naresh Kamboju wrote:
> selftests kvm all test cases need pre-required kernel config for the
> tests to get pass.
> 
> CONFIG_KVM=y
> 
> The KVM tests are skipped without these configs:
> 
>         dev_fd = open(KVM_DEV_PATH, O_RDONLY);
>         if (dev_fd < 0)
>                 exit(KSFT_SKIP);
> 
> Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
> ---
>  tools/testing/selftests/kvm/config | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 tools/testing/selftests/kvm/config
> 
> diff --git a/tools/testing/selftests/kvm/config b/tools/testing/selftests/kvm/config
> new file mode 100644
> index 000000000000..14f90d8d6801
> --- /dev/null
> +++ b/tools/testing/selftests/kvm/config
> @@ -0,0 +1 @@
> +CONFIG_KVM=y
> 

I think this is more complicated without a real benefit, so I'll merge v2.

Paolo

  parent reply	other threads:[~2019-08-09  7:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09  7:24 [PATCH v3 1/2] selftests: kvm: Adding config fragments Naresh Kamboju
2019-08-09  7:24 ` [PATCH v3 2/2] selftests: kvm: x86_64: " Naresh Kamboju
2019-08-09  7:39 ` Paolo Bonzini [this message]
2019-08-09  7:53   ` [PATCH v3 1/2] selftests: kvm: " Naresh Kamboju
2019-08-09 10:18     ` Paolo Bonzini
2019-08-09 14:58       ` Naresh Kamboju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a0e0563-aba7-e59c-1fbd-547126d404ed@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=naresh.kamboju@linaro.org \
    --cc=sean.j.christopherson@intel.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).