From: Shuah Khan <skhan@linuxfoundation.org>
To: John Stultz <john.stultz@linaro.org>,
Po-Hsu Lin <po-hsu.lin@canonical.com>
Cc: linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
joe.lawrence@redhat.com, lkml <linux-kernel@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCHv3] selftests/timers: Turn off timeout setting
Date: Mon, 10 Aug 2020 14:48:33 -0600 [thread overview]
Message-ID: <0c635a95-0762-9026-edba-bcbf4835f42f@linuxfoundation.org> (raw)
In-Reply-To: <CALAqxLVyjj23S2Wm2XFAvCJph58_rVb4iteq3TFC14jYR_88Gw@mail.gmail.com>
On 8/4/20 3:38 PM, John Stultz wrote:
> On Tue, Mar 17, 2020 at 7:42 PM Po-Hsu Lin <po-hsu.lin@canonical.com> wrote:
>>
>> The following 4 tests in timers can take longer than the default 45
>> seconds that added in commit 852c8cbf34d3 ("selftests/kselftest/runner.sh:
>> Add 45 second timeout per test") to run:
>> * nsleep-lat - 2m7.350s
>> * set-timer-lat - 2m0.66s
>> * inconsistency-check - 1m45.074s
>> * raw_skew - 2m0.013s
>>
>> Thus they will be marked as failed with the current 45s setting:
>> not ok 3 selftests: timers: nsleep-lat # TIMEOUT
>> not ok 4 selftests: timers: set-timer-lat # TIMEOUT
>> not ok 6 selftests: timers: inconsistency-check # TIMEOUT
>> not ok 7 selftests: timers: raw_skew # TIMEOUT
>>
>> Disable the timeout setting for timers can make these tests finish
>> properly:
>> ok 3 selftests: timers: nsleep-lat
>> ok 4 selftests: timers: set-timer-lat
>> ok 6 selftests: timers: inconsistency-check
>> ok 7 selftests: timers: raw_skew
>>
>> https://bugs.launchpad.net/bugs/1864626
>> Fixes: 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout per test")
>> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
>> ---
>> tools/testing/selftests/timers/Makefile | 1 +
>> tools/testing/selftests/timers/settings | 1 +
>> 2 files changed, 2 insertions(+)
>> create mode 100644 tools/testing/selftests/timers/settings
>>
>> diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile
>> index 7656c7c..0e73a16 100644
>> --- a/tools/testing/selftests/timers/Makefile
>> +++ b/tools/testing/selftests/timers/Makefile
>> @@ -13,6 +13,7 @@ DESTRUCTIVE_TESTS = alarmtimer-suspend valid-adjtimex adjtick change_skew \
>>
>> TEST_GEN_PROGS_EXTENDED = $(DESTRUCTIVE_TESTS)
>>
>> +TEST_FILES := settings
>>
>> include ../lib.mk
>>
>> diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings
>> new file mode 100644
>> index 0000000..e7b9417
>> --- /dev/null
>> +++ b/tools/testing/selftests/timers/settings
>> @@ -0,0 +1 @@
>> +timeout=0
>> --
>
> Apologies for missing this before. I've not tested with this, but it
> sounds sane to me. A number of the timekeeping tests do take a while
> to run.
>
> Acked-by: John Stultz <john.stultz@linaro.org>
>
Thanks. I will get this in for 5.9-rc2 fixes update.
thanks,
-- Shuah
prev parent reply other threads:[~2020-08-10 20:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 2:42 [PATCHv3] selftests/timers: Turn off timeout setting Po-Hsu Lin
2020-07-23 9:01 ` Po-Hsu Lin
2020-08-04 21:21 ` Shuah Khan
2020-08-04 21:38 ` John Stultz
2020-08-10 20:48 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c635a95-0762-9026-edba-bcbf4835f42f@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=joe.lawrence@redhat.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=po-hsu.lin@canonical.com \
--cc=sboyd@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).