From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49550C3A59D for ; Wed, 21 Aug 2019 00:16:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 132FE22DA7 for ; Wed, 21 Aug 2019 00:16:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566346566; bh=2RuQs1F7tYgJBLvgQ6WridWiJhdHMgHseFYdpGdyqzs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=N+caDg0lLbCsKY3VGZI9yaI0kVQctJ66a/BZR7IgN4JfcPHZDB2MM6mcIqRLkk04/ Mg9SdhEC9AcMbXcYSxqltRqodgHLBwrQSNNkqoAaeJQ9l73Ew2FTRRAfoGWG1XEeNo MmeWPEruY8cHrlFd1HThBU8wVStFkYx3CHKDfaTM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726554AbfHUAQD (ORCPT ); Tue, 20 Aug 2019 20:16:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:53412 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726229AbfHUAQC (ORCPT ); Tue, 20 Aug 2019 20:16:02 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 116882087E; Wed, 21 Aug 2019 00:15:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566346560; bh=2RuQs1F7tYgJBLvgQ6WridWiJhdHMgHseFYdpGdyqzs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=h/9SOpCxtOLRs6g5m+cJNbJz0udbmW1GGoOmLXaQfek2wie52cFhxaDLPxrwyKa7t DXo/HvBBcOpNeAp5/4kk9R4eosaYHxiCJmSQZPYFG/r9HgeUIOSuGMLSresn8i9BPp XGM39t/6VU4uCPsIzFNwGZggfyYQ0w1m5Gkr9ny8= Subject: Re: [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework To: Brendan Higgins Cc: Frank Rowand , Greg KH , Josh Poimboeuf , Kees Cook , Kieran Bingham , Luis Chamberlain , Peter Zijlstra , Rob Herring , Stephen Boyd , Theodore Ts'o , Masahiro Yamada , devicetree , dri-devel , kunit-dev@googlegroups.com, "open list:DOCUMENTATION" , linux-fsdevel@vger.kernel.org, linux-kbuild , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , "Bird, Timothy" , Amir Goldstein , Dan Carpenter , Daniel Vetter , Jeff Dike , Joel Stanley , Julia Lawall , Kevin Hilman , Knut Omang , Logan Gunthorpe , Michael Ellerman , Petr Mladek , Randy Dunlap , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com, Bjorn Helgaas , shuah References: <20190814055108.214253-1-brendanhiggins@google.com> <5b880f49-0213-1a6e-9c9f-153e6ab91eeb@kernel.org> <20190820182450.GA38078@google.com> From: shuah Message-ID: <10e4190d-2a26-f51a-ba34-7afe8e640771@kernel.org> Date: Tue, 20 Aug 2019 18:15:57 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 8/20/19 5:23 PM, Brendan Higgins wrote: > On Tue, Aug 20, 2019 at 2:26 PM Brendan Higgins > wrote: >> >> On Tue, Aug 20, 2019 at 12:08 PM shuah wrote: >>> >>> On 8/20/19 12:24 PM, Brendan Higgins wrote: >>>> On Tue, Aug 20, 2019 at 11:24:45AM -0600, shuah wrote: >>>>> On 8/13/19 11:50 PM, Brendan Higgins wrote: >>>>>> ## TL;DR >>>>>> >>>>>> This revision addresses comments from Stephen and Bjorn Helgaas. Most >>>>>> changes are pretty minor stuff that doesn't affect the API in anyway. >>>>>> One significant change, however, is that I added support for freeing >>>>>> kunit_resource managed resources before the test case is finished via >>>>>> kunit_resource_destroy(). Additionally, Bjorn pointed out that I broke >>>>>> KUnit on certain configurations (like the default one for x86, whoops). >>>>>> >>>>>> Based on Stephen's feedback on the previous change, I think we are >>>>>> pretty close. I am not expecting any significant changes from here on >>>>>> out. >>>>>> >>>>> >>>>> Hi Brendan, >>>>> >>>>> I found checkpatch errors in one or two patches. Can you fix those and >>>>> send v14. >>>> >>>> Hi Shuah, >>>> >>>> Are you refering to the following errors? >>>> >>>> ERROR: Macros with complex values should be enclosed in parentheses >>>> #144: FILE: include/kunit/test.h:456: >>>> +#define KUNIT_BINARY_CLASS \ >>>> + kunit_binary_assert, KUNIT_INIT_BINARY_ASSERT_STRUCT >>>> >>>> ERROR: Macros with complex values should be enclosed in parentheses >>>> #146: FILE: include/kunit/test.h:458: >>>> +#define KUNIT_BINARY_PTR_CLASS \ >>>> + kunit_binary_ptr_assert, KUNIT_INIT_BINARY_PTR_ASSERT_STRUCT >>>> >>>> These values should *not* be in parentheses. I am guessing checkpatch is >>>> getting confused and thinks that these are complex expressions, when >>>> they are not. >>>> >>>> I ignored the errors since I figured checkpatch was complaining >>>> erroneously. >>>> >>>> I could refactor the code to remove these macros entirely, but I think >>>> the code is cleaner with them. >>>> >>> >>> Please do. I am not veru sure what value these macros add. >> >> Alright, I will have something for you later today. > > I just sent a new revision with the fix. > > Cheers > Thanks Brendan. I will get them in. -- Shuah