From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C448C3F2D7 for ; Wed, 4 Mar 2020 23:15:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 442CD20870 for ; Wed, 4 Mar 2020 23:15:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583363744; bh=dZaoSwKBx/t67wOLGqICu1GPOu6Nbpsnkqt1hx+hyOY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=UcKVEQVmIOPPT9wx7BdpR0G6uTgr+NWLC7WjjAO2G+S2o7IX2FV5p8W5iVhE3oN52 sTM2hTCXdVjDk0YL5CIzLfokEDVUxG9+X1AsxXTHGk2gvBSGybwl7IZYUdOcftw0FN U6tk5Vr+Sv3ucNovpXwZpnGShY7hzML5YWvK0Y1Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388371AbgCDXPn (ORCPT ); Wed, 4 Mar 2020 18:15:43 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:44946 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388425AbgCDXPk (ORCPT ); Wed, 4 Mar 2020 18:15:40 -0500 Received: by mail-io1-f66.google.com with SMTP id u17so4340584iog.11 for ; Wed, 04 Mar 2020 15:15:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qnZSwAco/9yGR/2Rk04lTIem1NQkAqUXaZjX8c167Hs=; b=PsHjmeO7PXK1y43SbWXSqitm0T7GjrEaE3aOc4VjlDXTiEUoIifBDtonvjPNfMa8NP COoFK7dpmzQoxB5Ulbg61zCMdxgVzTE/MATvSVpE9Ix4p2zUC7ugmhlCKNm+dpUVEd7y aoDKxbZS2CDeSLEO0pHaRDMiFg60KJV94Rd7U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qnZSwAco/9yGR/2Rk04lTIem1NQkAqUXaZjX8c167Hs=; b=kNPlnIAjnaCXjFqIAXkuhJ03gNcb8zEuU6J4zcJ7dA1Anwf7LFUBlcLw17RuYZL7wV IpbEazxPQWihJ8m39m98PNt/8+RGb4o2O3vFdqu6sk/kU1KW/Xa9MBulZFwHs/SsxR9f WUF8l5+pHYgX8dAdtjGeSMehDy7WqQQEJDis4XY0yeLgyAt/Qn0oOST78OXfrZZFSg6B 6OHZO2KQunPyqUJYa3ETbtOjWZcac/pSqqkFZRWNUl8yxlfnBKaBs6jlhN4cCr8GnKki 6G3Bs427a2Ffb0HwZcDFUx7kTQCU/ToTgtPK7AQnnCIWRLI5d9vCa3zPrNkVQ4I+xaXQ rMgw== X-Gm-Message-State: ANhLgQ1xLqVOIcD6qAcMqpZmj/LmXilGWXeh4i1wbsGmwzGCPyIWie2s PcZGK+PC2y+emB/Qi7CFJz8WoA== X-Google-Smtp-Source: ADFU+vuixjh4NH+5iUMDbrsEt1WSbtzQ1aWggmcxwIHK3oaMulCmtb7CWoIrlP5jRRnEdh/VXGUMlg== X-Received: by 2002:a6b:bd04:: with SMTP id n4mr4147979iof.196.1583363739362; Wed, 04 Mar 2020 15:15:39 -0800 (PST) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id m18sm8782876ill.79.2020.03.04.15.15.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2020 15:15:38 -0800 (PST) Subject: Re: [PATCH 2/4] selftests: Fix seccomp to support relocatable build (O=objdir) To: Kees Cook Cc: shuah@kernel.org, luto@amacapital.net, wad@chromium.org, daniel@iogearbox.net, kafai@fb.com, yhs@fb.com, andriin@fb.com, gregkh@linuxfoundation.org, tglx@linutronix.de, khilman@baylibre.com, mpe@ellerman.id.au, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Shuah Khan References: <11967e5f164f0cd717921bd382ff9c13ef740146.1583358715.git.skhan@linuxfoundation.org> <202003041442.A46000C@keescook> From: Shuah Khan Message-ID: <11ffe43f-f777-7881-623d-c93196a44cb6@linuxfoundation.org> Date: Wed, 4 Mar 2020 16:15:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <202003041442.A46000C@keescook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 3/4/20 3:42 PM, Kees Cook wrote: > On Wed, Mar 04, 2020 at 03:13:33PM -0700, Shuah Khan wrote: >> Fix seccomp relocatable builds. This is a simple fix to use the >> right lib.mk variable TEST_GEN_PROGS for objects to leverage >> lib.mk common framework for relocatable builds. >> >> Signed-off-by: Shuah Khan >> --- >> tools/testing/selftests/seccomp/Makefile | 16 +++------------- >> 1 file changed, 3 insertions(+), 13 deletions(-) >> >> diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile >> index 1760b3e39730..a8a9717fc1be 100644 >> --- a/tools/testing/selftests/seccomp/Makefile >> +++ b/tools/testing/selftests/seccomp/Makefile >> @@ -1,17 +1,7 @@ >> # SPDX-License-Identifier: GPL-2.0 >> -all: >> - >> -include ../lib.mk >> - >> -.PHONY: all clean >> - >> -BINARIES := seccomp_bpf seccomp_benchmark >> CFLAGS += -Wl,-no-as-needed -Wall >> +LDFLAGS += -lpthread >> >> -seccomp_bpf: seccomp_bpf.c ../kselftest_harness.h > > How is the ../kselftest_harness.h dependency detected in the resulting > build rules? > > Otherwise, looks good. Didn't see any problems. I will look into adding the dependency. thanks, -- Shuah