Linux-kselftest Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] Documentation: kunit: fix Sphinx directive warning
@ 2020-02-10  3:31 Randy Dunlap
  2020-02-10 17:45 ` Brendan Higgins
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2020-02-10  3:31 UTC (permalink / raw)
  To: LKML, open list:KERNEL SELFTEST FRAMEWORK, KUnit Development
  Cc: Brendan Higgins, Shuah Khan, Alan Maguire, Knut Omang

From: Randy Dunlap <rdunlap@infradead.org>

Fix Documentation warning due to missing a blank line after a directive:

linux/Documentation/dev-tools/kunit/usage.rst:553: WARNING: Error in "code-block" directive:
maximum 1 argument(s) allowed, 3 supplied.
.. code-block:: bash
        modprobe example-test

Fixes: 6ae2bfd3df06 ("kunit: update documentation to describe module-based build")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Alan Maguire <alan.maguire@oracle.com>
Cc: Knut Omang <knut.omang@oracle.com>
Cc: Brendan Higgins <brendanhiggins@google.com>
Cc: linux-kselftest@vger.kernel.org
Cc: kunit-dev@googlegroups.com
Cc: Shuah Khan <skhan@linuxfoundation.org>
---
 Documentation/dev-tools/kunit/usage.rst |    1 +
 1 file changed, 1 insertion(+)

--- lnx-56-rc1.orig/Documentation/dev-tools/kunit/usage.rst
+++ lnx-56-rc1/Documentation/dev-tools/kunit/usage.rst
@@ -551,6 +551,7 @@ options to your ``.config``:
 Once the kernel is built and installed, a simple
 
 .. code-block:: bash
+
 	modprobe example-test
 
 ...will run the tests.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Documentation: kunit: fix Sphinx directive warning
  2020-02-10  3:31 [PATCH] Documentation: kunit: fix Sphinx directive warning Randy Dunlap
@ 2020-02-10 17:45 ` Brendan Higgins
  2020-02-10 20:56   ` Shuah Khan
  0 siblings, 1 reply; 3+ messages in thread
From: Brendan Higgins @ 2020-02-10 17:45 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: LKML, open list:KERNEL SELFTEST FRAMEWORK, KUnit Development,
	Shuah Khan, Alan Maguire, Knut Omang

On Sun, Feb 9, 2020 at 7:31 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix Documentation warning due to missing a blank line after a directive:
>
> linux/Documentation/dev-tools/kunit/usage.rst:553: WARNING: Error in "code-block" directive:
> maximum 1 argument(s) allowed, 3 supplied.
> .. code-block:: bash
>         modprobe example-test

Uh oh, sorry for wasting your time, but it looks like I already sent
the exact same patch out already:

https://patchwork.kernel.org/patch/11360711/

Shuah, can you pick one of these up and send it out in the next rc?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Documentation: kunit: fix Sphinx directive warning
  2020-02-10 17:45 ` Brendan Higgins
@ 2020-02-10 20:56   ` Shuah Khan
  0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2020-02-10 20:56 UTC (permalink / raw)
  To: Brendan Higgins, Randy Dunlap
  Cc: LKML, open list:KERNEL SELFTEST FRAMEWORK, KUnit Development,
	Alan Maguire, Knut Omang, skh >> Shuah Khan

On 2/10/20 10:45 AM, Brendan Higgins wrote:
> On Sun, Feb 9, 2020 at 7:31 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix Documentation warning due to missing a blank line after a directive:
>>
>> linux/Documentation/dev-tools/kunit/usage.rst:553: WARNING: Error in "code-block" directive:
>> maximum 1 argument(s) allowed, 3 supplied.
>> .. code-block:: bash
>>          modprobe example-test
> 
> Uh oh, sorry for wasting your time, but it looks like I already sent
> the exact same patch out already:
> 
> https://patchwork.kernel.org/patch/11360711/
> 
> Shuah, can you pick one of these up and send it out in the next rc?
> 

Thanks for the patches. I will take the first one in the queue which
is yours Brendan!

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-10  3:31 [PATCH] Documentation: kunit: fix Sphinx directive warning Randy Dunlap
2020-02-10 17:45 ` Brendan Higgins
2020-02-10 20:56   ` Shuah Khan

Linux-kselftest Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \
		linux-kselftest@vger.kernel.org
	public-inbox-index linux-kselftest

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git