Re: [PATCH] sefltest/ima: support appended signatures (modsig)

From: Mimi Zohar <zohar@linux.ibm.com>
To: shuah <shuah@kernel.org>, linux-integrity@vger.kernel.org
Cc: Thiago Jung Bauermann <bauerman@linux.ibm.com>,
	Petr Vorel <pvorel@suse.cz>, Jessica Yu <jeyu@kernel.org>,
	Dave Young <dyoung@redhat.com>,
	linux-kselftest@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sefltest/ima: support appended signatures (modsig)
Date: Wed, 28 Aug 2019 11:19:58 -0400	[thread overview]
Message-ID: <1567005598.6115.40.camel@linux.ibm.com> (raw)
In-Reply-To: <2f89d09f-1b69-3d77-6846-01bef7d20f39@kernel.org>

On Wed, 2019-08-28 at 08:45 -0600, shuah wrote:
> Hi Mimi,
> 
> On 8/28/19 6:39 AM, Mimi Zohar wrote:
> > Detect and allow appended signatures.
> > 
> 
> Can you please add a couple of more sentences on the feature
> and what happens without it? I know this is a test for the
> feature, however, it will be useful for users and testers to
> know more about this test and the feature it is testing.

I've updated the patch description as requested.  

> Also, are there test skip conditions to be concerned about?

The kexec selftests tests the coordination of the different methods of
verifying the kexec kernel image.  As the appended signature support
is part of IMA, there is no new skip conditions.

> Is there a dependency on another tree or would like me to take
> this through kselftest tree?

I would prefer upstreaming this test with the rest of IMA support for
appended signatures.

thanks,

Mimi