From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97763C432C0 for ; Mon, 25 Nov 2019 06:57:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D65220823 for ; Mon, 25 Nov 2019 06:57:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574665025; bh=dgmbdVph82qN1wa16cF6s2yHXttZdvsFBY+an8U/Rxc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RT/g7qFoQraYs5G7ZnrxGMMdbtNVqjov1oH4Ee3hdGLHGrEjpEp3byA6v6UkclT+c dGQrakEIuMjbB7J3a+HrkoqxYT0iROJNItKOE5VEDy7TBGaoQO0tjYNU+Cf6L4kDMy sx9N+cKNJMfdVqSuN+fNwYXGm/EKsCuhqFsT+VTE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727085AbfKYG5F (ORCPT ); Mon, 25 Nov 2019 01:57:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:60774 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725535AbfKYG5E (ORCPT ); Mon, 25 Nov 2019 01:57:04 -0500 Received: from localhost.localdomain (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A80120815; Mon, 25 Nov 2019 06:57:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574665024; bh=dgmbdVph82qN1wa16cF6s2yHXttZdvsFBY+an8U/Rxc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D+dAQjJcaFklVxATGpUw+HZd5eyyApBlQfsuIwSEBStw/YwUsuvWSGFKskl/dTDjQ 7zwJpCj47szY/fBjrwh/JPl4wLh8MBEu3JPj663fGff1Tr6g/wJKgPzzxa/lzQao9h lkkP2uyc9FI/yWQIiHGTiXSupukfmg14BMl8oGVU= From: Masami Hiramatsu To: Shuah Khan , Steven Rostedt Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [BUGFIX PATCH v3 1/4] selftests/ftrace: Fix to check the existence of set_ftrace_filter Date: Mon, 25 Nov 2019 15:57:00 +0900 Message-Id: <157466502067.21973.8795718044691377192.stgit@devnote2> X-Mailer: git-send-email 2.20.1 In-Reply-To: <157466501169.21973.31401747181477687.stgit@devnote2> References: <157466501169.21973.31401747181477687.stgit@devnote2> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org If we run ftracetest on the kernel with CONFIG_DYNAMIC_FTRACE=n, there is no set_ftrace_filter and all test cases are failed, because reset_ftrace_filter returns an error. Let's check whether set_ftrace_filter exists and remove redundant set_ftrace_filter from initialize_ftrace(). Signed-off-by: Masami Hiramatsu --- tools/testing/selftests/ftrace/test.d/functions | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/ftrace/test.d/functions b/tools/testing/selftests/ftrace/test.d/functions index 86986c4bba54..19d288cdf336 100644 --- a/tools/testing/selftests/ftrace/test.d/functions +++ b/tools/testing/selftests/ftrace/test.d/functions @@ -46,6 +46,9 @@ reset_events_filter() { # reset all current setting filters } reset_ftrace_filter() { # reset all triggers in set_ftrace_filter + if [ ! -f set_ftrace_filter ]; then + return 0 + fi echo > set_ftrace_filter grep -v '^#' set_ftrace_filter | while read t; do tr=`echo $t | cut -d: -f2` @@ -93,7 +96,6 @@ initialize_ftrace() { # Reset ftrace to initial-state disable_events [ -f set_event_pid ] && echo > set_event_pid [ -f set_ftrace_pid ] && echo > set_ftrace_pid - [ -f set_ftrace_filter ] && echo | tee set_ftrace_* [ -f set_graph_function ] && echo | tee set_graph_* [ -f stack_trace_filter ] && echo > stack_trace_filter [ -f kprobe_events ] && echo > kprobe_events