From: SeongJae Park <sj38.park@gmail.com> To: brendanhiggins@google.com Cc: corbet@lwn.net, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org, sj38.park@gmail.com, sjpark@amazon.de Subject: [PATCH v3 4/5] kunit: Place 'test.log' under the 'build_dir' Date: Wed, 4 Dec 2019 03:08:27 +0900 Message-ID: <1575396508-21480-5-git-send-email-sj38.park@gmail.com> (raw) In-Reply-To: <1575396508-21480-1-git-send-email-sj38.park@gmail.com> From: SeongJae Park <sjpark@amazon.de> 'kunit' writes the 'test.log' under the kernel source directory even though a 'build_dir' option is given. As users who use the option might expect the outputs to be placed under the specified directory, this commit modifies the logic to write the log file under the 'build_dir'. Signed-off-by: SeongJae Park <sjpark@amazon.de> Reviewed-by: Brendan Higgins <brendanhiggins@google.com> --- tools/testing/kunit/kunit_kernel.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/kunit/kunit_kernel.py b/tools/testing/kunit/kunit_kernel.py index c04a12e..5bec97e 100644 --- a/tools/testing/kunit/kunit_kernel.py +++ b/tools/testing/kunit/kunit_kernel.py @@ -143,7 +143,7 @@ class LinuxSourceTree(object): def run_kernel(self, args=[], timeout=None, build_dir=None): args.extend(['mem=256M']) process = self._ops.linux_bin(args, timeout, build_dir) - with open('test.log', 'w') as f: + with open(os.path.join(build_dir, 'test.log'), 'w') as f: for line in process.stdout: f.write(line.rstrip().decode('ascii') + '\n') yield line.rstrip().decode('ascii') -- 2.7.4
next prev parent reply index Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-03 18:08 [PATCH v3 0/5] Fix nits in the kunit SeongJae Park 2019-12-03 18:08 ` [PATCH v3 1/5] docs/kunit/start: Use in-tree 'kunit_defconfig' SeongJae Park 2019-12-03 18:08 ` [PATCH v3 2/5] kunit: Remove duplicated defconfig creation SeongJae Park 2019-12-03 18:08 ` [PATCH v3 3/5] kunit: Create default config in '--build_dir' SeongJae Park 2019-12-03 22:39 ` Brendan Higgins 2019-12-03 18:08 ` SeongJae Park [this message] 2019-12-03 18:08 ` [PATCH v3 5/5] kunit: Rename 'kunitconfig' to '.kunitconfig' SeongJae Park 2019-12-03 22:41 ` [PATCH v3 0/5] Fix nits in the kunit Brendan Higgins 2019-12-04 19:21 ` Brendan Higgins 2019-12-04 20:25 ` SeongJae Park 2019-12-04 20:28 ` SeongJae Park 2019-12-05 9:44 ` sjpark
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1575396508-21480-5-git-send-email-sj38.park@gmail.com \ --to=sj38.park@gmail.com \ --cc=brendanhiggins@google.com \ --cc=corbet@lwn.net \ --cc=kunit-dev@googlegroups.com \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=shuah@kernel.org \ --cc=sjpark@amazon.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-kselftest Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \ linux-kselftest@vger.kernel.org public-inbox-index linux-kselftest Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest AGPL code for this site: git clone https://public-inbox.org/public-inbox.git