From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5C03C433B4 for ; Fri, 2 Apr 2021 17:53:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA0BD6112E for ; Fri, 2 Apr 2021 17:53:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235151AbhDBRxG (ORCPT ); Fri, 2 Apr 2021 13:53:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234275AbhDBRxG (ORCPT ); Fri, 2 Apr 2021 13:53:06 -0400 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 071B5C0613E6 for ; Fri, 2 Apr 2021 10:53:05 -0700 (PDT) Received: by mail-io1-xd30.google.com with SMTP id z3so3308396ioc.8 for ; Fri, 02 Apr 2021 10:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=whRXq76gjLJkPVfSKotV9dDdRpnCQB8vQShEk4qBurw=; b=F6SYbw6faTLWfI73meZgPfreP/nqSXtNQdx6iM1rVNVXrfabL9IhrVJ4FEOEYh60n0 F9G4345qX6aHJLhkwVqs/kHbWZaPG7iyykKqgO3E8BBog5ljCjILCfRpcgaU7M+F8sy/ UtWs5D2FQVzAGJG+mNgMPimOstbPg4rdg3T8I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=whRXq76gjLJkPVfSKotV9dDdRpnCQB8vQShEk4qBurw=; b=GTNSPmxQo2WMFJTzBDj6xbxc+f/yHmwwwWgvxxJ4xIgxCj09pykyI1KlRki3sK1APt Q0CTPBeV9UrrHRzrv+6quw67G5UwmuYtTIaKAgOdMSJTins4InX+HHXJ1CSGPRiYmbVw v6ftZj74H3kDn4fY9OQVXYa3GCAz7Sj0iwi5zY2h+fSr27GNdfed0GVuhus/iw8yzVtO aiSfJ5xnURogOATcJMXZeAAn0APhiqQr57apzNSfkqaUdkfl6jDmMVgi7HUy1+LV4Ktj lahYyu0sz4AZGmoO3jv275htk7b+2UK2QOUSrYB43eDxMRXLDloteuc7dPRfsRqnaKKM jM+A== X-Gm-Message-State: AOAM533SANEWGs4+koUVqXJnTovRLSRVYfyMzd7XxCV+w56BjMh4vQ4W GcuN4cvlyQKrnB+9J3nBzq+2wyippe6WRw== X-Google-Smtp-Source: ABdhPJz1r1Ceyj+k6UwLlZGeWclgyMNhnV+pTsYoP1H/9iIhgVpTVY30rKYBtvBnCi89ACrcNGW83g== X-Received: by 2002:a5e:980e:: with SMTP id s14mr12260386ioj.63.1617385984539; Fri, 02 Apr 2021 10:53:04 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id b9sm4848319iob.4.2021.04.02.10.53.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Apr 2021 10:53:04 -0700 (PDT) Subject: Re: [PATCH v4 1/2] kunit: support failure from dynamic analysis tools To: Brendan Higgins , Daniel Latypov Cc: David Gow , Alan Maguire , Linux Kernel Mailing List , KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Uriel Guajardo , Shuah Khan References: <20210311152314.3814916-1-dlatypov@google.com> <20210311152314.3814916-2-dlatypov@google.com> From: Shuah Khan Message-ID: <16fe1cc0-5819-986d-9065-433a80783edb@linuxfoundation.org> Date: Fri, 2 Apr 2021 11:53:03 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 4/2/21 2:55 AM, Brendan Higgins wrote: > On Thu, Mar 11, 2021 at 7:23 AM Daniel Latypov wrote: >> >> From: Uriel Guajardo >> >> Add a kunit_fail_current_test() function to fail the currently running >> test, if any, with an error message. >> >> This is largely intended for dynamic analysis tools like UBSAN and for >> fakes. >> E.g. say I had a fake ops struct for testing and I wanted my `free` >> function to complain if it was called with an invalid argument, or >> caught a double-free. Most return void and have no normal means of >> signalling failure (e.g. super_operations, iommu_ops, etc.). >> >> Key points: >> * Always update current->kunit_test so anyone can use it. >> * commit 83c4e7a0363b ("KUnit: KASAN Integration") only updated it for >> CONFIG_KASAN=y >> >> * Create a new header so non-test code doesn't have >> to include all of (e.g. lib/ubsan.c) >> >> * Forward the file and line number to make it easier to track down >> failures >> >> * Declare the helper function for nice __printf() warnings about mismatched >> format strings even when KUnit is not enabled. >> >> Example output from kunit_fail_current_test("message"): >> [15:19:34] [FAILED] example_simple_test >> [15:19:34] # example_simple_test: initializing >> [15:19:34] # example_simple_test: lib/kunit/kunit-example-test.c:24: message >> [15:19:34] not ok 1 - example_simple_test >> >> Co-developed-by: Daniel Latypov >> Signed-off-by: Daniel Latypov >> Signed-off-by: Uriel Guajardo >> Reviewed-by: Alan Maguire > > Reviewed-by: Brendan Higgins > Please run checkpatch on your patches in the future. I am seeing a few checkpatch readability type improvements that can be made. Please make changes and send v2 with Brendan's Reviewed-by. thanks, -- Shuah