From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5158DC11F68 for ; Fri, 2 Jul 2021 14:48:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39D90613E1 for ; Fri, 2 Jul 2021 14:48:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231927AbhGBOvI (ORCPT ); Fri, 2 Jul 2021 10:51:08 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:36469 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232381AbhGBOvH (ORCPT ); Fri, 2 Jul 2021 10:51:07 -0400 Received: from mail-ej1-f69.google.com ([209.85.218.69]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lzKT5-0002z3-16 for linux-kselftest@vger.kernel.org; Fri, 02 Jul 2021 14:48:35 +0000 Received: by mail-ej1-f69.google.com with SMTP id gz14-20020a170907a04eb02904d8b261b40bso210473ejc.4 for ; Fri, 02 Jul 2021 07:48:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=E3fm4PSTtOv+VeUKIOpm5uwdfF3VUPJyTCLKCZ6r/jg=; b=KbH9kRYAHKLZhcXq/ENRoHJaAvhks4IcOCNC3jaJKHZCyw+i27ahTcx8qfGehqkwL5 DCj3D1d6JY9Bp1yPYjGwSyXEiXEW+6VhFUsadbcDRUDze6/Raij8r8LUwMmBY9Q2E7nb oLE+w2EkOiMGmcgoYOxYUto9HnOp7Q+vXhyL7JuzD0e14FuurGJo3dLKWJI0MFePmT0n 488iZYMpgBRpY990FETDO54MvcLLrR6NmIjGeYeS2pBUp9PEdj4LMynseKEpk3TlvYiQ 0SZIZmoWThuEW91rvL2wl6nwlEXaDy+junm1DN9KcdQrmuySsxGYNlyt/ooccv2w0SPE PhQw== X-Gm-Message-State: AOAM530q/97T0KIpdyCLhrHGo6Rpw2gRFdqgKAKFmVnVkso7fn4CwkXq b9f7qIDKpNBVNveAZ9n8WhcWVb0sl5US/NeoPmF4bZ8blfg2o4UK7X6mxipsspblAYqH++6EW4N zbE6BGLNRDofI7qvDWvww0gMqqKHQPn3ibQMhRjBv9M+Fjg== X-Received: by 2002:a17:907:3faa:: with SMTP id hr42mr60774ejc.129.1625237313610; Fri, 02 Jul 2021 07:48:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1rEKL5Sk3ceYHgC0DEX16Oa7GmwYVxNFSfGc1NYAIUVgHauj+BPRu6HmN+WHkoay4zgEsQg== X-Received: by 2002:a17:907:3faa:: with SMTP id hr42mr60765ejc.129.1625237313487; Fri, 02 Jul 2021 07:48:33 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-177-222.adslplus.ch. [188.155.177.222]) by smtp.gmail.com with ESMTPSA id k21sm1438873edr.90.2021.07.02.07.48.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jul 2021 07:48:32 -0700 (PDT) Subject: Re: [PATCH] selftests: memory-hotplug: avoid spamming logs with dump_page(), ratio limit hot-remove error test To: Paolo Pisati , Shuah Khan Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210630145740.54614-1-paolo.pisati@canonical.com> From: Krzysztof Kozlowski Message-ID: <1881c379-d752-6850-1a1a-fd217eb4a661@canonical.com> Date: Fri, 2 Jul 2021 16:48:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210630145740.54614-1-paolo.pisati@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 30/06/2021 16:57, Paolo Pisati wrote: > While the offline memory test obey ratio limit, the same test with error > injection does not and tries to offline all the hotpluggable memory, spamming > system logs with hundreds of thousands of dump_page() entries, slowing system > down (to the point the test itself timeout and gets terminated) and excessive fs > occupation: > > ... > [ 9784.393354] page:c00c0000007d1b40 refcount:3 mapcount:0 mapping:c0000001fc03e950 index:0xe7b > [ 9784.393355] def_blk_aops > [ 9784.393356] flags: 0x3ffff800002062(referenced|active|workingset|private) > [ 9784.393358] raw: 003ffff800002062 c0000001b9343a68 c0000001b9343a68 c0000001fc03e950 > [ 9784.393359] raw: 0000000000000e7b c000000006607b18 00000003ffffffff c00000000490d000 > [ 9784.393359] page dumped because: migration failure > [ 9784.393360] page->mem_cgroup:c00000000490d000 > [ 9784.393416] migrating pfn 1f46d failed ret:1 > ... > > $ grep "page dumped because: migration failure" /var/log/kern.log | wc -l > 2405558 > > $ ls -la /var/log/kern.log > -rw-r----- 1 syslog adm 2256109539 Jun 30 14:19 /var/log/kern.log Makes sense to me and looks better choice than to disable the test completely (as other choice...). Acked-by: Krzysztof Kozlowski > > Signed-off-by: Paolo Pisati > --- > tools/testing/selftests/memory-hotplug/mem-on-off-test.sh | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Best regards, Krzysztof