From: Paolo Bonzini <pbonzini@redhat.com>
To: Krish Sadhukhan <krish.sadhukhan@oracle.com>,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
kvm@vger.kernel.org
Cc: drjones@redhat.com, sean.j.christopherson@intel.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 1/1] selftests: kvm: Add overlapped memory regions test
Date: Thu, 16 Apr 2020 15:53:36 +0200 [thread overview]
Message-ID: <1d05b77b-1e8b-2dfd-cbc9-5b09b685b630@redhat.com> (raw)
In-Reply-To: <455a01b6-506b-3c16-7ad8-327ad63292e9@oracle.com>
On 16/04/20 01:57, Krish Sadhukhan wrote:
>
>> Add the test_overlap_memory_regions() test case in
>> set_memory_region_test. This should check that overlapping
>> memory regions on the guest physical address cannot be added.
>
>
> I think the commit header and the body need some improvement. For example,
>
> Header: Test that overlapping guest memory regions can not be added
>
> Body: Enhance the existing tests in set_memory_region_test.c so
> that it tests overlapping guest
>
> memory regions. The new test verifies that adding
> overlapping guest memory regions fails.
I like Wainer's header and your body. :)
Paolo
prev parent reply other threads:[~2020-04-16 13:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 20:45 [PATCH 0/1] selftests: kvm: Overlapped memory regions test Wainer dos Santos Moschetta
2020-04-15 20:45 ` [PATCH 1/1] selftests: kvm: Add overlapped " Wainer dos Santos Moschetta
2020-04-15 23:57 ` Krish Sadhukhan
2020-04-16 13:53 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d05b77b-1e8b-2dfd-cbc9-5b09b685b630@redhat.com \
--to=pbonzini@redhat.com \
--cc=drjones@redhat.com \
--cc=krish.sadhukhan@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).