From mboxrd@z Thu Jan  1 00:00:00 1970
From: mhiramat at kernel.org (Masami Hiramatsu)
Date: Mon, 26 Mar 2018 12:53:38 +0900
Subject: [PATCH v6 21/21] perf-probe: Add array argument support
In-Reply-To: <8b3ad72c-f28c-8fc0-32b8-4401dbe16358@linux.vnet.ibm.com>
References: <152129024033.31874.15800253385376959274.stgit@devbox>
 <152129118998.31874.16273532808298489908.stgit@devbox>
 <8c02c538-4934-59c2-7795-9058ce57e625@linux.vnet.ibm.com>
 <20180322182347.ca1aab9b77ab4c351100646b@kernel.org>
 <8b3ad72c-f28c-8fc0-32b8-4401dbe16358@linux.vnet.ibm.com>
Message-ID: <20180326125338.16f9eeead34feeb86114ee39@kernel.org>

On Thu, 22 Mar 2018 16:19:46 +0530
Ravi Bangoria <ravi.bangoria at linux.vnet.ibm.com> wrote:

> Hi Masami :)
> 
> On 03/22/2018 03:53 PM, Masami Hiramatsu wrote:
> > On Mon, 19 Mar 2018 13:29:59 +0530
> > Ravi Bangoria <ravi.bangoria at linux.vnet.ibm.com> wrote:
> >
> >>
> >> Is it okay to allow user to specify array size with type field?
> > Fro this patch, yes.
> 
> So IIUC, perf _tool_ will allow user to record array either with "name[range]"
> or by "name:type[length]". Please correct me if that's wrong.

Yes, it is correct.

> And If perf tool will allow array length along with TYPE field, I guess we should
> document that in man perf-probe?

Ah, right. OK, I'll add it.

Thanks!

> 
> Otherwise,
> 
> Acked-by: Ravi Bangoria <ravi.bangoria at linux.vnet.ibm.com>
> 
> Thanks,
> Ravi
> 
> >  The availability of type is checked only when
> > it is automatically generated.
> > IMO, it should be done in another patch, something like
> > "Validate user specified type casting" patch. Would you need it?
> >
> > Thank you,
> >
> 


-- 
Masami Hiramatsu <mhiramat at kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

From mboxrd@z Thu Jan  1 00:00:00 1970
From: mhiramat@kernel.org (Masami Hiramatsu)
Date: Mon, 26 Mar 2018 12:53:38 +0900
Subject: [PATCH v6 21/21] perf-probe: Add array argument support
In-Reply-To: <8b3ad72c-f28c-8fc0-32b8-4401dbe16358@linux.vnet.ibm.com>
References: <152129024033.31874.15800253385376959274.stgit@devbox>
 <152129118998.31874.16273532808298489908.stgit@devbox>
 <8c02c538-4934-59c2-7795-9058ce57e625@linux.vnet.ibm.com>
 <20180322182347.ca1aab9b77ab4c351100646b@kernel.org>
 <8b3ad72c-f28c-8fc0-32b8-4401dbe16358@linux.vnet.ibm.com>
Message-ID: <20180326125338.16f9eeead34feeb86114ee39@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <20180326035338.nJjk1GIfv6oclv7eELu2UGYKzHR5W0ah53PjUya6Us8@z>

On Thu, 22 Mar 2018 16:19:46 +0530
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:

> Hi Masami :)
> 
> On 03/22/2018 03:53 PM, Masami Hiramatsu wrote:
> > On Mon, 19 Mar 2018 13:29:59 +0530
> > Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:
> >
> >>
> >> Is it okay to allow user to specify array size with type field?
> > Fro this patch, yes.
> 
> So IIUC, perf _tool_ will allow user to record array either with "name[range]"
> or by "name:type[length]". Please correct me if that's wrong.

Yes, it is correct.

> And If perf tool will allow array length along with TYPE field, I guess we should
> document that in man perf-probe?

Ah, right. OK, I'll add it.

Thanks!

> 
> Otherwise,
> 
> Acked-by: Ravi Bangoria <ravi.bangoria at linux.vnet.ibm.com>
> 
> Thanks,
> Ravi
> 
> >  The availability of type is checked only when
> > it is automatically generated.
> > IMO, it should be done in another patch, something like
> > "Validate user specified type casting" patch. Would you need it?
> >
> > Thank you,
> >
> 


-- 
Masami Hiramatsu <mhiramat at kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html