From mboxrd@z Thu Jan 1 00:00:00 1970 From: mbenes@suse.cz (Miroslav Benes) Date: Fri, 13 Apr 2018 13:20:40 +0200 (CEST) Subject: [PATCH v3] selftests/livepatch: introduce tests In-Reply-To: <1523544871-29444-2-git-send-email-joe.lawrence@redhat.com> References: <1523544871-29444-1-git-send-email-joe.lawrence@redhat.com> <1523544871-29444-2-git-send-email-joe.lawrence@redhat.com> Message-ID: Content-Type: text/plain; charset="UTF-8" Message-ID: <20180413112040.hd0YYO7eVupQWbNnoIiqS-mPTh2GkLnWRUYD6m9R8-4@z> Hi, On Thu, 12 Apr 2018, Joe Lawrence wrote: > Add a few livepatch modules and simple target modules that the included > regression suite can run tests against. Could you include a brief description which features are tested? > Signed-off-by: Joe Lawrence > --- > diff --git a/lib/livepatch/test_klp_shadow_vars.c b/lib/livepatch/test_klp_shadow_vars.c > new file mode 100644 > index 000000000000..18c75b21cb9e > --- /dev/null > +++ b/lib/livepatch/test_klp_shadow_vars.c > > +/* > + * Shadow variable wrapper functions that echo the function and arguments > + * to the kernel log for testing verification. Don't display raw pointers, > + * but use the ptr_id() value instead. > + */ > +void *shadow_get(void *obj, unsigned long id) > +{ > + void *ret = klp_shadow_get(obj, id); > + > + pr_info("klp_%s(obj=PTR%d, id=0x%lx) = PTR%d\n", > + __func__, ptr_id(obj), id, ptr_id(ret)); > + > + return ret; > +} > +void shadow_free(void *obj, unsigned long id, klp_shadow_dtor_t dtor) > +{ > + klp_shadow_free(obj, id, dtor); > + pr_info("klp_%s(obj=PTR%d, id=0x%lx, dtor=PTR%d)\n", > + __func__, ptr_id(obj), id, ptr_id(dtor)); > +} Sparse (make C=1) would be happier with those two being static. Otherwise it works as expected. Good job! Miroslav -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html