linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] selftests/tpm2: Install run-time Python modules
@ 2019-06-20 13:18 Daniel Díaz
  2019-06-20 21:40 ` Jarkko Sakkinen
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Díaz @ 2019-06-20 13:18 UTC (permalink / raw)
  To: shuah
  Cc: linux-kselftest, Daniel Díaz, Petr Vorel, Joey Pabalinas,
	Jarkko Sakkinen, open list

When ordinarily running the tests, upon `make install', the
following error is encountered:
  ImportError: No module named tpm2_tests
because the Python files are not installed at the moment.

Fix this by adding both Python modules as accompanying
TEST_FILES in the Makefile.

Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
---
 tools/testing/selftests/tpm2/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/tpm2/Makefile b/tools/testing/selftests/tpm2/Makefile
index 9dd848427a7b..bf401f725eef 100644
--- a/tools/testing/selftests/tpm2/Makefile
+++ b/tools/testing/selftests/tpm2/Makefile
@@ -2,3 +2,4 @@
 include ../lib.mk
 
 TEST_PROGS := test_smoke.sh test_space.sh
+TEST_FILES := tpm2.py tpm2_tests.py
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] selftests/tpm2: Install run-time Python modules
  2019-06-20 13:18 [PATCH] selftests/tpm2: Install run-time Python modules Daniel Díaz
@ 2019-06-20 21:40 ` Jarkko Sakkinen
  0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2019-06-20 21:40 UTC (permalink / raw)
  To: Daniel Díaz
  Cc: shuah, linux-kselftest, Petr Vorel, Joey Pabalinas, open list

On Thu, Jun 20, 2019 at 08:18:19AM -0500, Daniel Díaz wrote:
> When ordinarily running the tests, upon `make install', the
> following error is encountered:
>   ImportError: No module named tpm2_tests
> because the Python files are not installed at the moment.
> 
> Fix this by adding both Python modules as accompanying
> TEST_FILES in the Makefile.
> 
> Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

Question the kselftests maintainers: can I take this to [1] and
include to my 5.3 PR?

[1] git://git.infradead.org/users/jjs/linux-tpmdd.git

/Jarkko

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-20 21:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-20 13:18 [PATCH] selftests/tpm2: Install run-time Python modules Daniel Díaz
2019-06-20 21:40 ` Jarkko Sakkinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).