linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Martin <Dave.Martin@arm.com>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: linux-kselftest@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, shuah@kernel.org,
	andreyknvl@google.com
Subject: Re: [PATCH 01/13] kselftest: arm64: introduce new boilerplate code
Date: Fri, 21 Jun 2019 11:34:49 +0100	[thread overview]
Message-ID: <20190621103449.GI2790@e103592.cambridge.arm.com> (raw)
In-Reply-To: <20190613111335.7645-2-cristian.marussi@arm.com>

On Thu, Jun 13, 2019 at 12:13:23PM +0100, Cristian Marussi wrote:
> Added a new arm64-specific empty subsystem amongst TARGETS of KSFT build
> framework; once populated with testcases, it will be possible to build
> and invoke the new KSFT TARGETS=arm64 related tests from the toplevel
> Makefile in the usual ways.
> 
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> ---
>  tools/testing/selftests/Makefile       |  1 +
>  tools/testing/selftests/arm64/Makefile | 51 ++++++++++++++++++++++++++
>  tools/testing/selftests/arm64/README   | 44 ++++++++++++++++++++++
>  3 files changed, 96 insertions(+)
>  create mode 100644 tools/testing/selftests/arm64/Makefile
>  create mode 100644 tools/testing/selftests/arm64/README
> 
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 9781ca79794a..4ff0b41ead8a 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -1,5 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0
>  TARGETS = android
> +TARGETS += arm64
>  TARGETS += bpf
>  TARGETS += breakpoints
>  TARGETS += capabilities
> diff --git a/tools/testing/selftests/arm64/Makefile b/tools/testing/selftests/arm64/Makefile
> new file mode 100644
> index 000000000000..03a0d4f71218
> --- /dev/null
> +++ b/tools/testing/selftests/arm64/Makefile
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (C) 2019 ARM Limited
> +
> +# When ARCH not overridden for crosscompiling, lookup machine
> +ARCH ?= $(shell uname -m)
> +ARCH := $(shell echo $(ARCH) | sed -e s/aarch64/arm64/)
> +
> +ifeq ("x$(ARCH)", "xarm64")
> +SUBDIRS :=
> +else
> +SUBDIRS :=
> +endif
> +
> +CFLAGS := -Wall -O2 -g
> +
> +export CC
> +export CFLAGS
> +
> +all:
> +	@for DIR in $(SUBDIRS); do				\
> +		BUILD_TARGET=$(OUTPUT)/$$DIR;			\
> +		mkdir -p $$BUILD_TARGET;			\
> +		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;		\
> +	done
> +
> +install: all
> +	@for DIR in $(SUBDIRS); do				\
> +		BUILD_TARGET=$(OUTPUT)/$$DIR;			\
> +		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;		\
> +	done
> +
> +run_tests: all
> +	@for DIR in $(SUBDIRS); do				\
> +		BUILD_TARGET=$(OUTPUT)/$$DIR;			\
> +		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;		\
> +	done
> +
> +# Avoid any output on non arm64 on emit_tests
> +emit_tests: all
> +	@for DIR in $(SUBDIRS); do				\
> +		BUILD_TARGET=$(OUTPUT)/$$DIR;			\
> +		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;		\
> +	done
> +
> +clean:
> +	@for DIR in $(SUBDIRS); do				\
> +		BUILD_TARGET=$(OUTPUT)/$$DIR;			\
> +		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;		\
> +	done
> +
> +.PHONY: all clean install run_tests emit_tests
> diff --git a/tools/testing/selftests/arm64/README b/tools/testing/selftests/arm64/README
> new file mode 100644
> index 000000000000..d5aa7a2eda78
> --- /dev/null
> +++ b/tools/testing/selftests/arm64/README
> @@ -0,0 +1,44 @@
> +KSelfTest ARM64
> +===============
> +
> +- These tests are arm64 specific and so not built or run but just skipped
> +  completely when env-variable ARCH is found to be different than 'arm64'
> +  and `uname -m` reports other than 'aarch64'.
> +
> +- Holding true the above, ARM64 KSFT tests can be run:
> +
> +   + as standalone (example for signal tests)
> +
> +      $ make -C tools/testing/selftest/arm64/signal clean
> +      $ make -C tools/testing/selftest/arm64/signal \
> +		INSTALL_PATH=<your-installation-path> install
> +
> +      and then launching on the target device inside the installed path:
> +
> +      device# cd <your-installed-path> && ./test_arm64_signals.sh [-k | -v]

(Similar nits to those on the arm64-specific documentation in the next
patch.)

Otherwise, this looks sensible.

[...]

Cheers
---Dave

  reply	other threads:[~2019-06-21 10:34 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13 11:13 [PATCH 00/13] Add arm64/signal initial kselftest support Cristian Marussi
2019-06-13 11:13 ` [PATCH 01/13] kselftest: arm64: introduce new boilerplate code Cristian Marussi
2019-06-21 10:34   ` Dave Martin [this message]
2019-06-13 11:13 ` [PATCH 02/13] kselftest: arm64: adds arm64/signal support code Cristian Marussi
2019-06-21 10:35   ` Dave Martin
2019-06-28 18:53     ` Cristian Marussi
2019-06-13 11:13 ` [PATCH 03/13] kselftest: arm64: mangle_sp_misaligned Cristian Marussi
2019-06-21 10:35   ` Dave Martin
2019-07-02 15:39     ` Cristian Marussi
2019-07-03  8:39       ` Dave P Martin
2019-06-13 11:13 ` [PATCH 04/13] kselftest: arm64: mangle_pc_invalid Cristian Marussi
2019-06-21 10:35   ` Dave Martin
2019-06-13 11:13 ` [PATCH 05/13] kselftest: arm64: mangle_pstate_invalid_daif_bits Cristian Marussi
2019-06-21 10:35   ` Dave Martin
2019-06-13 11:13 ` [PATCH 06/13] kselftest: arm64: mangle_pstate_invalid_state_toggle Cristian Marussi
2019-06-21 10:35   ` Dave Martin
2019-06-13 11:13 ` [PATCH 07/13] kselftest: arm64: mangle_pstate_invalid_mode_el? Cristian Marussi
2019-06-21 10:35   ` Dave Martin
2019-06-13 11:13 ` [PATCH 08/13] kselftest: arm64: mangle_pstate_ssbs_regs Cristian Marussi
2019-06-21 10:35   ` Dave Martin
2019-07-02 15:51     ` Cristian Marussi
2019-07-03  8:56       ` Dave Martin
2019-06-13 11:13 ` [PATCH 09/13] kselftest: arm64: fake_sigreturn_misaligned Cristian Marussi
2019-06-21 10:36   ` Dave Martin
2019-06-13 11:13 ` [PATCH 10/13] kselftest: arm64: fake_sigreturn_bad_magic Cristian Marussi
2019-06-21 10:36   ` Dave Martin
2019-07-03 17:41     ` Cristian Marussi
2019-06-13 11:13 ` [PATCH 11/13] kselftest: arm64: fake_sigreturn_bad_size Cristian Marussi
2019-06-21 10:36   ` Dave Martin
2019-07-03 17:46     ` Cristian Marussi
2019-06-13 11:13 ` [PATCH 12/13] kselftest: arm64: fake_sigreturn_bad_size_for_magic0 Cristian Marussi
2019-06-21 10:36   ` Dave Martin
2019-07-03 17:50     ` Cristian Marussi
2019-06-13 11:13 ` [PATCH 13/13] kselftest: arm64: fake_sigreturn_overflow_reserved Cristian Marussi
2019-06-21 10:36   ` Dave Martin
2019-07-03 17:51     ` Cristian Marussi
2019-06-21 10:34 ` [PATCH 00/13] Add arm64/signal initial kselftest support Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190621103449.GI2790@e103592.cambridge.arm.com \
    --to=dave.martin@arm.com \
    --cc=andreyknvl@google.com \
    --cc=cristian.marussi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).