From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4B90C74A4B for ; Thu, 11 Jul 2019 11:32:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 898FF21537 for ; Thu, 11 Jul 2019 11:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562844767; bh=s8uYoozdh6txZl5Ipy+chi8ZC2Lp0gQsc+r2gcl/KTI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=t2Ei222TSK9Ey4zvPJ5PfvAGzH0IHrCxGETXFiDoa3Q226DeMZM9Xs6WvDpUuMPIT JEL0sGte+QI5Aumfp/EPP/C3KAHem9GwwtDgkYF4MYD42d8wWx/sFFjJ5ys5MV+1dK 5sJON1sXHxKPckZGrkQlfF+RKRILdEgtb4KfunOA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728180AbfGKLcr (ORCPT ); Thu, 11 Jul 2019 07:32:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:55882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728026AbfGKLcq (ORCPT ); Thu, 11 Jul 2019 07:32:46 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 442D820665; Thu, 11 Jul 2019 11:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562844766; bh=s8uYoozdh6txZl5Ipy+chi8ZC2Lp0gQsc+r2gcl/KTI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X1KQY/ZINjJSIFh09hdp2m914Z23PYFAjsktC6vM6BO9qnBGcq9szxI1anh6YPKda 17FMYC9TApNw8fvbMrRNsWFoMFDaW9iDj8fprhujtNW0b7zZYfhaxMMvbeCerC1Lb1 Ar8ijqAgm9rYbm4d7j6RdPcYQDPnEGViXYanDGks= Date: Thu, 11 Jul 2019 12:32:39 +0100 From: Will Deacon To: Thomas Gleixner Cc: Vincenzo Frascino , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org, andre.przywara@arm.com, arnd@arndb.de, huw@codeweavers.com, catalin.marinas@arm.com, daniel.lezcano@linaro.org, will.deacon@arm.com, linux@armlinux.org.uk, ralf@linux-mips.org, salyzyn@android.com, luto@kernel.org, paul.burton@mips.com, john.stultz@linaro.org, 0x7f454c46@gmail.com, linux@rasmusvillemoes.dk, sthotton@marvell.com, pcc@google.com Subject: Re: [PATCH v2] arm64: vdso: Fix ABI regression in compat vdso Message-ID: <20190711113238.qefdp5zvrjhsmtfu@willie-the-truck> References: <20190621095252.32307-11-vincenzo.frascino@arm.com> <20190710140119.23417-1-vincenzo.frascino@arm.com> <20190711094505.rwy6t6wu2cvmvwr6@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, Jul 11, 2019 at 12:34:27PM +0200, Thomas Gleixner wrote: > On Thu, 11 Jul 2019, Will Deacon wrote: > > On Wed, Jul 10, 2019 at 03:01:19PM +0100, Vincenzo Frascino wrote: > > > Prior to the introduction of Unified vDSO support and compat layer for > > > vDSO on arm64, AT_SYSINFO_EHDR was not defined for compat tasks. > > > In the current implementation, AT_SYSINFO_EHDR is defined even if the > > > compat vdso layer is not built and this causes a regression in the > > > expected behavior of the ABI. > > > > > > Restore the ABI behavior making sure that AT_SYSINFO_EHDR for compat > > > tasks is defined only when CONFIG_COMPAT_VDSO is enabled. > > > > > > Reported-by: John Stultz > > > Signed-off-by: Vincenzo Frascino > > > --- > > > arch/arm64/include/asm/elf.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm64/include/asm/elf.h b/arch/arm64/include/asm/elf.h > > > index 3c7037c6ba9b..b618017205a3 100644 > > > --- a/arch/arm64/include/asm/elf.h > > > +++ b/arch/arm64/include/asm/elf.h > > > @@ -202,7 +202,7 @@ typedef compat_elf_greg_t compat_elf_gregset_t[COMPAT_ELF_NGREG]; > > > ({ \ > > > set_thread_flag(TIF_32BIT); \ > > > }) > > > -#ifdef CONFIG_GENERIC_COMPAT_VDSO > > > +#ifdef CONFIG_COMPAT_VDSO > > > #define COMPAT_ARCH_DLINFO \ > > > do { \ > > > /* \ > > > > Acked-by: Will Deacon > > > > I can take this at -rc1 via arm64 unless tglx plans to send it during the > > rest of the merge window. Please let me know. > > I had no plan to pick it up, but if you want I can route it through timer > urgents so it hits Linus tree before rc1. I don't think it's urgent, so I'll just queue it along with any other fixes that show up at -rc1. Cheers, Will