From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8819C32750 for ; Tue, 13 Aug 2019 04:24:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB7E72084D for ; Tue, 13 Aug 2019 04:24:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565670299; bh=lYF5vY6A9XGwdbOcoCHf2uLqBmu5NRPCpxTmtGqQJhs=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=BcmVID4VDOJXY//8ASm7nIr831kPj/8VtddNQydet4QiGs8ZKx8QUJhZeD9qcEjze ZevrPI98VtRfHCoUz5GVzWeiOYsDItWj/US/+hOPy7hWDcR27ahDMdJ6kGPBHWMFjB 0Cct7jGZW6ZRvq5kejxd+S+p2tdRD16FQRM3c0RM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726506AbfHMEY4 (ORCPT ); Tue, 13 Aug 2019 00:24:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:55550 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725786AbfHMEY4 (ORCPT ); Tue, 13 Aug 2019 00:24:56 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4A04320644; Tue, 13 Aug 2019 04:24:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565670295; bh=lYF5vY6A9XGwdbOcoCHf2uLqBmu5NRPCpxTmtGqQJhs=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=KCRm3MnmcSr4r9DJLeJoz79Ahddq949WPxyIzyFrExKgucBorBvg59cJpXDJ+jPp5 PBgeRsjFWXar7544719pqTdGFznCN2uAa+rzB3U0UHd+Ej51ANvVlEQmefqncFeorT zM+muQSvFjFYVLYxKXgAxydELtwpClAqHSPnhY/8= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190812182421.141150-11-brendanhiggins@google.com> References: <20190812182421.141150-1-brendanhiggins@google.com> <20190812182421.141150-11-brendanhiggins@google.com> Subject: Re: [PATCH v12 10/18] kunit: test: add tests for kunit test abort From: Stephen Boyd Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, Tim.Bird@sony.com, amir73il@gmail.com, dan.carpenter@oracle.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, knut.omang@oracle.com, logang@deltatee.com, mpe@ellerman.id.au, pmladek@suse.com, rdunlap@infradead.org, richard@nod.at, rientjes@google.com, rostedt@goodmis.org, wfg@linux.intel.com, Brendan Higgins To: Brendan Higgins , frowand.list@gmail.com, gregkh@linuxfoundation.org, jpoimboe@redhat.com, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, peterz@infradead.org, robh@kernel.org, shuah@kernel.org, tytso@mit.edu, yamada.masahiro@socionext.com User-Agent: alot/0.8.1 Date: Mon, 12 Aug 2019 21:24:54 -0700 Message-Id: <20190813042455.4A04320644@mail.kernel.org> Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Quoting Brendan Higgins (2019-08-12 11:24:13) > + > +static int kunit_try_catch_test_init(struct kunit *test) > +{ > + struct kunit_try_catch_test_context *ctx; > + > + ctx =3D kunit_kzalloc(test, sizeof(*ctx), GFP_KERNEL); Can this fail? Should return -ENOMEM in that case? > + test->priv =3D ctx; > + > + ctx->try_catch =3D kunit_kmalloc(test, > + sizeof(*ctx->try_catch), > + GFP_KERNEL);