Linux-kselftest Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH 3/3] selftests: ir: fix ir_loopback test failure
       [not found] ` <20190810114458.8883-3-sean@mess.org>
@ 2019-08-12 14:25   ` shuah
  2019-08-13  7:37     ` Sean Young
  0 siblings, 1 reply; 2+ messages in thread
From: shuah @ 2019-08-12 14:25 UTC (permalink / raw)
  To: Sean Young, linux-media, open list:KERNEL SELFTEST FRAMEWORK, shuah

On 8/10/19 5:44 AM, Sean Young wrote:
> The decoder is called rc-mm, not rcmm. This was renamed late in the cycle
> so this bug crept in.
> 
> Cc: Shuah Khan <shuah@kernel.org>
> Signed-off-by: Sean Young <sean@mess.org>
> ---
>   tools/testing/selftests/ir/ir_loopback.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/ir/ir_loopback.c b/tools/testing/selftests/ir/ir_loopback.c
> index e700e09e3682..af7f9c7d59bc 100644
> --- a/tools/testing/selftests/ir/ir_loopback.c
> +++ b/tools/testing/selftests/ir/ir_loopback.c
> @@ -54,9 +54,9 @@ static const struct {
>   	{ RC_PROTO_RC6_MCE, "rc-6-mce", 0x00007fff, "rc-6" },
>   	{ RC_PROTO_SHARP, "sharp", 0x1fff, "sharp" },
>   	{ RC_PROTO_IMON, "imon", 0x7fffffff, "imon" },
> -	{ RC_PROTO_RCMM12, "rcmm-12", 0x00000fff, "rcmm" },
> -	{ RC_PROTO_RCMM24, "rcmm-24", 0x00ffffff, "rcmm" },
> -	{ RC_PROTO_RCMM32, "rcmm-32", 0xffffffff, "rcmm" },
> +	{ RC_PROTO_RCMM12, "rcmm-12", 0x00000fff, "rc-mm" },
> +	{ RC_PROTO_RCMM24, "rcmm-24", 0x00ffffff, "rc-mm" },
> +	{ RC_PROTO_RCMM32, "rcmm-32", 0xffffffff, "rc-mm" },
>   };
>   
>   int lirc_open(const char *rc)
> 

Thanks Sean! Please cc - linux-keseltest makling list on these patches.

I can take this through my tree or here is my Ack for it go through
media tree

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 3/3] selftests: ir: fix ir_loopback test failure
  2019-08-12 14:25   ` [PATCH 3/3] selftests: ir: fix ir_loopback test failure shuah
@ 2019-08-13  7:37     ` Sean Young
  0 siblings, 0 replies; 2+ messages in thread
From: Sean Young @ 2019-08-13  7:37 UTC (permalink / raw)
  To: shuah; +Cc: linux-media, open list:KERNEL SELFTEST FRAMEWORK

On Mon, Aug 12, 2019 at 08:25:41AM -0600, shuah wrote:
> On 8/10/19 5:44 AM, Sean Young wrote:
> > The decoder is called rc-mm, not rcmm. This was renamed late in the cycle
> > so this bug crept in.
> > 
> > Cc: Shuah Khan <shuah@kernel.org>
> > Signed-off-by: Sean Young <sean@mess.org>
> > ---
> >   tools/testing/selftests/ir/ir_loopback.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/tools/testing/selftests/ir/ir_loopback.c b/tools/testing/selftests/ir/ir_loopback.c
> > index e700e09e3682..af7f9c7d59bc 100644
> > --- a/tools/testing/selftests/ir/ir_loopback.c
> > +++ b/tools/testing/selftests/ir/ir_loopback.c
> > @@ -54,9 +54,9 @@ static const struct {
> >   	{ RC_PROTO_RC6_MCE, "rc-6-mce", 0x00007fff, "rc-6" },
> >   	{ RC_PROTO_SHARP, "sharp", 0x1fff, "sharp" },
> >   	{ RC_PROTO_IMON, "imon", 0x7fffffff, "imon" },
> > -	{ RC_PROTO_RCMM12, "rcmm-12", 0x00000fff, "rcmm" },
> > -	{ RC_PROTO_RCMM24, "rcmm-24", 0x00ffffff, "rcmm" },
> > -	{ RC_PROTO_RCMM32, "rcmm-32", 0xffffffff, "rcmm" },
> > +	{ RC_PROTO_RCMM12, "rcmm-12", 0x00000fff, "rc-mm" },
> > +	{ RC_PROTO_RCMM24, "rcmm-24", 0x00ffffff, "rc-mm" },
> > +	{ RC_PROTO_RCMM32, "rcmm-32", 0xffffffff, "rc-mm" },
> >   };
> >   int lirc_open(const char *rc)
> > 
> 
> Thanks Sean! Please cc - linux-keseltest makling list on these patches.

I'll do that next time, thanks.

> I can take this through my tree or here is my Ack for it go through
> media tree
> 
> Acked-by: Shuah Khan <skhan@linuxfoundation.org>

I'm just preparing a pull request for Mauro so I'll put it in there
with your Ack.

Thank you

Sean

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190810114458.8883-1-sean@mess.org>
     [not found] ` <20190810114458.8883-3-sean@mess.org>
2019-08-12 14:25   ` [PATCH 3/3] selftests: ir: fix ir_loopback test failure shuah
2019-08-13  7:37     ` Sean Young

Linux-kselftest Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \
		linux-kselftest@vger.kernel.org linux-kselftest@archiver.kernel.org
	public-inbox-index linux-kselftest


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest


AGPL code for this site: git clone https://public-inbox.org/ public-inbox