From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
shuah@kernel.org, pmladek@suse.com, sergey.senozhatsky@gmail.com,
rostedt@goodmis.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
frowand.list@gmail.com, sboyd@kernel.org,
Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v1] printk: add dummy vprintk_emit for when CONFIG_PRINTK=n
Date: Wed, 28 Aug 2019 14:24:05 +0900 [thread overview]
Message-ID: <20190828052405.GA526@jagdpanzerIV> (raw)
In-Reply-To: <20190828044529.GA30152@google.com>
On (08/27/19 21:45), Brendan Higgins wrote:
[..]
> I actually use it in a very similar way as dev_printk() does. I am using
> it to define an equivalent kunit_printk(), which takes a log level, and
> adds its own test information to the log.
>
> What I have now is:
>
> static int kunit_vprintk_emit(int level, const char *fmt, va_list args)
> {
> return vprintk_emit(0, level, NULL, 0, fmt, args);
> }
>
> static int kunit_printk_emit(int level, const char *fmt, ...)
> {
> va_list args;
> int ret;
>
> va_start(args, fmt);
> ret = kunit_vprintk_emit(level, fmt, args);
> va_end(args);
>
> return ret;
> }
>
> static void kunit_vprintk(const struct kunit *test,
> const char *level,
> struct va_format *vaf)
> {
> kunit_printk_emit(level[1] - '0', "\t# %s: %pV", test->name, vaf);
> }
Basically, for prefixes we have pr_fmt().
#define pr_fmt(fmt) "module name: " fmt
but pr_fmt() is mostly for static prefixes. If that doesn't work for
you, then maybe you can tweak kunit_foo() macros?
E.g. something like this
#define kunit_info(test, fmt, ...) \
printk(KERN_INFO "\t# %s: " pr_fmt(fmt), (test)->name, ##__VA_ARGS__)
#define kunit_err(test, fmt, ...) \
printk(KERN_ERR "\t# %s: " pr_fmt(fmt), (test)->name, ##__VA_ARGS__)
#define kunit_debug(test, fmt, ...) \
printk(KERN_DEBUG "\t# %s: " pr_fmt(fmt), (test)->name, ##__VA_ARGS__)
Would that do the trick? Am I missing something?
-ss
next prev parent reply other threads:[~2019-08-28 5:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 23:48 [PATCH v1] printk: add dummy vprintk_emit for when CONFIG_PRINTK=n Brendan Higgins
2019-08-28 0:45 ` Randy Dunlap
2019-08-28 3:02 ` Sergey Senozhatsky
2019-08-28 4:45 ` Brendan Higgins
2019-08-28 5:24 ` Sergey Senozhatsky [this message]
2019-08-28 9:28 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828052405.GA526@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=brendanhiggins@google.com \
--cc=frowand.list@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).