Linux-kselftest Archive on lore.kernel.org
 help / color / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: shuah@kernel.org, kunit-dev@googlegroups.com,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	frowand.list@gmail.com, sboyd@kernel.org, pmladek@suse.com,
	sergey.senozhatsky@gmail.com, rostedt@goodmis.org,
	Randy Dunlap <rdunlap@infradead.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH v2] kunit: fix failure to build without printk
Date: Wed, 28 Aug 2019 18:49:29 +0900
Message-ID: <20190828094929.GA14038@jagdpanzerIV> (raw)
In-Reply-To: <20190828093143.163302-1-brendanhiggins@google.com>

On (08/28/19 02:31), Brendan Higgins wrote:
[..]
> Previously KUnit assumed that printk would always be present, which is
> not a valid assumption to make. Fix that by removing call to
> vprintk_emit, and calling printk directly.
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Link: https://lore.kernel.org/linux-kselftest/0352fae9-564f-4a97-715a-fabe016259df@kernel.org/T/#t
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>

[..]

> -static void kunit_vprintk(const struct kunit *test,
> -			  const char *level,
> -			  struct va_format *vaf)
> -{
> -	kunit_printk_emit(level[1] - '0', "\t# %s: %pV", test->name, vaf);
> -}

This patch looks good to me. I like the removal of recursive
vsprintf() (%pV).

	-ss

  reply index

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28  9:31 Brendan Higgins
2019-08-28  9:49 ` Sergey Senozhatsky [this message]
2019-08-28 11:50   ` Petr Mladek
2019-08-29 17:01   ` shuah
2019-08-30  4:44     ` Joe Perches
2019-08-30  4:56       ` Joe Perches
2019-08-30 18:38       ` Brendan Higgins
2019-08-30 20:46         ` Joe Perches
2019-08-30 21:58           ` Tim.Bird
2019-08-30 22:46             ` Joe Perches
2019-08-30 23:02               ` Brendan Higgins
2019-08-30 23:22                 ` Tim.Bird
2019-08-30 23:36                   ` Joe Perches
2019-08-30 23:37                   ` Brendan Higgins
2019-08-30 23:43                     ` Joe Perches
2019-08-31  0:06                     ` Tim.Bird
2019-09-02 12:52                     ` Petr Mladek
2019-09-02 14:39                       ` shuah
2019-08-30 23:29               ` Tim.Bird
2019-08-30  5:19     ` Sergey Senozhatsky
2019-08-28 15:52 ` Randy Dunlap

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190828094929.GA14038@jagdpanzerIV \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=brendanhiggins@google.com \
    --cc=frowand.list@gmail.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sboyd@kernel.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=sfr@canb.auug.org.au \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-kselftest Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \
		linux-kselftest@vger.kernel.org
	public-inbox-index linux-kselftest

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git