From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: "George G. Davis" <george_davis@mentor.com>
Cc: Shuah Khan <shuah@kernel.org>,
Jerry Hoemann <jerry.hoemann@hpe.com>,
Colin Ian King <colin.king@canonical.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Eugeniu Rosca <erosca@de.adit-jv.com>,
Eugeniu Rosca <roscaeugeniu@gmail.com>
Subject: Re: [PATCH v2] selftests: watchdog: Add optional file argument
Date: Fri, 30 Aug 2019 15:38:13 +0200 [thread overview]
Message-ID: <20190830133813.GA23613@vmlxhi-102.adit-jv.com> (raw)
In-Reply-To: <1567169597-10330-1-git-send-email-george_davis@mentor.com>
Hi George,
On Fri, Aug 30, 2019 at 08:53:16AM -0400, George G. Davis wrote:
> Some systems have multiple watchdog devices where the first device
> registered is assigned to the /dev/watchdog device file. In order
> to test other watchdog devices, add an optional file argument for
> selecting non-default watchdog devices for testing.
>
> Tested-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> Signed-off-by: George G. Davis <george_davis@mentor.com>
> ---
> v1:
> - https://lkml.org/lkml/2019/8/29/16
> v2:
> - Update printf for ENOENT case based on report from Eugeniu Rosca
Below interdiff [1] matches my expectations. Thanks!
Reviewed-by: Eugeniu Rosca <erosca@de.adit-jv.com>
[1] interdiff <(git show patch_v1) <(git show patch_v2)
diff -u b/tools/testing/selftests/watchdog/watchdog-test.c b/tools/testing/selftests/watchdog/watchdog-test.c
--- b/tools/testing/selftests/watchdog/watchdog-test.c
+++ b/tools/testing/selftests/watchdog/watchdog-test.c
@@ -107,7 +107,7 @@
if (fd == -1) {
if (errno == ENOENT)
- printf("Watchdog device not enabled.\n");
+ printf("Watchdog device (%s) not found.\n", file);
else if (errno == EACCES)
printf("Run watchdog as root.\n");
else
--
Best Regards,
Eugeniu.
next prev parent reply other threads:[~2019-08-30 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 12:53 [PATCH v2] selftests: watchdog: Add optional file argument George G. Davis
2019-08-30 13:38 ` Eugeniu Rosca [this message]
2019-08-30 14:26 ` George G. Davis
2019-08-30 15:12 ` shuah
2019-08-30 16:13 ` George G. Davis
2019-08-30 16:20 ` shuah
2019-08-30 19:36 ` George G. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830133813.GA23613@vmlxhi-102.adit-jv.com \
--to=erosca@de.adit-jv.com \
--cc=colin.king@canonical.com \
--cc=george_davis@mentor.com \
--cc=jerry.hoemann@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=roscaeugeniu@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).