From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C42B8C3A5A7 for ; Wed, 4 Sep 2019 11:49:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DE7822CF7 for ; Wed, 4 Sep 2019 11:49:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729838AbfIDLts (ORCPT ); Wed, 4 Sep 2019 07:49:48 -0400 Received: from foss.arm.com ([217.140.110.172]:52790 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729774AbfIDLts (ORCPT ); Wed, 4 Sep 2019 07:49:48 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E495337; Wed, 4 Sep 2019 04:49:47 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 774743F246; Wed, 4 Sep 2019 04:49:46 -0700 (PDT) Date: Wed, 4 Sep 2019 12:49:44 +0100 From: Dave Martin To: Cristian Marussi Cc: linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shuah@kernel.org, amit.kachhap@arm.com, andreyknvl@google.com Subject: Re: [PATCH v5 11/11] kselftest: arm64: fake_sigreturn_misaligned_sp Message-ID: <20190904114944.GB27757@arm.com> References: <20190902112932.36129-1-cristian.marussi@arm.com> <20190902112932.36129-12-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190902112932.36129-12-cristian.marussi@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Mon, Sep 02, 2019 at 12:29:32pm +0100, Cristian Marussi wrote: > Add a simple fake_sigreturn testcase which places a valid sigframe on a > non-16 bytes aligned SP. Expects a SIGSEGV on test PASS. > > Signed-off-by: Cristian Marussi > --- > v3 --> v4 > - fix commit > - use new fake_sigreturn misalig_bytes params > - removed TODO > - added test description > --- > .../testcases/fake_sigreturn_misaligned_sp.c | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c > > diff --git a/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c > new file mode 100644 > index 000000000000..1e089e66f9f3 > --- /dev/null > +++ b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c > @@ -0,0 +1,37 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2019 ARM Limited > + * > + * Place a fake sigframe on the stack at a misaligned SP: on sigreturn > + * Kernel must spot this attempt and the test case is expected to be > + * terminated via SEGV. > + */ > + > +#include > +#include > + > +#include "test_signals_utils.h" > +#include "testcases.h" > + > +struct fake_sigframe sf; > + > +static int fake_sigreturn_misaligned_run(struct tdescr *td, > + siginfo_t *si, ucontext_t *uc) > +{ > + /* just to fill the ucontext_t with something real */ > + if (!get_current_context(td, &sf.uc)) > + return 1; > + > + /* Forcing sigframe on misaligned SP (16 + 3) */ > + fake_sigreturn(&sf, sizeof(sf), 3); Can we add tests on the TODO list for other misalignments? a) 4 (i.e., __alignof__(struct _aarch64_ctx)) b) 8 (i.e., sizeof(struct _aarch64_ctx)) This may help catch potential wrong-bitmask bugs in the kernel when checking the alignment. Similarly to my suggestion on patch 10, these can go on the TODO list and added later (probably macro-ised). For now, let's get this series settled as-is -- so, after responding to nits: Reviewed-by: Dave Martin