Linux-kselftest Archive on
 help / color / Atom feed
From: Christian Brauner <>
To: Eugene Syromiatnikov <>
	Christian Brauner <>,
	Shuah Khan <>,, Adrian Reber <>
Subject: Re: [PATCH v2 0/6] Update clone3 self-tests
Date: Mon, 16 Sep 2019 09:49:34 +0200
Message-ID: <20190916074933.j33qc2z3hynpj2gf@wittgenstein> (raw)
In-Reply-To: <>

On Tue, Sep 10, 2019 at 07:01:30PM +0100, Eugene Syromiatnikov wrote:
> Hello.
> This patch set updates clone3 selftest in several aspects:
>  - adding checks for exit_signal invalid values handling;
>  - adding clone3 to selftests targets;
>  - enabling clone3 tests on all architectures;
>  - minor cleanups of the clone3 test.
> Applied on top of brauer/linux.git/for-next.

So I like this series a lot! Testing is very important.
And thanks for catching the clone3() exit_signal problem. This way we
got to release a non-broken kernel. :)

Some notes: I dropped the set_tid extension from the core process
updates for 5.4 because we ended up in a discussion that made it clear
we potentially need the ability to restore pids in multiple pid
namespaces. This means we need some more discussion and the patchset is
delayed for at least one release.
Unfortunately, this also means the test that you have based yours upon
does not exist anymore. However, the tests should not be blocked on
this. I'd encourage you to talk to Adrian (who is Cced here anyway) and
come up with a clone3() test suite I can merge. You can very likely do a
Co-Developed-by so no-ones work gets dropped. :)

Ideally I'd like to see:
- verifying passing different struct sizes works correctly
- verify that flag combinations work correctly
- verify that struct members have correct values etc. pp.

We definitely want the exit_signal test as a regression test so it
doesn't bite us again!

(Oh, please also add tool/test/selftests/clone3/ to the pidfd/core
 process MAINTAINERS entry.)


  parent reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10 18:01 Eugene Syromiatnikov
2019-09-10 18:01 ` [PATCH v2 1/6] selftests/clone3: convert test modes into an enum Eugene Syromiatnikov
2019-09-10 18:01 ` [PATCH v2 2/6] selftests/clone3: add a check for invalid exit_signal Eugene Syromiatnikov
2019-09-10 18:01 ` [PATCH v2 3/6] selftests/clone3: use uint64_t for flags parameter Eugene Syromiatnikov
2019-09-10 18:02 ` [PATCH v2 4/6] selftests/clone3: fix up format strings Eugene Syromiatnikov
2019-09-10 18:02 ` [PATCH v2 5/6] selftests/clone3: enable clone3 self-tests on all architectures Eugene Syromiatnikov
2019-09-10 18:02 ` [PATCH v2 6/6] selftests: add clone3 to TARGETS Eugene Syromiatnikov
2019-09-16  7:49 ` Christian Brauner [this message]
2019-09-16  8:12   ` [PATCH v2 0/6] Update clone3 self-tests Adrian Reber
2019-09-16  8:14     ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190916074933.j33qc2z3hynpj2gf@wittgenstein \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-kselftest Archive on

Archives are clonable:
	git clone --mirror linux-kselftest/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kselftest linux-kselftest/ \
	public-inbox-index linux-kselftest

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone